| Message ID | 20241220093514.3094521-1-Sergiy_Kibrik@epam.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XEN,v1] ioreq: allow arch_vcpu_ioreq_completion() to signal an error | expand |
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 5c3d0c69aa..9b1592d505 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -47,7 +47,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) default: ASSERT_UNREACHABLE(); - break; + return false; } return true; diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h index 29a17e8ff5..2583eca0d5 100644 --- a/xen/include/xen/ioreq.h +++ b/xen/include/xen/ioreq.h @@ -118,7 +118,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion); static inline bool arch_vcpu_ioreq_completion(enum vio_completion completion) { ASSERT_UNREACHABLE(); - return true; + return false; } #endif
Return false from arch_vcpu_ioreq_completion() when completion is not handled. According to coding-best-practices.pandoc an error should be propagated to caller, if caller is expecting to handle it, which seems to the case for callers of arch_vcpu_ioreq_completion(). Suggested-by: Jan Beulich <jbeulich@suse.com> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com> --- This change has been suggested by Jan some time ago during review of another series, here's link to discussion: https://lore.kernel.org/xen-devel/952701cd-83d8-4c1f-9f38-ee63ba582d66@suse.com/ --- xen/arch/x86/hvm/ioreq.c | 2 +- xen/include/xen/ioreq.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)