From patchwork Tue Mar 11 20:13:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stewart Hildebrand X-Patchwork-Id: 14012680 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E13CFC282EC for ; Tue, 11 Mar 2025 20:14:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.909055.1316132 (Exim 4.92) (envelope-from ) id 1ts5zA-0007QV-2T; Tue, 11 Mar 2025 20:13:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 909055.1316132; Tue, 11 Mar 2025 20:13:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ts5z9-0007QO-UD; Tue, 11 Mar 2025 20:13:55 +0000 Received: by outflank-mailman (input) for mailman id 909055; Tue, 11 Mar 2025 20:13:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ts5z8-0007Om-S4 for xen-devel@lists.xenproject.org; Tue, 11 Mar 2025 20:13:54 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062f.outbound.protection.outlook.com [2a01:111:f403:2412::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 596ce305-feb5-11ef-9898-31a8f345e629; Tue, 11 Mar 2025 21:13:53 +0100 (CET) Received: from MW2PR16CA0043.namprd16.prod.outlook.com (2603:10b6:907:1::20) by SA0PR12MB4350.namprd12.prod.outlook.com (2603:10b6:806:92::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Tue, 11 Mar 2025 20:13:47 +0000 Received: from SJ5PEPF000001D4.namprd05.prod.outlook.com (2603:10b6:907:1:cafe::ee) by MW2PR16CA0043.outlook.office365.com (2603:10b6:907:1::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.24 via Frontend Transport; Tue, 11 Mar 2025 20:13:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ5PEPF000001D4.mail.protection.outlook.com (10.167.242.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Tue, 11 Mar 2025 20:13:46 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 11 Mar 2025 15:13:45 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 11 Mar 2025 15:13:45 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 11 Mar 2025 15:13:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 596ce305-feb5-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vktNRAzL13EwQwecDIgsmFncbikwgvwpRXizKI6XE6Efg082ggV6jfLIeMAhJtRgTrt22h+vfqkmU3bPL9qOtF01GveP2s/M/lDIT3P1Zi/A1EaMZaJ2YVuCvTVozew1/WKFkQ8zw3VM/yQxHOPfgwg1aP6JapegybYD2X/OARUqdJjzDXpG9rraCc2XqIy5E0zKb7LU6QLONISPzql/ows486zRBEC258D52WNvPe3fR7wZnI7UcytygjnV7W4NWsC429Xbs+FaAcpfHwrPJCrNL5wUCopZBkfcZB87AnkW8aB9RaTS70M4GqTxf4Et+tIMJ6zEOtjx41Np7lM00g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YWC1ZmRyzVKf29WtlD1YmvsLfF7BuCPZ18tLYB4GxzQ=; b=wFrft5+h88LBJHchHhayKAmNCRFisHJxCO8Mh6rtuy1+j98cyWb5BxHKc4rhF3cdB2gvhm/J0TXy527ZHFOyHUnZQeB28upIbEaQEYktyttiAnqDo9OmRgpz/hs29WJuPdDOQa73kjRbZvqzI2QQpy0z35wp4VZ1QsJI1MhCLCgvb7OuzbgDYYwF7eB5g/0mhcGQ5zLqdkNzDDDIJ6HKyhWyhrGEiscnwxTRo9GW5pvwNBvvRocr9hh9JC7jWAkiIXsmqbqlnvsct95CyJP7xKcmu/pByfKiYYBmGCTlOSZ9WldSRBsjAzoEvihozjDu9628l4dujf27+28ULN7+9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YWC1ZmRyzVKf29WtlD1YmvsLfF7BuCPZ18tLYB4GxzQ=; b=aAe4jDE3tM2UK0Kf5aNHUCL3nNvBVwDsttuvAl+wEqFYusMVk/mde4q35y8ZuNKAV7hgg3tNAXVKHwmiMqRx8PukMTblk9vVdnmqjWB1UJXA0bHByYOpFEDNAqVOKVJSWVUs0FaqguOeb4ufD7Pf//3FiRQ7d1Bp5lQt9E4bzKU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , =?utf-8?q?Roger_Pau_Monn?= =?utf-8?q?=C3=A9?= Subject: [PATCH v17 2/2] xen/arm: check read handler behavior Date: Tue, 11 Mar 2025 16:13:28 -0400 Message-ID: <20250311201330.365499-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311201330.365499-1-stewart.hildebrand@amd.com> References: <20250311201330.365499-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D4:EE_|SA0PR12MB4350:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ebdf3d1-22b5-4eea-abff-08dd60d93b0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?A5bxoAtSoSfOWAztYXzqzFzK3n7JMyZ?= =?utf-8?q?CeMUJ7cQosPWMHzYGnL8AM+ympFjFM+jXF0BcXBkiNlAEz2YdwwYDAozhfqEqxf9w?= =?utf-8?q?xiKSvqj8SjAaRQVVDNjNcv8uqKsVrtHOF3fEutexU6CnpsOe2/OxRJYQjjwbNA07v?= =?utf-8?q?Wse4dvuI1gru2Rzhfc/V+Jk/PcDCe2FUMk3SsX2fJPlPFJVodRMGt8JmFdx0Fhy6e?= =?utf-8?q?Z0nCnUEP4kjryJS8Zygm7mMFoDhgyv3HJWFXW0YsCVipnwUWDCPDXwJQBBUHp1lbX?= =?utf-8?q?ppKtNs1ZnhDYcuk6Z/4MEeI5x1kfz72/BZ48MeimYl2egal0yzOR8a5UrsmJ8/7Xq?= =?utf-8?q?2aFuPIKqxVYlYLu+pLYLUhTuK07X7l5b3Mdghtva0jk4NM9Xl7PjHm+rIvgVSXBVn?= =?utf-8?q?cdEYMk+XCnIFDjEMPiomghkWuTSmUXasYVjxCosnaVfJZCxXtAef+oS/H50EbI8dC?= =?utf-8?q?CL5/UcprnedHK4/ckuB4GdS0ltbuynfswCwPKSLrGpLuHh+pK7RauT3pAX4b9hBaZ?= =?utf-8?q?hJsvM2wukWV//Y7RDBwjfxHN2m5nXXJTRUCFFFqEh3tGbsFYFeso7Yb2bFujB28Nu?= =?utf-8?q?CF9CFIZkPIQvHXI2D6v9RgDxF1cUSENJKb0n8VfLAX7nk9EyC2wD+o+CUzaRafk2O?= =?utf-8?q?5i0a9BAiWnjVna1z7/fBA69MtaSYmDCiSClZ7xeyBsiY1uy9nWtt6RupxTPqG+/4t?= =?utf-8?q?pWxUqWrs5uQfuguf+nW1AgGMsxGN9ELYS/kREQpdUW6IKoXEwCM9Lud1Uja+WVWi2?= =?utf-8?q?HBftHzrHHxJG5V9xnr8uPEiugatfW35lNFpL0oYRTEF7Iu/6yB5Mt2PTit9Wrk+1u?= =?utf-8?q?gtbEyk9PpFHfsuy/eTekwybNPNQzgIe3Rgd+hhapl9MSPyZRPq5bQk+2gS9wmnP14?= =?utf-8?q?ySFiYQvVz13u/y5feWwSui43NLLpVnoArxirtQKvhOd5xBNbw0QSZnthoThQae/Ja?= =?utf-8?q?ytlI6Yj2NutuGA/3Zfxud6mwFMpAw1WkhNjhWj7fbPQ6NXOHN4/yM2K2La06JJ0Me?= =?utf-8?q?hYcm/dw5GLFpYsjsjEQOw8bA1kzcFCiWWIihMb8AFpvryWfwu3J7upXG6DE/k1oeL?= =?utf-8?q?E/P9A0cv9KG0tD0++ORpEPcfuuFw29DkiS3XzWpemLOu475rvi4powrprqQ7O0b+B?= =?utf-8?q?d+dNzS/rqDZDHzhOe2C6CQ2fpgJaCV2bgjCHPWjbzYgiV40Zg1SpRVzF6pcT/gGTQ?= =?utf-8?q?ioH1aaw6P7NyTp4p0LqOOGM1QiDs8APIh29FOZ9VyHzqM1sVa5rPOu7de5YldM4WU?= =?utf-8?q?mDYPfz1Jd/be1sXK33z4vM7NZ4INmRY3eyChcwnL+UXCf6/XRPETycml8qT0Mqj7r?= =?utf-8?q?mYcK3fyAYzf4bVh+Izy4EVjQmX8J6YeCDC7El6VouIqIH/bEU/dG1JeO/lMjV7xHz?= =?utf-8?q?BljEtZ6AOjy2kMar9KA9KcJsg72Qds8SP1UbqarOezYDwvBPhIjyrc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2025 20:13:46.9902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ebdf3d1-22b5-4eea-abff-08dd60d93b0e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4350 We expect mmio read handlers to leave the bits above the access size zeroed. Add an ASSERT to check this aspect of read handler behavior. Suggested-by: Roger Pau Monné Signed-off-by: Stewart Hildebrand --- v16->v17: * new patch See https://lore.kernel.org/xen-devel/bc6660ef-59f1-4514-9792-067d987e3fbc@xen.org/ Also see 7db7bd0f319f ("arm/vpci: honor access size when returning an error") Also see xen/arch/arm/ioreq.c:handle_ioserv() --- xen/arch/arm/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 653428e16c1f..68b5dca70026 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -37,6 +37,8 @@ static enum io_state handle_read(const struct mmio_handler *handler, if ( !handler->ops->read(v, info, &r, handler->priv) ) return IO_ABORT; + ASSERT((r & ~GENMASK_ULL((1U << info->dabt.size) * 8 - 1, 0)) == 0); + r = sign_extend(dabt, r); set_user_reg(regs, dabt.reg, r);