From patchwork Thu Mar 13 16:39:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 14015456 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E13AEC282DE for ; Thu, 13 Mar 2025 16:43:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.913030.1319214 (Exim 4.92) (envelope-from ) id 1tsleM-0003Y0-9g; Thu, 13 Mar 2025 16:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 913030.1319214; Thu, 13 Mar 2025 16:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tsleM-0003Xt-59; Thu, 13 Mar 2025 16:43:14 +0000 Received: by outflank-mailman (input) for mailman id 913030; Thu, 13 Mar 2025 16:43:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tslao-0000Wn-A9 for xen-devel@lists.xenproject.org; Thu, 13 Mar 2025 16:39:34 +0000 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [2607:f8b0:4864:20::1035]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba9c1e4f-0029-11f0-9898-31a8f345e629; Thu, 13 Mar 2025 17:39:28 +0100 (CET) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2ff80290debso2584834a91.3 for ; Thu, 13 Mar 2025 09:39:30 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30119265938sm4020084a91.39.2025.03.13.09.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:39:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba9c1e4f-0029-11f0-9898-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741883969; x=1742488769; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/B5foK4Qy0OvFQVWNYpVAAsAF+tVTKpBxl4Jl8CdPFE=; b=FK+6ebUWD5Sapcuwjy7wYqq5wTRuRuk5HqYFrVy/OhkvAtlGQ7tE7KQGSL60kw7HcR pdsNE1IhXuyK/EkSw8jvtFlkTHEmfypneJ26kbXfqTxernJD4XdP3UDra58iMZV24vgd SohN7lHDQBecpl8JIlTzIyssEEaAdw1AF8woKqTYTf4dKUf9VdI6+gSwtiWltIgiIsrm SkwGU4r7GqDZ1rmnvebTOJlcvi6c7bfjMZmc6K4bdZ/CeWYBDPpuPkNe14scXeL6P7uR GUEoCn4o1icIWvGqByqGphPuPXg55P2HD8yJi1Nc6/h3sbWEULxVxmLaUESO7vV4OhmZ gXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741883969; x=1742488769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/B5foK4Qy0OvFQVWNYpVAAsAF+tVTKpBxl4Jl8CdPFE=; b=m1JiOb1ipersXZ8QowoI5huqnCKfge5MgkM7HlO7EFb6sHzXKUOgEg+awEOtMr+Yap XYS51Tdz6jbKjYOQuBpj2emI8f5cW10lsygZDaZzMoUsgYWvrx5n2f8pMpZG+oEv0Ket sji2Df1P/B+9k0vO+OizE9QUHPmj9pA3sGfFC6tnR+aWts8v1K3qtg7zdYdNo1leLPq6 dGAJo25GPxa2IOAKR6CWBJsa3lvXC6+uWxengB4gIN53/xDOjKK8EtiddxWz4tTLDQlF WhEe520875zeZoliJHpWJ2CrZepFUpLHSMjKRUF5qO8nYx4iE9qun5e7VQmJcRtynKlJ WBDQ== X-Forwarded-Encrypted: i=1; AJvYcCWOmGoRbzUYIt+VEv0lsxJrgbP99unnox2rwkV9wYXXIp9eWVKLRxSxClib6zw1PHRlkfOKefUicuM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwqTK7WI8Y6IYXD0cvIMck37gdjku/vcPlv5P7hVM2aDfDixjvD itnoONxUpRdUisSGnZSWHtH1RA98fk+ZS9GLvo/VgmRPctgUg8j67OE9l6MdHi0= X-Gm-Gg: ASbGncslhRmWMocYtaDzq10MxoKQReJM6dkVcGRy7M3cNqYqyd2lv/ZnNS5nuS05I27 AsrQ+/+qWTy0vLfH93nPq3Purdr+vp9BHRLVjOLeAgnv4Eqvx3q1HjKP/qw9koootMcSIUAPG5r 0BlzHXi9adNhXOklBzPD43IhLZ8pNg4EXxQM6fT0f4XEolPQTlGmXVq3TY62myPJWezwEym06be ZHH82JnyeC6lFuFXXUabwDQCGKjCuV+wwYSGbaXht85vy0W2iv/6YEu3ewoCcD7OIa0Q+fRkl88 vq4p/LC8pHSwB0plkrL/l/mO1EDqja/I8uYtCmSP9hbe X-Google-Smtp-Source: AGHT+IE6Us2O77TYYfj/J/RmRU6RhpFIbMCr45wvgkThs0nxBWSPhVRimj63yvMeVhIF4wJ+N9MdKw== X-Received: by 2002:a17:90b:3bc6:b0:2ff:58b8:5c46 with SMTP id 98e67ed59e1d1-3014e82fd9amr271511a91.8.1741883968719; Thu, 13 Mar 2025 09:39:28 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Harsh Prateek Bora , Liu Zhiwei , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Peter Xu , alex.bennee@linaro.org, manos.pitsidianakis@linaro.org, Stefano Stabellini , Paolo Bonzini , qemu-ppc@nongnu.org, Richard Henderson , kvm@vger.kernel.org, David Hildenbrand , Palmer Dabbelt , Weiwei Li , qemu-riscv@nongnu.org, Alistair Francis , Anthony PERARD , Yoshinori Sato , Daniel Henrique Barboza , Nicholas Piggin , Pierrick Bouvier Subject: [PATCH v4 15/17] include/exec/memory: move devend functions to memory-internal.h Date: Thu, 13 Mar 2025 09:39:01 -0700 Message-Id: <20250313163903.1738581-16-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> References: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Only system/physmem.c and system/memory.c use those functions, so we can move then to internal header. Signed-off-by: Pierrick Bouvier --- include/exec/memory-internal.h | 19 +++++++++++++++++++ include/exec/memory.h | 18 ------------------ 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b729f3b25ad..c75178a3d6b 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -43,5 +43,24 @@ void address_space_dispatch_free(AddressSpaceDispatch *d); void mtree_print_dispatch(struct AddressSpaceDispatch *d, MemoryRegion *root); + +/* returns true if end is big endian. */ +static inline bool devend_big_endian(enum device_endian end) +{ + QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && + DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); + + if (end == DEVICE_NATIVE_ENDIAN) { + return target_words_bigendian(); + } + return end == DEVICE_BIG_ENDIAN; +} + +/* enum device_endian to MemOp. */ +static inline MemOp devend_memop(enum device_endian end) +{ + return devend_big_endian(end) ? MO_BE : MO_LE; +} + #endif #endif diff --git a/include/exec/memory.h b/include/exec/memory.h index 70177304a92..a3bb0542bf6 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,24 +3138,6 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -/* returns true if end is big endian. */ -static inline bool devend_big_endian(enum device_endian end) -{ - QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && - DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); - - if (end == DEVICE_NATIVE_ENDIAN) { - return target_words_bigendian(); - } - return end == DEVICE_BIG_ENDIAN; -} - -/* enum device_endian to MemOp. */ -static inline MemOp devend_memop(enum device_endian end) -{ - return devend_big_endian(end) ? MO_BE : MO_LE; -} - /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., * to manage the actual amount of memory consumed by the VM (then, the memory