| Message ID | 20250318233617.849903-6-dmukhin@ford.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen/console: cleanup console input switch logic | expand |
On 19.03.2025 00:36, dmkhn@proton.me wrote: > Update the name to emphasize the physical console input switch to a > new owner domain following the naming notation in the console driver. > > No functional change. > > Signed-off-by: Denis Mukhin <dmukhin@ford.com> While I don't strictly mind the change, I'd like to point out that ... > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -511,7 +511,7 @@ static bool console_check_focus_by_id(domid_t domid) > return !!d; > } > > -static void switch_serial_input(void) > +static void console_switch_focus(void) ... unlike the description says, "input" isn't reflected at all in the new name. Jan
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index d04a5335ce..5910ff701c 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -511,7 +511,7 @@ static bool console_check_focus_by_id(domid_t domid) return !!d; } -static void switch_serial_input(void) +static void console_switch_focus(void) { unsigned int next_rx = console_rx; @@ -618,7 +618,7 @@ static void cf_check serial_rx(char c) /* We eat CTRL-<switch_char> in groups of 3 to switch console input. */ if ( ++switch_code_count == 3 ) { - switch_serial_input(); + console_switch_focus(); switch_code_count = 0; } return; @@ -1162,7 +1162,7 @@ void __init console_endboot(void) "toggle host/guest log level adjustment", 0); /* Serial input is directed to DOM0 by default. */ - switch_serial_input(); + console_switch_focus(); } int __init console_has(const char *device)
Update the name to emphasize the physical console input switch to a new owner domain following the naming notation in the console driver. No functional change. Signed-off-by: Denis Mukhin <dmukhin@ford.com> --- xen/drivers/char/console.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)