From patchwork Tue Mar 25 17:27:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stewart Hildebrand X-Patchwork-Id: 14029309 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3EAEC3600D for ; Tue, 25 Mar 2025 17:28:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.926788.1329635 (Exim 4.92) (envelope-from ) id 1tx849-0005dk-9m; Tue, 25 Mar 2025 17:27:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 926788.1329635; Tue, 25 Mar 2025 17:27:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tx849-0005dd-6l; Tue, 25 Mar 2025 17:27:53 +0000 Received: by outflank-mailman (input) for mailman id 926788; Tue, 25 Mar 2025 17:27:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tx847-000578-W6 for xen-devel@lists.xenproject.org; Tue, 25 Mar 2025 17:27:51 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20609.outbound.protection.outlook.com [2a01:111:f403:2415::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79d18ccd-099e-11f0-9ea3-5ba50f476ded; Tue, 25 Mar 2025 18:27:51 +0100 (CET) Received: from MN2PR18CA0017.namprd18.prod.outlook.com (2603:10b6:208:23c::22) by PH8PR12MB6842.namprd12.prod.outlook.com (2603:10b6:510:1c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 17:27:45 +0000 Received: from BL02EPF0001A102.namprd05.prod.outlook.com (2603:10b6:208:23c:cafe::7d) by MN2PR18CA0017.outlook.office365.com (2603:10b6:208:23c::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.42 via Frontend Transport; Tue, 25 Mar 2025 17:27:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A102.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Tue, 25 Mar 2025 17:27:45 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 25 Mar 2025 12:27:44 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 25 Mar 2025 12:27:43 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79d18ccd-099e-11f0-9ea3-5ba50f476ded ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hRhU2CYPoPfGmsqQRbwGPcQGbFL5Po+P8n6WqmJuXoU826fUJXYRGC9H10cIjIGJIwxImkzA0cZ4lPzVcZwITUVaYPAUUxPEA0m2FAYDo66JAC8+rPUTUTW5lfuijVcOXTMBS5fTdwhfAV+YVtUBcgFRSx1V2sQXjSMh2FO2hOJGfSgC4sB76P6SjVKwLiBnhn1au8y2ZBTlHVaqM3j0AymcelP1jMeNTdIGrldfkY68U1ZI7GJQf/v8y4CFl2hvS/RDqCWjm/PpwiaprxYV6SBrteb69afxoAt1ZMDvR6DJDYQZmJMR7YRJNIOh61Sll+GWG7IrjSLqs0h0y87l9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J9DOB8WC9KWKSLTBEGC4wKPk/MvEmQT8Ry5fkhruHXQ=; b=ptwdiZk/vVAMpd+avE8R43Tm3LZoF/fZXWygN5vH+/EYjQGS7yBu2NQsTCuGEDHgzslgDv8h85I5Ks4IWxGaCXNsihGsrJGfciHWvSMosMZ+Dodh/BejIdxmJwQWtnf3agPgpjZrwsRUiqgu2nAbBh1fr1D5CS8ZtgfKNMPs1sEkP7S9H8tHwMgei/d8giTO4GI39w6v1wp1Eppf71dtIf+mEnCjP/XutSnSCdllGtHPb7FHjpSIJ2PbT3TYTyJxy/vRd5m8abBDmXivasOvrEeWdRxgIFJe8j15nSmMUpVbi4sM1gbVRLVVcVQEtzp0bFAqOMTsWsw45UbJRK7Rjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J9DOB8WC9KWKSLTBEGC4wKPk/MvEmQT8Ry5fkhruHXQ=; b=gfzQfHaBv0WyK+CGim8uSy7AxOkQsUA4DULaYxFEiogFTFIG1md2VWNBYfUCm+Mk4xBp6/GbHHtmWO4LFElb06MZc0vxCAbNADrVpvWsaBPMO5eKuTBEtVSTxrIhw0Hwb/DGsVq9VPt5+gXW7CvKRdDTPGUmEpfaBFsfrcn4z+k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , =?utf-8?q?Roger_Pau_Monn?= =?utf-8?q?=C3=A9?= Subject: [PATCH v18 2/2] xen/arm: check read handler behavior Date: Tue, 25 Mar 2025 13:27:26 -0400 Message-ID: <20250325172727.600716-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250325172727.600716-1-stewart.hildebrand@amd.com> References: <20250325172727.600716-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: stewart.hildebrand@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A102:EE_|PH8PR12MB6842:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a056a46-cb60-489e-f8b1-08dd6bc25afb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?NDjMb13wA46rx9m9DD96Fg5Ahb45iRz?= =?utf-8?q?BuFyhyG5mk1nKQyfDvQw36YpmEjdrIveLcXT1aK0uT9fkDB+ZQChYTEMcgiI6UqlC?= =?utf-8?q?aB/aNe73IzDMUX20ZX7nBmb1NXCW5jkh4cki5LFOcyv1MN913P9UJdwfe6NE/ZX8n?= =?utf-8?q?t1XCxlfb9z4+TSaMuCw4pIWHdHcEj+BVFyxFcbMmPaBP7CMm+Ys0ZUHFGHYHXbH4/?= =?utf-8?q?nUgyw3qVvs2sGN+32aiTz6p+hfgQb/8q2uzwrqCP+lSlJeeGnYrCnyC0kZZ/BIuYJ?= =?utf-8?q?68WeSg4jRXqUICtfANZkmq57MQtrLKqCz+N+irJUgV++wFJOJmWMoi2JrSaQJcbPP?= =?utf-8?q?UTPpCOXL282NtOXjQB4cSMl/qLw/bONw7E4Nd/TtVoUeJY02Z3J5T8zlPoPD7p2GI?= =?utf-8?q?r+K0MYtxCJhvAl3dKWzQYQS5PBBCggisLxwPEj/kTEk4jWs5RmHalpJiN2NI128c5?= =?utf-8?q?Y1KZy4KHEViYORE/7UH+LjfQMv68Ev63+KnBZ7NLqTVdlg2KhdfKoW9wzitABh6r2?= =?utf-8?q?cibBeJGd0Glso3tbSALTGOEgWJfnosq5SGmDkaPHQ1e757L1bG2SRuTt5zAmFCmow?= =?utf-8?q?41DE5D3QxAGdydcMbiBzdwX84bnm47rxEl8iyRBu01yRJ/bwS/Ezoeq+8kIpxPL9B?= =?utf-8?q?2vchona6GFcrRPJ9EJxt7a1Pd8NI9LrfuLB5aXsTkhD9dJnwBdbXHDbTdcIe5TxJR?= =?utf-8?q?oLikKT0Hqx7FoswSygt49r2WSVUJcax1vtnm3NrxRMcJFrnhNYZ2P+c4hKkAxkjAG?= =?utf-8?q?sPn+1ripoyRLl7gAl+iXQfXYyBQEyq9VVEgAKqJ+QyVLbjsgG2ZRU4g84n4KrPQZP?= =?utf-8?q?hDHl7LE3cf9OXq60782+vD7+1c3tXeLklIt8Xt0PlGqYaI16LVEmL1cszKEptUMQU?= =?utf-8?q?ewdIyagP7qvoF+HQ2MAfGdxXmu7vEBlbdjWH6KobE/RAcZzgdbL92EmFAthqcRXh1?= =?utf-8?q?02+AJx18/V6d4W4seSKr6VPnFQ9EVREr/CmPozC8EGU/EoUynAFjTa2wCHr8yW6rn?= =?utf-8?q?EFz3XUxqP3eJ6cS39OUxEb3IOpEtBwm7dbg9y+71smo4tmC6N/0lJYxYGUEMm+uIT?= =?utf-8?q?iUTSFLn+8dm6tC6o3fFVI2EIweeuiC2zE128ScvmMjTqKtGLH7PtzOgrnvHaMu6fA?= =?utf-8?q?TbyVmTPzDcFzQYHpn98be4RUuHYZzbTntjOn58Jr+dE/q2tzEsTpAsh3On4wGY249?= =?utf-8?q?MJqukvp7+f7Kjkv45C4hEo2YIQ/wvgxR0vhyI5GMbviaoAmfe59OUrZmgSWB0ga+A?= =?utf-8?q?4iMxMptaiZYJ4hyDojTJATcasyKM/qOuvavxsu9EEV8ShOs3Q/IDvjQbkCTfS+CWX?= =?utf-8?q?YvUeexlm2+daGzXe6KtnzYmrVw/Gwtof85xtU+FZcytCcvfOtMQn5ckjvR2GYnCXW?= =?utf-8?q?0APflKXTn9deeFHcGhZnJiR5P1tbFEsp4JoSxV3JuVoZLuwXb7lCmA=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2025 17:27:45.0299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a056a46-cb60-489e-f8b1-08dd6bc25afb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A102.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6842 We expect mmio read handlers to leave the bits above the access size zeroed. Add an ASSERT to check this aspect of read handler behavior. Suggested-by: Roger Pau Monné Signed-off-by: Stewart Hildebrand Acked-by: Julien Grall --- v17->v18: * no change v16->v17: * new patch See https://lore.kernel.org/xen-devel/bc6660ef-59f1-4514-9792-067d987e3fbc@xen.org/ Also see 7db7bd0f319f ("arm/vpci: honor access size when returning an error") Also see xen/arch/arm/ioreq.c:handle_ioserv() --- xen/arch/arm/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c index 653428e16c1f..68b5dca70026 100644 --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -37,6 +37,8 @@ static enum io_state handle_read(const struct mmio_handler *handler, if ( !handler->ops->read(v, info, &r, handler->priv) ) return IO_ABORT; + ASSERT((r & ~GENMASK_ULL((1U << info->dabt.size) * 8 - 1, 0)) == 0); + r = sign_extend(dabt, r); set_user_reg(regs, dabt.reg, r);