| Message ID | 20250328134427.874848-16-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen: Centralise byteswap infrastructure | expand |
On 3/28/25 2:44 PM, Andrew Cooper wrote: > With the common code moved fully onto xen/byteorder.h, clean up the dregs. > > The use of byteorder.h in io.h appears to have been copy&paste from ARM. It's > not needed, but macros and types are. > > No functional change. > > Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com> Reviewed-by:Oleksii Kurochko <oleksii.kurochko@gmail.com> Thanks. ~ Oleksii > --- > CC: Anthony PERARD<anthony.perard@vates.tech> > CC: Michal Orzel<michal.orzel@amd.com> > CC: Jan Beulich<jbeulich@suse.com> > CC: Julien Grall<julien@xen.org> > CC: Roger Pau Monné<roger.pau@citrix.com> > CC: Stefano Stabellini<sstabellini@kernel.org> > CC: Volodymyr Babchuk<Volodymyr_Babchuk@epam.com> > CC: Bertrand Marquis<bertrand.marquis@arm.com> > CC: Shawn Anastasio<sanastasio@raptorengineering.com> > CC: Oleksii Kurochko<oleksii.kurochko@gmail.com> > CC: Daniel P. Smith<dpsmith@apertussolutions.com> > CC: Lin Liu<lin.liu@citrix.com> > > v5: > * New > --- > xen/arch/riscv/include/asm/byteorder.h | 14 -------------- > xen/arch/riscv/include/asm/io.h | 3 ++- > 2 files changed, 2 insertions(+), 15 deletions(-) > delete mode 100644 xen/arch/riscv/include/asm/byteorder.h > > diff --git a/xen/arch/riscv/include/asm/byteorder.h b/xen/arch/riscv/include/asm/byteorder.h > deleted file mode 100644 > index a32bca02df38..000000000000 > --- a/xen/arch/riscv/include/asm/byteorder.h > +++ /dev/null > @@ -1,14 +0,0 @@ > -#ifndef ASM__RISCV__BYTEORDER_H > -#define ASM__RISCV__BYTEORDER_H > - > -#include <xen/byteorder.h> > - > -#endif /* ASM__RISCV__BYTEORDER_H */ > -/* > - * Local variables: > - * mode: C > - * c-file-style: "BSD" > - * c-basic-offset: 4 > - * indent-tabs-mode: nil > - * End: > - */ > diff --git a/xen/arch/riscv/include/asm/io.h b/xen/arch/riscv/include/asm/io.h > index 55f329dde321..8bab4ffa0390 100644 > --- a/xen/arch/riscv/include/asm/io.h > +++ b/xen/arch/riscv/include/asm/io.h > @@ -38,7 +38,8 @@ > #ifndef ASM__RISCV__IO_H > #define ASM__RISCV__IO_H > > -#include <asm/byteorder.h> > +#include <xen/macros.h> > +#include <xen/types.h> > > /* > * The RISC-V ISA doesn't yet specify how to query or modify PMAs, so we can't
diff --git a/xen/arch/riscv/include/asm/byteorder.h b/xen/arch/riscv/include/asm/byteorder.h deleted file mode 100644 index a32bca02df38..000000000000 --- a/xen/arch/riscv/include/asm/byteorder.h +++ /dev/null @@ -1,14 +0,0 @@ -#ifndef ASM__RISCV__BYTEORDER_H -#define ASM__RISCV__BYTEORDER_H - -#include <xen/byteorder.h> - -#endif /* ASM__RISCV__BYTEORDER_H */ -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/arch/riscv/include/asm/io.h b/xen/arch/riscv/include/asm/io.h index 55f329dde321..8bab4ffa0390 100644 --- a/xen/arch/riscv/include/asm/io.h +++ b/xen/arch/riscv/include/asm/io.h @@ -38,7 +38,8 @@ #ifndef ASM__RISCV__IO_H #define ASM__RISCV__IO_H -#include <asm/byteorder.h> +#include <xen/macros.h> +#include <xen/types.h> /* * The RISC-V ISA doesn't yet specify how to query or modify PMAs, so we can't
With the common code moved fully onto xen/byteorder.h, clean up the dregs. The use of byteorder.h in io.h appears to have been copy&paste from ARM. It's not needed, but macros and types are. No functional change. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Anthony PERARD <anthony.perard@vates.tech> CC: Michal Orzel <michal.orzel@amd.com> CC: Jan Beulich <jbeulich@suse.com> CC: Julien Grall <julien@xen.org> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> CC: Bertrand Marquis <bertrand.marquis@arm.com> CC: Shawn Anastasio <sanastasio@raptorengineering.com> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com> CC: Daniel P. Smith <dpsmith@apertussolutions.com> CC: Lin Liu <lin.liu@citrix.com> v5: * New --- xen/arch/riscv/include/asm/byteorder.h | 14 -------------- xen/arch/riscv/include/asm/io.h | 3 ++- 2 files changed, 2 insertions(+), 15 deletions(-) delete mode 100644 xen/arch/riscv/include/asm/byteorder.h