| Message ID | 20250402101013.220310-1-michal.orzel@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen/arm: Include xen/vmap.h in mm.c | expand |
Hi Michal, > On 2 Apr 2025, at 12:10, Michal Orzel <michal.orzel@amd.com> wrote: > > As reported by ECLAIR scan, MISRA requires declaration to be visible > (R8.4). This is not the case for ioremap(). > > Fixes: 2cd02c27d327 ("arm/mpu: Implement stubs for ioremap_attr on MPU") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > --- > https://gitlab.com/xen-project/hardware/xen/-/jobs/9599092510 > as part of the most recent pipeline on staging: > https://gitlab.com/xen-project/hardware/xen/-/pipelines/1748174980 > --- > xen/arch/arm/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 5a52f0c623e5..0613c1916936 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -12,6 +12,7 @@ > #include <xen/grant_table.h> > #include <xen/guest_access.h> > #include <xen/mm.h> > +#include <xen/vmap.h> > > #include <xsm/xsm.h> > > -- > 2.25.1 >
On 02/04/2025 11:10 am, Michal Orzel wrote: > As reported by ECLAIR scan, MISRA requires declaration to be visible > (R8.4). This is not the case for ioremap(). > > Fixes: 2cd02c27d327 ("arm/mpu: Implement stubs for ioremap_attr on MPU") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 5a52f0c623e5..0613c1916936 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -12,6 +12,7 @@ #include <xen/grant_table.h> #include <xen/guest_access.h> #include <xen/mm.h> +#include <xen/vmap.h> #include <xsm/xsm.h>
As reported by ECLAIR scan, MISRA requires declaration to be visible (R8.4). This is not the case for ioremap(). Fixes: 2cd02c27d327 ("arm/mpu: Implement stubs for ioremap_attr on MPU") Signed-off-by: Michal Orzel <michal.orzel@amd.com> --- https://gitlab.com/xen-project/hardware/xen/-/jobs/9599092510 as part of the most recent pipeline on staging: https://gitlab.com/xen-project/hardware/xen/-/pipelines/1748174980 --- xen/arch/arm/mm.c | 1 + 1 file changed, 1 insertion(+)