From patchwork Mon Jun 27 11:29:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9200403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD7FB60757 for ; Mon, 27 Jun 2016 11:31:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ADEE02854B for ; Mon, 27 Jun 2016 11:31:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2C752857C; Mon, 27 Jun 2016 11:31:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C177B2854B for ; Mon, 27 Jun 2016 11:31:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHUjF-0006dM-P5; Mon, 27 Jun 2016 11:29:25 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHUjE-0006dC-Ly for xen-devel@lists.xenproject.org; Mon, 27 Jun 2016 11:29:24 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id E9/0B-31810-31E01775; Mon, 27 Jun 2016 11:29:23 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRWlGSWpSXmKPExsXitHSDva4wX2G 4wZnlChbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8a0F+eYC46LVVybwtfAOEeoi5GTQ0LAX+LE u3esIDabgK5E05a/bCA2r4CgxMmZT1hAbGYBHYkFuz+xQdjyEtvfzmGGqLGXWHHjPBOIzSKgK vHo8kt2EFtEQFHiR/tRdoj6iYwSh66mgtjCApoSk99eZobYayLxduFOoJkcHEICahJz18eDmB IC3BJ/u+0nMPLOQnLELCRHzEJyxAJG5lWM6sWpRWWpRbomeklFmekZJbmJmTm6hgbGermpxcW J6ak5iUnFesn5uZsYgcHEAAQ7GBu/OB1ilORgUhLl3fYoN1yILyk/pTIjsTgjvqg0J7X4EKMG B4dA3+cJi5ikWPLy81KVJHj38xSGCwkWpaanVqRl5gDDHaZUgoNHSYR3OUiat7ggMbc4Mx0id YpRUUqcNwgkIQCSyCjNg2uDxdglRlkpYV5GoKOEeApSi3IzS1DlXzGKczAqCfNOB5nCk5lXAj f9FdBiJqDFrNX5IItLEhFSUg2MS0+49r5pMOBnk94YMId77dmQuhnnWyIe7+9ftuX5ROMbfG8 5fk3sF3W5VTfhX4/73JSEQxMe2HVmaTrv1jBU1jdbe0f/zRnHjXYz7e5qR/7Qn2Dv096zX5zf YvvCE2f35k4u4/mcvOvFxANHjjZmvsj9rj6tf/3xFztnVR4Ntv93xU3uisXj90osxRmJhlrMR cWJAJJi8A2sAgAA X-Env-Sender: prvs=979d5a33f=Ian.Jackson@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1467026962!47438900!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39440 invoked from network); 27 Jun 2016 11:29:23 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 27 Jun 2016 11:29:23 -0000 X-IronPort-AV: E=Sophos;i="5.26,536,1459814400"; d="scan'208";a="369813761" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22385.3593.873211.260433@mariner.uk.xensource.com> Date: Mon, 27 Jun 2016 12:29:13 +0100 To: David Scott X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) X-DLP: MIA1 Cc: xen-devel@lists.xenproject.org, Wei Liu , Jan Beulich , Andrew Cooper Subject: [Xen-devel] Xen 4.3, armhf, ocamlopt, wheezy X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Since around January we have been testing our Xen 4.3 stable branches (which still receive security support until very soon) with a version of Debian which was current when 4.3 was also current - ie, wheezy. Debian wheezy has an `ocaml-nox' package, but it does not contain `ocamlopt' on armhf. There is code in `configure' in xen.git#staging-4.3 to attempt to discover whether ocamlopt exists. That code appears to work, correctly detecting that ocamlopt does not exist - but then the build tries to use it anyway: http://logs.test-lab.xenproject.org/osstest/logs/96291/build-armhf/5.ts-xen-build.log I would like to get one final push of Xen 4.3 before it goes out of security support. I don't think this configuration bug in Xen 4.3 is recently introduced. I think that previous tests we were probably using squeeze, which probably did not have ocaml at all, and that we were using an osstest which didn't try to use it. I propose to drop the ocaml package installation from osstest runs using Debian squeeze or Debian wheezy. Feel free to object, if you have a better plan. Also, you might like to consider whether the logic in xen-unstable is correct, wrt the use of ocamlopt. I can't seem even there to find the plumbing which makes use of the result of the configure check. Thanks, Ian. From 6fb8fdd67de8a4ca2b3b26a93f1a6664e3e06a01 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 27 Jun 2016 12:25:14 +0100 Subject: [OSSTEST PATCH] ts-xen-build-prep: Do not install Ocaml on squeeze or wheezy squeeze doesn't (didn't) have it at all. wheezy doesn't have ocamlopt on armhf, and the Xen build system (in the old branches where this is relevant) seems not to be able to test this. In any case we use these old Debian suites when testing old Xen branches, which were (when they were current) built without ocaml. This partially reverts "ts-xen-build-prep: Install Ocaml" bbe1a9b2a6c0. Signed-off-by: Ian Jackson CC: Andrew Cooper CC: Wei Liu CC: David Scott CC: Jan Beulich --- ts-xen-build-prep | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ts-xen-build-prep b/ts-xen-build-prep index c8cebf4..0450811 100755 --- a/ts-xen-build-prep +++ b/ts-xen-build-prep @@ -206,9 +206,11 @@ sub prep () { autoconf automake libtool xsltproc libxml2-utils libxml2-dev libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl - ocaml-nox ocaml-findlib ccache nasm checkpolicy ebtables); + if ($ho->{Suite} !~ m/squeeze|wheezy/) { + push(@packages, qw(ocaml-nox ocaml-findlib)); + } if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) { push(@packages, "libnl-dev"); } else {