From patchwork Thu Oct 6 16:44:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9365155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A26CF6077E for ; Thu, 6 Oct 2016 16:47:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93C75291BB for ; Thu, 6 Oct 2016 16:47:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87F5B291B5; Thu, 6 Oct 2016 16:47:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 18885291B5 for ; Thu, 6 Oct 2016 16:47:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsBms-0004WJ-1Z; Thu, 06 Oct 2016 16:44:50 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsBmq-0004Vf-Lv for xen-devel@lists.xenproject.org; Thu, 06 Oct 2016 16:44:48 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id D4/C9-01767-F7F76F75; Thu, 06 Oct 2016 16:44:47 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRWlGSWpSXmKPExsXitHSDvW59/bd wg8ttohbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aCt5OYCy7zV2w+/JK5gXEDbxcjJ4eEgL/E +zVNrCA2m4CuRNOWv2wgNq+AoMTJmU9YQGxmAR2JBbs/sUHY8hLb385h7mLkAKpxkDj10w0kz CKgIjF/72NGEFtEQFuia8leoFYuoPJWRokfu66ygySEBVIkLrz+AFbEKaAnsfzgSTaQIiGBTU wS+1pnMkMcZCLxduFONpAFQgJqEnPXx4OYEgLcEn+77Scw8s9Cct0sJNfNQnLdAkbmVYwaxal FZalFuoZGeklFmekZJbmJmTm6hgZmermpxcWJ6ak5iUnFesn5uZsYgSHIAAQ7GC9vDDjEKMnB pCTKe6v8W7gQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd7yOqCcYFFqempFWmYOMBpg0hIcPEoiv JdB0rzFBYm5xZnpEKlTjIpS4rwxIAkBkERGaR5cGywCLzHKSgnzMgIdIsRTkFqUm1mCKv+KUZ yDUUmY9wHIFJ7MvBK46a+AFjMBLc5f+gVkcUkiQkqqgbH6gbq9X8u/Lw/37T65+4Pe+gsbVxc Fzszo0tun97DtjZX/82XFJw4s3pi3R7PDd0vXfskFpdwTTb+p/ZlfzrLEuDfqr2LEFVUPTt/o 1WbhG44GNhmmagSx+3/VkFn3y63JP6n2G3t+cPIkVaVXPJamS+4XWxuWZi15U6Juy2/TvOKh1 f9l85VYijMSDbWYi4oTAWie4BS7AgAA X-Env-Sender: prvs=0807beae1=Ian.Jackson@citrix.com X-Msg-Ref: server-13.tower-21.messagelabs.com!1475772285!36856674!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26588 invoked from network); 6 Oct 2016 16:44:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-13.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 6 Oct 2016 16:44:47 -0000 X-IronPort-AV: E=Sophos;i="5.31,454,1473120000"; d="scan'208";a="391120907" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22518.32625.844480.177376@mariner.uk.xensource.com> Date: Thu, 6 Oct 2016 17:44:33 +0100 To: Martin Kletzander In-Reply-To: <20161006104255.GP16414@wheatley> References: <1475600547-1009-1-git-send-email-ian.jackson@eu.citrix.com> <1475600547-1009-3-git-send-email-ian.jackson@eu.citrix.com> <20161006094307.GN16414@wheatley> <22518.8298.846651.893440@mariner.uk.xensource.com> <20161006104255.GP16414@wheatley> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) X-DLP: MIA1 Cc: libvir-list@redhat.com, xen-devel@lists.xenproject.org, Jim Fehlig , Julien Grall Subject: Re: [Xen-devel] [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Martin Kletzander writes ("Re: [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised"): > Well then, unfortunately you do. > > Also, looking at how the code is structured, if you have live migration > but don't have save/restore, you won't have there > at all. Right. OK, thanks. I will add the patch below to my osstest queue. Ian. From 5330ff9222e4e611505149945eef7dc074b4f9b5 Mon Sep 17 00:00:00 2001 In-Reply-To: <20161006104255.GP16414@wheatley> References: <20161006104255.GP16414@wheatley> From: Ian Jackson Date: Thu, 6 Oct 2016 17:38:29 +0100 Subject: [OSSTEST PATCH 3/2] libvirt: Check /capabilities/host/migration_features/live for live migration Cc: libvir-list@redhat.com libvirt is capable of advertising this separately from /capabilities/host/migration_features, so if save/restore is supported but live migration is not, this will do the right thing. We would have preferred libvirt to advertise /capabilities/host/migration_features/save or something, but it doesn't right now, so we continue to use /capabilities/host/migration_features to detect save/restore support. If libvirt changes its feature presentation, then at some future point we should change osstest too. Signed-off-by: Ian Jackson CC: Martin Kletzander CC: Jim Fehlig --- Osstest/Toolstack/libvirt.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm index 250fe47..81e724d 100644 --- a/Osstest/Toolstack/libvirt.pm +++ b/Osstest/Toolstack/libvirt.pm @@ -93,7 +93,8 @@ sub migrate_check ($$) { # local migration is not supported $rc = 1; } else { - $rc = $self->check_capability('/capabilities/host/migration_features'); + $rc = $self->check_capability + ('/capabilities/host/migration_features/live'); } logm("rc=$rc");