From patchwork Tue Oct 18 15:50:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9382515 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4481760839 for ; Tue, 18 Oct 2016 15:55:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 364CD2967A for ; Tue, 18 Oct 2016 15:55:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B1FB2967B; Tue, 18 Oct 2016 15:55:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0A13029677 for ; Tue, 18 Oct 2016 15:55:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwWhE-0004Hb-Gd; Tue, 18 Oct 2016 15:52:56 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwWhD-0004HV-BC for xen-devel@lists.xenproject.org; Tue, 18 Oct 2016 15:52:55 +0000 Received: from [193.109.254.147] by server-11.bemta-6.messagelabs.com id E9/A1-08498-65546085; Tue, 18 Oct 2016 15:52:54 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRWlGSWpSXmKPExsXitHSDvW6YK1u Ewa4rTBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8axthnsBdu5K34+XsXYwHiFs4uRk0NCwF+i YVMzO4jNJqAr0bTlLxuIzSsgKHFy5hMWEJtZQEdiwe5PbBC2vMT2t3OYIWocJLZ9WgsU5+BgE VCV6J1dDxIWETCS6LxzGaq1WuLb/1dg44UFzCUu3pgMZnMKuEs833qQEcQWEmhilLi1OBjiHB OJtwt3go0UElCTmLs+HiLMLXH79FTmCYz8s5AcNwvJcbOQHLeAkXkVo0ZxalFZapGusZFeUlF mekZJbmJmjq6hgZlebmpxcWJ6ak5iUrFecn7uJkZgADIAwQ7G0+sCDzFKcjApifL66bNFCPEl 5adUZiQWZ8QXleakFh9ilOHgUJLgjXEBygkWpaanVqRl5gBjASYtwcGjJMKr4AyU5i0uSMwtz kyHSJ1i1OWYtfzOWiYhlrz8vFQpcV4TkBkCIEUZpXlwI2BxeYlRVkqYlxHoKCGegtSi3MwSVP lXjOIcjErCvAedgKbwZOaVwG16BXQEE9AR5/JYQI4oSURISTUwWv80Z+7aL6c+v+n7miyD/Kn H5uut9sz7cG3+Iwvf9RqFd3VzdqcLHll34s+Z/folk7OC3Y7zzH32b69/5xxvxzbnN1t0gu/a /N+Wc7P411GHA3qbs1hyLeQ2pZcLiu5t3dUoujd76u178Q63+tvd0z78dn2/xeFsGQu3meGbo 0ciszV2bJjvqsRSnJFoqMVcVJwIAORLpBHGAgAA X-Env-Sender: prvs=092a1e8e5=Ian.Jackson@citrix.com X-Msg-Ref: server-14.tower-27.messagelabs.com!1476805972!53588803!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 51878 invoked from network); 18 Oct 2016 15:52:53 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-14.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 18 Oct 2016 15:52:53 -0000 X-IronPort-AV: E=Sophos;i="5.31,362,1473120000"; d="scan'208";a="393188307" From: Ian Jackson MIME-Version: 1.0 Message-ID: <22534.17607.320720.470301@mariner.uk.xensource.com> Date: Tue, 18 Oct 2016 16:50:31 +0100 To: Konrad Rzeszutek Wilk In-Reply-To: <1476802588-28894-3-git-send-email-konrad.wilk@oracle.com> References: <1476802588-28894-1-git-send-email-konrad.wilk@oracle.com> <1476802588-28894-3-git-send-email-konrad.wilk@oracle.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) X-DLP: MIA2 Cc: xen-devel@lists.xenproject.org, Marcos.Matsunaga@oracle.com, Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Konrad Rzeszutek Wilk writes ("[PATCH 2/2] s/HttpProxy/DebianMirrorProxy/"): > From: Konrad Rzeszutek Wilk ... > When constructing Debian related items we should be using the > DebianMirrorProxy instead of all catch HttpProxy. I don't think this is right, because apt-cachers and the like are only required to support apt's uses, and not wgets of bits of installer. But: > Or alternatively support the case where are no HttProxy at all. This is right. So I think the patch below is better. Ian. From 85741f132e62e0cdaef66860d417fa80e9df7a13 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 18 Oct 2016 16:46:20 +0100 Subject: [OSSTEST PATCH] mgi-common: Support empty (unset) HttpProxy properly mg_update_proxy ends up being set to the empty string so the {...:+-x} form is needed to expand only non-empty values to `-x'. Signed-off-by: Ian Jackson Reported-by: Konrad Rzeszutek Wilk CC: Marcos Matsunaga --- mgi-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mgi-common b/mgi-common index 8a2c2d9..5081521 100644 --- a/mgi-common +++ b/mgi-common @@ -30,7 +30,7 @@ fetch () { cd $mg_update_org_pwd && getconfig HttpProxy )} curl -s -H 'Pragma: no-cache' \ - ${mg_update_proxy+-x} ${mg_update_proxy} \ + ${mg_update_proxy:+-x} ${mg_update_proxy} \ $1 }