diff mbox

elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

Message ID 22619.55667.902166.438761@mariner.uk.xensource.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson Dec. 22, 2016, 1:47 p.m. UTC
Jan Beulich writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)"):
> On 22.12.16 at 13:19, <ian.jackson@eu.citrix.com> wrote:
> > Perhaps it would be worth telling Xen not to reboot on crash...
> 
> I think that's worth giving a try (I assume that some timeout will cause
> the machine to get rebooted at some point anyway, to make it available
> again).

Like this, then, AFAICT from the docs.  FAOD, this shouldn't affect
deliberate attempts by the dom0 to reboot the host ?  I found the docs
not quite clear on this point.

Ian.

From acdf52770bbec07680bf4e61ad3984a1d0156af3 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Thu, 22 Dec 2016 13:43:01 +0000
Subject: [OSSTEST PATCH] ts-xen-install: Pass `noreboot' to Xen

This prevents Xen from rebooting the host, if Xen crashes.

This reboot serves no function in osstest, since a crashed host will
be automatically power cycled to recover it.  (Firstly, during log
collection, a renewed attempt to boot from the hard disk; then, during
the next test, netboot to wipe the machine to reinstall it.)

But the reboot does make logs more confusing, and we suspect that the
reboot loops which can occur (eg if the version of Xen and Linux being
tested always crashes on boot) might be implicated in our test boxes
occasionally forgetting their boot order.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-xen-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Dec. 22, 2016, 2:51 p.m. UTC | #1
>>> On 22.12.16 at 14:47, <ian.jackson@eu.citrix.com> wrote:
> Jan Beulich writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 
> 103788: regressions - trouble: broken/fail/pass)"):
>> On 22.12.16 at 13:19, <ian.jackson@eu.citrix.com> wrote:
>> > Perhaps it would be worth telling Xen not to reboot on crash...
>> 
>> I think that's worth giving a try (I assume that some timeout will cause
>> the machine to get rebooted at some point anyway, to make it available
>> again).
> 
> Like this, then, AFAICT from the docs.

Yes.

>  FAOD, this shouldn't affect
> deliberate attempts by the dom0 to reboot the host ?

Correct. (I use "noreboot" or its more modern "reboot=no"
equivalent everywhere, and can confirm deliberate reboots
work fine.)

Jan
diff mbox

Patch

diff --git a/ts-xen-install b/ts-xen-install
index 2a1784d..c921e69 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -142,7 +142,7 @@  sub adjustconfig () {
 }
 
 sub setupboot () {
-    my $xenhopt= "conswitch=x watchdog";
+    my $xenhopt= "conswitch=x watchdog noreboot";
 
     my $cons= get_host_property($ho, 'XenSerialConsole', 'com1');