| Message ID | 22822.64556.372107.915333@mariner.uk.xensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 25/05/17 16:45, Ian Jackson wrote: > Thanks to everyone for testing and review and acks. I have just > pushed those two commits to staging. > > Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"): >> Maybe it would be good to add a note like: >> >> "All the Makefiles invoked with -C from the toplevel should have the >> following targets: all, build, install, clean, distclean" > > Yes, indeed. How about the extra patch below ? > There are some special cases, so I think `generally' is right. > > I'll wait a bit for opinions, but given that this is a comment-only > patch I guess Julien's exception for docs applies, so I will probably > commit it tomorrow unless someone objects. That's right. However, I'd like to try branching tomorrow so we need staging != master. Could you hold the patch until we branch? (I will send an e-mail for a commit moratorium). Cheers,
On Thu, May 25, 2017 at 04:45:48PM +0100, Ian Jackson wrote: > Thanks to everyone for testing and review and acks. I have just > pushed those two commits to staging. > > Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"): > > Maybe it would be good to add a note like: > > > > "All the Makefiles invoked with -C from the toplevel should have the > > following targets: all, build, install, clean, distclean" > > Yes, indeed. How about the extra patch below ? > There are some special cases, so I think `generally' is right. > > I'll wait a bit for opinions, but given that this is a comment-only > patch I guess Julien's exception for docs applies, so I will probably > commit it tomorrow unless someone objects. > > Ian. > > From 352f4a1f9797d1eee94121565fb4e3d8fc698371 Mon Sep 17 00:00:00 2001 > From: Ian Jackson <ian.jackson@eu.citrix.com> > Date: Thu, 25 May 2017 16:42:12 +0100 > Subject: [PATCH] Makefile: Mention usual targets of subdir Makefiles > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > Suggested-by: Roger Pau Monné <roger.pau@citrix.com> > Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
diff --git a/Makefile b/Makefile index 51905eb..2ff33df 100644 --- a/Makefile +++ b/Makefile @@ -90,6 +90,11 @@ test: # # Also, we have a number of targets COMPONENT which run # dist-COMPONENT, for convenience. +# +# The Makefiles invoked with -C from the toplevel should +# generally have the following targets: +# all build install clean distclean + .PHONY: dist dist: DESTDIR=$(DISTDIR)/install
Thanks to everyone for testing and review and acks. I have just pushed those two commits to staging. Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies"): > Maybe it would be good to add a note like: > > "All the Makefiles invoked with -C from the toplevel should have the > following targets: all, build, install, clean, distclean" Yes, indeed. How about the extra patch below ? There are some special cases, so I think `generally' is right. I'll wait a bit for opinions, but given that this is a comment-only patch I guess Julien's exception for docs applies, so I will probably commit it tomorrow unless someone objects. Ian. From 352f4a1f9797d1eee94121565fb4e3d8fc698371 Mon Sep 17 00:00:00 2001 From: Ian Jackson <ian.jackson@eu.citrix.com> Date: Thu, 25 May 2017 16:42:12 +0100 Subject: [PATCH] Makefile: Mention usual targets of subdir Makefiles MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Suggested-by: Roger Pau Monné <roger.pau@citrix.com> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> CC: Wei Liu <wei.liu2@citrix.com> CC: M A Young <m.a.young@durham.ac.uk> CC: Andrew Cooper <andrew.cooper3@citrix.com> --- Makefile | 5 +++++ 1 file changed, 5 insertions(+)