From patchwork Tue Feb 16 15:03:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8327801 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A78639F38B for ; Tue, 16 Feb 2016 15:06:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D12662024D for ; Tue, 16 Feb 2016 15:06:13 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 009982009C for ; Tue, 16 Feb 2016 15:06:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVhA7-00048B-1x; Tue, 16 Feb 2016 15:03:35 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVhA5-000486-UQ for xen-devel@lists.xensource.com; Tue, 16 Feb 2016 15:03:34 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id 21/C4-25857-54A33C65; Tue, 16 Feb 2016 15:03:33 +0000 X-Env-Sender: arnd@arndb.de X-Msg-Ref: server-5.tower-206.messagelabs.com!1455635012!22735072!1 X-Originating-IP: [212.227.126.134] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 51707 invoked from network); 16 Feb 2016 15:03:32 -0000 Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.126.134) by server-5.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 16 Feb 2016 15:03:32 -0000 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0Ljz90-1ZyH5A03hK-00c6ss; Tue, 16 Feb 2016 16:03:26 +0100 From: Arnd Bergmann To: Stefano Stabellini Date: Tue, 16 Feb 2016 16:03:23 +0100 Message-ID: <2479546.WgivMO2bp2@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> <56C20552.8030305@citrix.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:E30qajVjZyvqDOOBpnAQkxAH59MbrF4h6MJuOT/otIplsdtZx0V L9gFheoofabYXuXK/qB10V6KNO7fUd7vHB6kVdDctD4+w3rsbxx1mwmvDoDOGE4zCPCs2NI devwL4O5SwcJhNgiJnopZ3w0sGwoZIzTfBXX1j043xFWe3ss6EcqBcvR5x1wHeNgZWy8V2h uSxHbbkdK3IaTmFrWWf2g== X-UI-Out-Filterresults: notjunk:1; V01:K0:tUZabnXYjnI=:qhexGhIEdzh0vW7XL/uO1F YHp1Uk0L9zw27pFKk5/B/W6TU8U05ohbMQHfz58sumQd3X3oAKGdxYR1c9N691xOGkXI86R79 Fl3YablsiZOMw4zhNSRRJIhaMpX3a26q90+5ENX+rsjr5kmxuQNz1jv8SPfdRvIVxHOplwOrR WxToIbCpf++C3eRP+b0nYjbilYkvlFaXrv/qH9iCdrtMFJxazILc73879I+Ua7d5sF2gwVRVg L8U3f15SNeKY/Kxe7BR3PagDh3pVqEKN2UiqjGQWSON0nGYYlKw2WAnes/w1D2FzUzmNbUO5S EaLkPsKj/aTxxuV7eLEm9fcSegu1U8tKFEe88aIWU0JLLuqY6ropTyGDtPbiSuSzfZ7Pdplos 4ZwKIV7u7cddrTVrzljow0CEK7bM1b8V7Gn9tW7UmZl4+jXCE9ASbjo9ikZRcy2c0Ma4nni2N 9pvXMhw3tb4CfjG5aGHWG8fBi5I/HVhKq0Id97Y8eNa/AtPCjcfGranBntMsCmqmXGACw3vHG /AcEAmrOyc7JG72sOkEbnnEn+VHz4ceD+uc3nB7Zxs8It9fXwIbjw9O8X+mWROBqOHv38krKy 4viCKZ8pOUDOPjHDJw8q0q8jbo2Zpbxchnt1hI7ekEE0gpNz4mziJf3h5aaGsBVjYphQ4deOk wlokv4dMdLS06M4XUZzCMq0m9+lr1qqmXvPKB/7SdHu1iAfHMopVXq8+NsoFmmSLXgvuTtyxI bMckW2jro2gygCjI Cc: Andrew Jones , xen-devel@lists.xensource.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Subject: [Xen-devel] [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND" X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Xen framebuffer driver selects the xen keyboard driver, so the latter will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT is a loadable module, this configuration cannot work. On mainline kernels, the symbol will be enabled but not used, while in combination with a patch I have to detect such useless configurations, we get the expected link failure: drivers/input/built-in.o: In function `xenkbd_remove': xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device' xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device' This removes the extra "select", as it just causes more trouble than it helps. In theory, some defconfig file might break if it has XEN_FBDEV_FRONTEND in it but not INPUT_XEN_KBDDEV_FRONTEND. The Kconfig fragment we ship in the kernel (kernel/configs/xen.config) however already enables both, and anyone using an old .config file would keep having both enabled. Signed-off-by: Arnd Bergmann Suggested-by: David Vrabel Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND") Acked-by: Stefano Stabellini diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 8ea45a5cd806..d889ef2048df 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2246,7 +2246,6 @@ config XEN_FBDEV_FRONTEND select FB_SYS_IMAGEBLIT select FB_SYS_FOPS select FB_DEFERRED_IO - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC select XEN_XENBUS_FRONTEND default y help