| Message ID | 25a6b7e7-3bbe-4121-8f29-cce6f0a99206@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | x86/mm: undo type change of partial_flags | expand |
On Thu, Sep 12, 2024 at 4:38 PM Jan Beulich <jbeulich@suse.com> wrote: > > Clang dislikes the boolean type combined with the field being set using > PTF_partial_set. > > Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16") > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- a/xen/arch/x86/include/asm/mm.h > +++ b/xen/arch/x86/include/asm/mm.h > @@ -286,7 +286,7 @@ struct page_info > struct { > u16 nr_validated_ptes:PAGETABLE_ORDER + 1; > u16 :16 - PAGETABLE_ORDER - 1 - 1; > - bool partial_flags:1; > + uint16_t partial_flags:1; > int16_t linear_pt_count; > }; > > I knew MS compiler does not like too, but I only tested with GCC, and it was fine with it Reviewed-by: Frediano Ziglio <frediano.ziglio@cloud.com> Frediano
On 12/09/2024 4:38 pm, Jan Beulich wrote: > Clang dislikes the boolean type combined with the field being set using > PTF_partial_set. > > Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
On Thu, Sep 12, 2024 at 05:38:17PM +0200, Jan Beulich wrote: > Clang dislikes the boolean type combined with the field being set using > PTF_partial_set. > > Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
--- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -286,7 +286,7 @@ struct page_info struct { u16 nr_validated_ptes:PAGETABLE_ORDER + 1; u16 :16 - PAGETABLE_ORDER - 1 - 1; - bool partial_flags:1; + uint16_t partial_flags:1; int16_t linear_pt_count; };
Clang dislikes the boolean type combined with the field being set using PTF_partial_set. Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16") Signed-off-by: Jan Beulich <jbeulich@suse.com>