From patchwork Tue May 2 07:17:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13228551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C09BC77B73 for ; Tue, 2 May 2023 07:18:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.528362.821395 (Exim 4.92) (envelope-from ) id 1ptkHI-0000LK-4t; Tue, 02 May 2023 07:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 528362.821395; Tue, 02 May 2023 07:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkHI-0000LD-2G; Tue, 02 May 2023 07:18:24 +0000 Received: by outflank-mailman (input) for mailman id 528362; Tue, 02 May 2023 07:18:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ptkHG-0000L7-Kt for xen-devel@lists.xenproject.org; Tue, 02 May 2023 07:18:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83772843-e8b9-11ed-8611-37d641c3527e; Tue, 02 May 2023 09:18:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GVXPR04MB10072.eurprd04.prod.outlook.com (2603:10a6:150:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 07:17:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.030; Tue, 2 May 2023 07:17:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83772843-e8b9-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YoFzm8fmaDDVP9+IUvOGemPkdB0WBIVdceOi1jg63jmurBJRS04BupVc9AnPlF0k7IOrdk9j3JdpkBJbWj5C1uHAll/U9oM1XeQZRffloDcTgi4G5xjwMS52rVTsh4sXjUuRG0QwPY8RyryfzEh3SpEE04661mrXliVtiJeVjLmQtlDb+DuHPDQ54L5D0EumU7hR8/y9Nzcse/7BoOudtCIofcZFkQ3MCWHMKAuy4fdGqA0TwymtsLSZGXm5ZvhlaoeQrLlfIcvshhMXNkFQCoheZCJfkZVTrHTM46TNhAPTh0aCC6VSExLEpeIrjqfSzvyWWhx9PrsgLdXRVtVhLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJOXKJhqj0dCvMwJodrI7VMwHJWDODfDJZHptDaJKnA=; b=cQwgf+HFCB71gNmwOwTc32kr0vD6apx8wsnQTFmfgPtLakoBpY2J0FP4Ip/tYNUogGDADU13g+Z444CsvAKMzvkpewNFKcFicZmZL0ls0SzptRX5ZGWq+SPOUW5IfQ0GkhjG4TXsWRKcB4d2bgp7XU6QqeYvRlfWPITreZUa7jRpY5CnCN0DR7vUvhlFK7upre5Kt+GHD0uicR1/RjcOlbYpC9CHDCPzpJHaOlz6Jm66aiF9VGr8e/yNwboHwVXMI8MbVjZ9fEzWaK6IrjyO6hgD6QEmYp62v/LXfePtd5MHQHoMX+j/fY4JDCm589ADJWKe8OHEr3jRRh5dpRoL2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJOXKJhqj0dCvMwJodrI7VMwHJWDODfDJZHptDaJKnA=; b=TW+ANcAzg1QYKZs6gvuJXde2Srh2KXjRR9MPzOGydwGa7xnTfwBkFh1ADlUqI5rX7Cwv0cwvxpGmLodyLCiOHjtZkX0Rsasop8LBoVS9dmE6yzyYx0zuNs3vk1/NLz5rbtEplqbN9Iap2TEUY+5pgQaORnsWDDnwMemibyD+57Y/En/m4v7U3W8S0ikKe7IXGmf2GlnES3nSJVmCO4fDU/5n/0rvlCrGn8ZBXDDvQyvsxbFRVerteekE68uwmgCMZN1j2xhXgbnTI62wtY8tlaf5IZCv/CVz2OodLHGEBR8/1RXXvHieVojeA207U3MDTWm38Qay6g55Wu/WW85FvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <26064a5a-423d-ded5-745e-61abb0fa601c@suse.com> Date: Tue, 2 May 2023 09:17:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] sysctl: XSM hook should not cause XEN_SYSCTL_getdomaininfolist to (appear to) fail X-ClientProxiedBy: FR2P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GVXPR04MB10072:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d484f16-dd8e-4ca2-bcba-08db4add5695 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gs8EetnGNi98b48zVs7nSu+d8jNxf6h2QCcIQP9R1XuLAEXeOdiKW2OlfU6wEooRH4BtM9nFAPd1+Cao56kilEg3dAz4r1llEvmGPks1To55o2672TUVjvrFoCZbIuujkunYdENBxNC4XSB+WFdnERbWW0UPKe5xfFWUpP6wsUFy4efM+NU3pTw+dSRk9z3tkkX3G998+8EIM9JdByc42jarY9OTTFVbkDxgONSyAkZglnRte1BduYF67y1JCrcZDzrVaMOyzxenSOareoz4z1cgzXMn0xf98rUv1yogGEN0F6KZGaAJf7GEevnAFcP4IP19EzNcYGINhrULsk4xG5CY1C8m8Ccgyv6lgfdSpP8AABEorOAAqtxIWij9VS39Pjw/7gy9zidzevFEdGZCHw+2KT9Dop6hrh2+qkSiphQhzXRWVB4/o4xSyx0Cwqm6iz+oiGEaGtXufuhukh1vEZL92Lh4aCsPDfRtHob+DZ2WUxPtJ4StbnkPtuO/Fjg3SR1GSfYQZwtEwJwfq/GUGUCD31rTSgoM+5tTVAJPsT64u3r/ni8oU1ldh1Lw6uPd3lhQi2EnbjgQWQm4g/Ny2W/mY5SPg3GAEa9YdXL9HiUPXL7bMB2CLwZtsS2TKheQ90IzzkCRwSD8dZXZ9O4IHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199021)(31686004)(86362001)(4326008)(6916009)(66476007)(66556008)(66946007)(6506007)(6512007)(41300700001)(36756003)(8676002)(8936002)(5660300002)(6486002)(316002)(2906002)(31696002)(54906003)(478600001)(38100700002)(26005)(186003)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pkoravdz3R4m+pVFBUcQhIzA76BI?= =?utf-8?q?bQssLg96vXPkt/4tEchLtyz/V0UgoYdtK2dsCq2y7sz2vfq+ZE5VpLmUoPwfOcGtR?= =?utf-8?q?XwCCk1765uI0OCffQ1uozfUrE+8iGQYLs6VxT/1bm51NzgA/fACIU+M7HrwU3DEF8?= =?utf-8?q?3XoPAPQQcMOymXzdAhLAmMyVARWidQ+wlcBzpQqsGjnpHNSXo+3NEQKDFOGhx0f2f?= =?utf-8?q?Tt4DYIe62ahZ4cuT4vEOW+bk4QOm7aBZGSH+mCptTdZ1/JLpwCKM3RE0vXJjFCuIF?= =?utf-8?q?5XLXpLO4NFMkIHoKXtKqAyljuwLVZMVwT5mepP9e5YAB5fFxhAoo+N3/CephHVuvl?= =?utf-8?q?PvxkV7TTomQSRT4/aRoBOt2JT9OCnZp51tbzkUNotROtoDqhGUdC9A7Xg5VwF0zxk?= =?utf-8?q?wuTNeufFWTBM+klkkj/XbVJEIsMa0xlWNjCrfCzjjHSVznn7O4yiMD5GFsBVQoijs?= =?utf-8?q?UuarCeTk2hN+AYzUt9KECyYlZ/kOSacd45Z+UKWvvEj0Q/fZqt6PvcmwR7k4Znnn9?= =?utf-8?q?I3CdWlXSlb5bix6A17qM86YlrkgIDd32easozhjw4mp2KcLDFGeO8e+74DJTShZHn?= =?utf-8?q?FT8vlipG99KhH+34EDZHcYpD8U5N3PS1Yw0gO88IQaqhjmSoQYvOIE8hfU14FvWLg?= =?utf-8?q?MPCu43XG3l0ppZW0unRMGbMWD2BzxfR62KJDi104H+y0YMacFeiKhq58uES9AhwBg?= =?utf-8?q?3HOJKYuzebM9nU5H5yl+55aiEqxSNIeAzMOpCwjyV5tRi6kCmEnhzYgWy55rpOrJ3?= =?utf-8?q?b7AxJfEiaMW8tcHohEaDfsgoC8dN5w6D7TaDfcjU1eXGbbuP5kbUREHO1ccMxUq9x?= =?utf-8?q?dMztGLdcSG7cQZgzd8L4p2xl5xv8usxBXGHmXD3+MIZL7wgLgEhIuvpRCuFwd7B0e?= =?utf-8?q?dzlDiiMw45yBQjYJuvDLQkjRHb1uJZFr4ZiZjUSA71FqiAnIihd9XVSBTRH/vzLGe?= =?utf-8?q?rVql8l9GnGbU2sHRKApUHiAsEdbHfeqrcaAHTjyyLZuL1Sjay+5tdAImcSq7LfEca?= =?utf-8?q?bKV1CJsbX2L9z7c7mbujB4c5fzQmT8ya8+19mEAdaBwM5ZFOGdMi1r7k2nE/BMXRf?= =?utf-8?q?UYQ136P7kIsoZHX0Vg05cBiXp/P1hd0hxO8vwKeINN3yEsl0Qb7Yb/YtJVZwgBrQJ?= =?utf-8?q?Kp7sV1i0Wy0pUe9JQ5JclBChr0I3v37Z+ABlxRFxQTmxzXFVs+40o8ZCUxhidPyIB?= =?utf-8?q?l0gDGUkAx64w4hUAGZhI2+Cyv80PcVW1isZHJDNmQ9sylTD8LYUXGMy9gmK6Wg/XL?= =?utf-8?q?vfIA83+VGXUL0Q6+8D2xa2iUh178w7aT8kZMOrlh5mutyeLEML8hizN3N/MCyXhyw?= =?utf-8?q?x1FeB3vEQkjq5HXFvctXiAce3gVIOw0u+te1F2md3wWjnWbNctlh4XLzixUBF39SJ?= =?utf-8?q?3NNiwFjoHUxkpvm3qlReaDouSw+Q6BaNQTu6RlxCGRGQh1ODp/HgpnVRCNKVZfda9?= =?utf-8?q?R8VWqOwknGlagJ9FxmQO79W8hRrKQdR9azV+NOHA/V852m2xYpPh9GgplJLyUkuB5?= =?utf-8?q?NtN4Ozeny0zz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d484f16-dd8e-4ca2-bcba-08db4add5695 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:17:50.5780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xawX4/7HxFajo9aw1K0PWV8Bey8UTunv4MBbFItVn+IBfu3Dr6PMuJz9uXjRh0DB+HboQ/qxXDU6zZi8nYG3wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10072 Unlike for XEN_DOMCTL_getdomaininfo, where the XSM check is intended to cause the operation to fail, in the loop here it ought to merely determine whether information for the domain at hand may be reported back. Therefore if on the last iteration the hook results in denial, this should not affect the sub-op's return value. Fixes: d046f361dc93 ("Xen Security Modules: XSM") Signed-off-by: Jan Beulich --- The hook being able to deny access to data for certain domains means that no caller can assume to have a system-wide picture when holding the results. Wouldn't it make sense to permit the function to merely "count" domains? While racy in general (including in its present, "normal" mode of operation), within a tool stack this could be used as long as creation of new domains is suppressed between obtaining the count and then using it. In XEN_DOMCTL_getpageframeinfo2 said commit had introduced a 2nd such issue, but luckily that sub-op and xsm_getpageframeinfo() are long gone. --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -89,8 +89,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xe if ( num_domains == op->u.getdomaininfolist.max_domains ) break; - ret = xsm_getdomaininfo(XSM_HOOK, d); - if ( ret ) + if ( xsm_getdomaininfo(XSM_HOOK, d) ) continue; getdomaininfo(d, &info);