From patchwork Tue Aug 8 11:08:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13345966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4218BC04A94 for ; Tue, 8 Aug 2023 11:08:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.579642.907736 (Exim 4.92) (envelope-from ) id 1qTKZx-0006ZH-R0; Tue, 08 Aug 2023 11:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579642.907736; Tue, 08 Aug 2023 11:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZx-0006YR-Iz; Tue, 08 Aug 2023 11:08:45 +0000 Received: by outflank-mailman (input) for mailman id 579642; Tue, 08 Aug 2023 11:08:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZw-0005mu-09 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eed0fce2-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:08:41 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C23304EE0741; Tue, 8 Aug 2023 13:08:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eed0fce2-35db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH v2 2/5] xen/delay: address MISRA C:2012 Rule 5.3. Date: Tue, 8 Aug 2023 13:08:04 +0200 Message-Id: <27631ba28fc6f47095fe0db3f8ee2cd87de616ed.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The variable 'msec' declared in the macro shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes with other functions the macro is converted to a static inline function. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- Changes in v2: - Switched to a static inline function, as suggested by Julien --- xen/include/xen/delay.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..6ecee851f6 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -4,7 +4,12 @@ /* Copyright (C) 1993 Linus Torvalds */ #include -#define mdelay(n) (\ - {unsigned long msec=(n); while (msec--) udelay(1000);}) + +static inline void mdelay(unsigned long n) +{ + unsigned long msec=n; + while ( msec-- ) + udelay(1000); +} #endif /* defined(_LINUX_DELAY_H) */