| Message ID | 2a339346-ed09-22b6-88fb-6f9d997b10b4@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/shadow: make sh_remove_write_access() helper HVM only | expand |
On 21/04/2020 13:05, Jan Beulich wrote: > Despite the inline attribute at least some clang versions warn about > trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper > in the #ifdef region. > > Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM only") > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
At 14:05 +0200 on 21 Apr (1587477956), Jan Beulich wrote: > Despite the inline attribute at least some clang versions warn about > trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper > in the #ifdef region. > > Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM only") > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Tim Deegan <tim@xen.org>
--- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1756,6 +1756,7 @@ void sh_destroy_shadow(struct domain *d, } } +#ifdef CONFIG_HVM static inline void trace_shadow_wrmap_bf(mfn_t gmfn) { if ( tb_init_done ) @@ -1767,7 +1768,6 @@ static inline void trace_shadow_wrmap_bf } } -#ifdef CONFIG_HVM /**************************************************************************/ /* Remove all writeable mappings of a guest frame from the shadow tables * Returns non-zero if we need to flush TLBs.
Despite the inline attribute at least some clang versions warn about trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper in the #ifdef region. Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM only") Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Jan Beulich <jbeulich@suse.com>