From patchwork Thu Jan 27 14:49:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12726881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3CCDC433EF for ; Thu, 27 Jan 2022 14:49:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.261508.452884 (Exim 4.92) (envelope-from ) id 1nD65G-0005LQ-Qx; Thu, 27 Jan 2022 14:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 261508.452884; Thu, 27 Jan 2022 14:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nD65G-0005LJ-Ng; Thu, 27 Jan 2022 14:49:10 +0000 Received: by outflank-mailman (input) for mailman id 261508; Thu, 27 Jan 2022 14:49:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nD65F-0005K3-LD for xen-devel@lists.xenproject.org; Thu, 27 Jan 2022 14:49:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 482ca612-7f80-11ec-8eb8-a37418f5ba1a; Thu, 27 Jan 2022 15:49:08 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2055.outbound.protection.outlook.com [104.47.0.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-2arEmq7zMCWOxUNe2YOImQ-1; Thu, 27 Jan 2022 15:49:07 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB4887.eurprd04.prod.outlook.com (2603:10a6:20b:b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Thu, 27 Jan 2022 14:49:05 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::a1a4:21a6:8390:b5d5]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::a1a4:21a6:8390:b5d5%5]) with mapi id 15.20.4930.017; Thu, 27 Jan 2022 14:49:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 482ca612-7f80-11ec-8eb8-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1643294948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fOd3RfnzHL4D+dtvfMnfEOwQW5XKehauO+k69wnLAEw=; b=M6EPiyXuqL3d81Ravjv1+E2WXIpNebaYSXl/Lb7gThsL5qEaMWJkParyE1ybzpaVTkVLyI nR6waOqAFaJ7H9lXhGQlpNlPQ4uZZmBJkTnbm4P12w6Cd0J/Ok2CWkwrkIeijr445vaTWQ DeotFTFB/czkA4jVYEa5bv8qOzGsB6Y= X-MC-Unique: 2arEmq7zMCWOxUNe2YOImQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YJ6PJYJgJkkACtdWpL/oCqimLZ/bYDJAGUwoyUG4mytY342cxzy7DMZGbJZyIfyxI4pdesJXZ8Y2mlucbJjOE/VFn8aQTy9QIaMHDVqk0caUuUC7M6wbwhX/Vp1t1jnMs6q3zHJOU/36fgi4dv0irH1Qe4FhQLZA9bb23CRc8soDGRfp1JA6ayEVNCTmTcMNoUfzxIqzO1z5ZxMY3/ACa7aPDF28YnUvOIVoIS9qN0hKNCxAnqzA5OTzM97CvhH1Tlal8im9KywniGWZTaavDyppTXaILR/jxBNZHwBuRs/ejnEPdVJnDRCYASS/tPmZWGG7YBVU74NPkpE1nlRB8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fOd3RfnzHL4D+dtvfMnfEOwQW5XKehauO+k69wnLAEw=; b=kA8RgK2JTtCtBJvER5pC7crfGfyEwyRKja1zx2l82TvgK/L8Gpnc8eCGD//DxoBbHPeUHJnJYU5Qo+sbIWR7Qfc9LhjVqP7rbXKYpIplQhJbA0McqDyVfsqxg07BCDdewZP/Hk9xM1gQAI/YUO5glnG7dFe39tslGyyk+6fdjaO8yPoEBJeJsp/yn0odgGtj/cNIe7oaLvRf43c2JpRaaCYLvJeoVnT3xkXsZ8gv4NpbgIkMAkdQdrxtenM8ZQAKTBCRYbq3DJntmJZQ6az0i3OjPXTCbXohiHtb7tI1Stb2Ri9Vd0x9A0QEOUKNuygz7z9JWqVZ14mVgA9SN6+12g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2a39cb48-7d38-6d7e-0557-fd93d377a31b@suse.com> Date: Thu, 27 Jan 2022 15:49:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: [PATCH v2 3/4] VT-d: replace flush_all_cache() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant , Andrew Cooper , Kevin Tian References: <4b7db7ae-eb84-7ecc-4334-fe5f0f7ef46b@suse.com> In-Reply-To: <4b7db7ae-eb84-7ecc-4334-fe5f0f7ef46b@suse.com> X-ClientProxiedBy: AS8PR05CA0025.eurprd05.prod.outlook.com (2603:10a6:20b:311::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9a8ddff-2c5c-4221-b4dc-08d9e1a42ab3 X-MS-TrafficTypeDiagnostic: AM6PR04MB4887:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1468; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jWaf/7f4fo1ZwZ1+QAYkdaQbjMwwrhCCnU1y9mn1Vm9jvCW2kdp24RYW6y94ib2mYNfBGWdP4fw9jTw06Vz80M5fHoX0nolNakG6Sh2OM6StizWw1W+ynsPBxN3+/HFpgnH+ILabUciUErONuHisfTAC4rqNuEvpAwjtbYB3F8L6owEL63mpUiu+KXLUUEyP2TUBzg4EPpXwKqM3/kvvhOIz4lEJGIIFHfFE4NS4eXNpix2MnCObhD2fccmIoteBzP2I72dHzMe6ByosWIcEG7csfK6iWLcbyQfIqcHIK6OSnnb1tMgTAi1JM76wjGyhoeoATcG8YdrpiL+/DlawXGEdDow+LP91q2tq2QD1qFExaFdhK5Z1SH4Y/gVtSeEftfzKTBr6lZxABbqobqgI9R5+Uvsj0/wX5BTBDqCMHx1OaI81xySrYTZpzXh6wyqJIkUH6IbcnMPONZPToTn252T46k3LT0bClZeUxtWaM0WHQR0To7CrwcbJEu4YmbeJ3Bp5BJ1MvsSqhY42O7HwbZIFKQSip+8IbHmvwKqvb2VG6k7LmG1sxK+WobR7NESHS9RQFAVIroeOGqOIxNtKvynGcFPujVDvV+YSmVe1WONFu41NE8Darh3sAwKzK4FnuRCDwNnyp1AzxHH50OLVglV6MjmXS1YRbP5bOCcg8kgi202sC+9iSoA+QDg2gbdiaG1b/rHnB2sBC+6Ba+brc2Au+PCSgWLVWLmBvIjNxOJj+bjUt6ejJeOrUk7qcjzE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6512007)(6506007)(186003)(26005)(31686004)(31696002)(6486002)(2616005)(54906003)(6916009)(316002)(86362001)(508600001)(2906002)(4326008)(8676002)(8936002)(5660300002)(66556008)(66476007)(38100700002)(66946007)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PaT03xFamqhVE4AXLBiIdtulfgyh?= =?utf-8?q?97WPTm4ubO0jwWrWx/PRlPxL+p3/++ZzL7CbtiyfvCTyYovNiPrqRK/hwhnlh1nFF?= =?utf-8?q?UWtljf/+zkGZ8fT9Gn1AmomW+r0tH6qg6Wx2EOWZw3qhL9bJp246RxMAMou4zvEEE?= =?utf-8?q?//NhQFVoAB2ovq5S1lHQG64FJCgb1WrNUKQMDnl2YFXoQT7r3dgZRiMTzY6qOH9Sy?= =?utf-8?q?hcmuy6fqFxSOlg9GSjHoeak6lLKm+tPqS1Cx3hY9aQmmMawaPPuD0vl73EqNEIDRB?= =?utf-8?q?lUxO12q0wSFkU9QZZYOIgCRYsflD1CwZJ4DD/cHVwlV1QtKiN5/U/UZcpFvJWjBZH?= =?utf-8?q?86VIZ9oowTA9Ogg3m0RGppIe03GpLgFzSnDBWoEZcq/fguKoOLe+uGTUmtBjgLy9O?= =?utf-8?q?tdnCUvxLyzwqJDnWGTvFzgmatuf5cJ+QA2g4XO5rEv755h7hJvxjKpEo/EZxbamCD?= =?utf-8?q?MUtsBPi62h7jGQbVXyHTnrgKtQN/svhZd0pJJxEU+ngLHfmDBGOfj6EJRymdI3cAG?= =?utf-8?q?Rds+bJrQoKM4kUYj798DP1Rz2/xS6nBLzGd/U4efNTwVm0nA8lQaz17VHhb2txSt3?= =?utf-8?q?Et/LU+dzVTeFGUUJ73jnq/Ww30SdC5izUYdhMHu2SdUZxHcYwymptr7F9o1xTe4dZ?= =?utf-8?q?1JhtHWW0MYwQmXoqp+rcefLu4Kp2fLA5jVO2gJq2dXc8kWzeZNRrEtVtbsUIYzXwH?= =?utf-8?q?j/as7BymYPYOfOmrZ+c+uxPm7nqFvVWiJ/CJAgCDQJQFIvLbc1I7Kp4hYFZXAeuj0?= =?utf-8?q?bC546BlX5OpytvNFP14FZ3lMc0KAUxR+P/ECv21gLr/h49tMX74TEs1/8xUXoajYn?= =?utf-8?q?pKIi6Q8N1753UWuAmvGDyeBmueaECjfcwj6DDkJCL4qKeQAdKaOjM+jdp5xgVvEL5?= =?utf-8?q?I0GHfoQY0LXw2P6Br0NbjYcju8tZHzSIhW2HxFUEmuxLr7WXgAnr3GxkUlz+4pjfl?= =?utf-8?q?NQJkG3NLg8z2vgbrMVbECfU4pJ+Jf5xYtSxzo7KqlEinTHyNOy7/KMitur7fmBQZu?= =?utf-8?q?xT3Qvqa6IcXaZkYONsffnJ3adX2St2+56zVQy7cDk8rtwdOsfcqRIfA/GYIHr6v86?= =?utf-8?q?D6vGwqdZxppEq7sY4AWVLIgPd5HC9QAJ8mD5WR1QnFLstfuUlyLVm/ujwZzlZbfxO?= =?utf-8?q?cfx3TEiCk/xF5uxgxcjqZPtyFi848uygKuDym0bto1CNAjFz0hUdwE6PCtCvW+gQ9?= =?utf-8?q?qZWVl8t+TH0uiunZwFVY2saiDrgkTLhYVDnR0vswa28ji6rj4VUmPxhhxi3tMd5ob?= =?utf-8?q?9Qf82pUXILX+sUo+64Y53VbOh9FGwLlk6+8Y41bK91eAD5i2SSmDzHvrDakRn6Do4?= =?utf-8?q?nLF9omVW7Bocm75Irmhaag2wyQcvO8MJQ5E0fiuL6AGtht++dbq3+fKwM1dgIBYxD?= =?utf-8?q?7RySdPqyfsTVV/2Pt+gmtzlWQHGTCjIoT16eZ3KwplloIQ7qgoG66JS0GqwbAhm2I?= =?utf-8?q?B8turweXYNJQUUiD3YyZvEseAfRNXoGkZAmkHXcbzii+dHvHVSO33pPuNN+JufayG?= =?utf-8?q?no2oaZ94KKcA9XQKpxKiXgQsUNK4fc9oYCF30gS6GVa7P1gsdTcbCWM=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9a8ddff-2c5c-4221-b4dc-08d9e1a42ab3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 14:49:05.8348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wJ49VW/FBLu+GdS0nXSlr0OZW+WqQLMQGM56ly6z5Dx2znq8875HDUwQe7O4sgj9h1r8pFJh9rhhO3QqPvSe4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4887 Let's use infrastructure we have available instead of an open-coded wbinvd() invocation. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant Reviewed-by: Kevin Tian --- a/xen/drivers/passthrough/vtd/extern.h +++ b/xen/drivers/passthrough/vtd/extern.h @@ -78,8 +78,6 @@ int __must_check qinval_device_iotlb_syn struct pci_dev *pdev, u16 did, u16 size, u64 addr); -void flush_all_cache(void); - uint64_t alloc_pgtable_maddr(unsigned long npages, nodeid_t node); void free_pgtable_maddr(u64 maddr); void *map_vtd_domain_page(u64 maddr); --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -623,7 +623,8 @@ static int __must_check iommu_flush_all( bool_t flush_dev_iotlb; int rc = 0; - flush_all_cache(); + flush_local(FLUSH_CACHE); + for_each_drhd_unit ( drhd ) { int context_rc, iotlb_rc; --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -46,8 +46,3 @@ void unmap_vtd_domain_page(const void *v { unmap_domain_page(va); } - -void flush_all_cache() -{ - wbinvd(); -}