From patchwork Tue Sep 7 12:07:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12478451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CA2C433EF for ; Tue, 7 Sep 2021 12:07:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 896A260238 for ; Tue, 7 Sep 2021 12:07:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 896A260238 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.180946.327844 (Exim 4.92) (envelope-from ) id 1mNZsx-00088p-0s; Tue, 07 Sep 2021 12:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180946.327844; Tue, 07 Sep 2021 12:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsw-00088i-U3; Tue, 07 Sep 2021 12:07:30 +0000 Received: by outflank-mailman (input) for mailman id 180946; Tue, 07 Sep 2021 12:07:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsw-00086X-9p for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:07:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2a423eb0-0fd4-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:07:26 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-10-wO4pVYOwOfOPYqiRTM-_GQ-1; Tue, 07 Sep 2021 14:07:24 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:07:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:07:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:101:16::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:07:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a423eb0-0fd4-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7mzpWDSKQyeB1Y7K6PB6/ey7zolLxcOfxP5VRC4xpg=; b=SErut9zMOtkNGyzk/89jVwytfHcYzg+NPNOFJpwQ/WeP7lygv3MgD1ZTMW/C1KHGrllcPA k5baRR3ABtSG6pY6EBke79DMgymDIRXYPJnQUYCXlxyYK3JXOxuV9DYpzmaDhDV/Ayzfr3 oIMGYDbPPqwMmWYC0dhhMeBtjakQw5o= X-MC-Unique: wO4pVYOwOfOPYqiRTM-_GQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTIxY8KEDICOriuKX5SuLtaLX8doPexdNM9CYmFxBEanU/cMmnEH74KVzYL39rSFD4cTK9jSwCf4ro+4qMbDkqqBLCOfMNGCux8PMyFvz+3NkZ/exWTw03IZyKMARPSGHmzocZ+YFv8HHvBAAwuxxZbO8mABTODP4EP5WWfk48N/foFbOGqUk0zrhDI3RhKPTgkV79ysNrU+2aYboDr/x9c27H5xTUK3hSOjV8HqIkjw6D2V2cLVL434+YGsBjElA/0ihK3DbZ4gBWofHjC4WAuufdkWFesQopamHg5dOqP/cJsKm6SJZVllpT/O+4hcO70T9szY3ZnX1siBGXbzUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n7mzpWDSKQyeB1Y7K6PB6/ey7zolLxcOfxP5VRC4xpg=; b=bncueqn56HBLtcSH4vHgtaTxs9jKY+re9pppPYPvwbY4YDfvfW6CztYMvYRehgdwJm+YeuRjF0/y9b/kURFHgknYzLDHx1eYCTWmkrd9srrvXilKQIQI0hMH2Z0Yy1ANZo51f77VNnCNZS2p9CDgbP2m0ImH07hJFBtgxUnyOnpK6r3PhuXXV/WgCLAm5ettm1nm1vudbQ+GDSrBPOYlxALXuDiAYgxlcCNH3Q0cllH6xTyFwlCR66dG1heQVXIuOAt63n22daKJhdmYCaxZY3srkXpYSvqdCeym07RAkvGUMU77E6gjpmoiAUoIE5IFKdw7yYSRtAXn5hFNysynwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> Date: Tue, 7 Sep 2021 14:07:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Language: en-US X-ClientProxiedBy: PR2PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:101:16::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aafa5b43-f735-4db3-d08a-08d971f80cd2 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ALtpvWS75rPd7bTQjpiRwarOVxM9LjLzQJ6rf1JxZt1AVwxcvXpcn45dkxiQKB5ZUE+Dfd4K/QpZyDhhp7N+7Zt703ARx9ZdTLUl0hnpDQTsfpdZ8G97B5IP4PAkoN9Zazpzlxligg9aiCWyR4dJmmyvWppWuubxIxPnBHwiACKW+RGTiDLgTr2KBybIb7slboF4jAW+p9+usuzzYMw2fXMnu/835pKx69fVXcNpLFPpFoKrttRnK7WwGgB2G8fSPBZ7oErBw37nJpIiIk8xVCCDlIdPVHbzeiaSJACMLlBlzvM2yobefjCmEnXr+JaYzcAs4PqT5YIbSUGxa/d8LkTMbFNOZ7yhEACe+8oSkfSo0hfDJirqV7Cp4HoZ+xGPkg5rIjaVWJlNripn3uqwSak6XQVF5/MqlFl+nXwE6lXwpmdPPuQOI2FDKPnOYgyhji1HM8NSX+veqqZnFfPBSyZhKk1MEyGZ8dqzk+hJmyhW7MX6KmRSTs/2pRbbrgoJb8AYA9Bs5OjBo8RF1YovTwjE/hXZZb6f3FCwn7pPfa3dgfW8+me43jsnV27UdJCXt1hwCxVyLYIrxd0doxV1bL2eYL3JW/fmJL8knD6+JeSSk5wvmN8Bu+V49zfnznuSnmVTG75b1u/Hj9Gz21QFNvvt5xIUI38olM787kdrmOWXQKp+TyHZZDRHDxtQgbyYbygJHhIBvtPKzgiP6kEaax7UrrxC66jl5eJv1OJfcA0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3qhR3FGSbjQzsj0PCONQL3puwZlb?= =?utf-8?q?EzviiQO1+VLsVI0fpvVK0vrZzvnJXxZxI3lWDOJzj0X6XNy1npdVMgp2/7ezzm4qo?= =?utf-8?q?tTd2q6Bv3VGD0daLepefjfNLm79AYGdCybQX2tpMhlCxCYtYBMLWhBvhzBL7M9N2F?= =?utf-8?q?ZAOwp4BO6AYPE+BEfnMTbK85L2auNNCrzTXqQko8O4MhWbDmSHAyt1V2gZIX2ixzP?= =?utf-8?q?DwYXvbOJl/uUp2g3CtTu28+AFSTkqufl+2gqWDKw8nGN4NxCA4o/8Ua9JGafH8hol?= =?utf-8?q?raasSgIogj4Fo9sikBui3cKhNCQxTW4hh2Ri/xOzDQ4+V3qhfzVfIikfKeUA1HjgU?= =?utf-8?q?t4lVwCrkmNMTZPBodrEUCQSI9XhEuNLh6+HFsm34wZoHbRj1FpEIIbTZ/QTPUJQi5?= =?utf-8?q?T9ZRLji/AcAQtHAACRDUgT7zFAb0bjBZrGsFr6esCn/mwNNXKYfZoP14aP9VG4mMs?= =?utf-8?q?vyM50DH1Aqjbxq7kN52wwMtY57r95JQ9BBwAEKKZjEfHBSXZXZpIHENDB/v/358xD?= =?utf-8?q?vI79jY9Jdwm97iJt9jR55vyna6TN/wQnfms0TdSdyK0/rc9OCIf8DKClp70+N33+8?= =?utf-8?q?ZrAWdru+rprNNXpcIn9sUW2PlzRlTZqQCqUs0rEI7LKxhsviFePUnEvE72abhtjdx?= =?utf-8?q?ljwQ3UojMqoKUeNI+6z0X/OQzNWDkIOSPGnX9rn2g71XR35FIAwIrk6KnIepUIEG8?= =?utf-8?q?BLawSqNdDBM8nUQ/Ill99d6ZEakcL7HMSwfbk4Y5o728kz1TnDAkjIXHd1sToMyY9?= =?utf-8?q?2fRca+bNM9rMAIG97hAMiDHL3mwUq1DRcLZZmI1sBKpK841rMv7SBql/K/eZYAc35?= =?utf-8?q?b0cAd2AYKI7voRxPWs7R+AIortTJQCuAgVDtk3P+k/LVsfRdGlF1JtD9v1obrM7qZ?= =?utf-8?q?syufKOCdjEuGCh/kpE9jeZ+ErjXFT1kXPf9A6UXsYf9Nx9E1FijewVnyYzyOefVtg?= =?utf-8?q?8WpT/EzgmgP4rzWFgR5igpB3JO+i9d3P2NGvwvqhE/ra0k4KT00TIHPXf5/yALw5I?= =?utf-8?q?g/2PK9LIqFe8OZ+gOFdX0G6iZ81arjyDwLmAbeGEfb1W7r9+tr9t5VsvjyaKWMZWV?= =?utf-8?q?PZR2Njt/ubv8XX/2oHe93G1eoHa9kj7pF+ytrEFcFpSHK2z7AKJa5nBsb0x319Lmn?= =?utf-8?q?3m0Shy76yycV62Nxrib37R8My1CQm7/L0dRqzHzrWETptjzbjvmHxGhVp2NbbVJA7?= =?utf-8?q?jpF/JTe9OhgEJqTRyNpYeDI4FB8d/vjlad2K3h5TRoorcBUZhClMFZ0qsoioEpPl5?= =?utf-8?q?cbx/+29amJxrDzSd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aafa5b43-f735-4db3-d08a-08d971f80cd2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:07:23.1625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mZFC7s4D4ydJmgfgHq1eN5JHKDnRLeCTZaomrg8SF5gCbPA7ZyH/63UPSSxFvPLLe9wPZN3GKpUD02THWyXLHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 I consider it unhelpful that address and size of the buffer aren't put in the log file; it makes diagnosing issues needlessly harder. The majority of callers of swiotlb_init() also passes 1 for the "verbose" parameter. Signed-off-by: Jan Beulich Reviewed-by: Christoph Hellwig Acked-by: Stefano Stabellini --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -253,7 +253,7 @@ retry: panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); } - if (swiotlb_init_with_tbl(start, nslabs, false)) + if (swiotlb_init_with_tbl(start, nslabs, true)) panic("Cannot allocate SWIOTLB buffer"); swiotlb_set_max_segment(PAGE_SIZE); }