From patchwork Tue Feb 2 15:14:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12061997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67770C433E0 for ; Tue, 2 Feb 2021 15:14:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18DBC64F5D for ; Tue, 2 Feb 2021 15:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18DBC64F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.80593.147472 (Exim 4.92) (envelope-from ) id 1l6xNg-0000dQ-DL; Tue, 02 Feb 2021 15:14:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 80593.147472; Tue, 02 Feb 2021 15:14:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6xNg-0000dJ-AC; Tue, 02 Feb 2021 15:14:16 +0000 Received: by outflank-mailman (input) for mailman id 80593; Tue, 02 Feb 2021 15:14:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6xNe-0000dD-GI for xen-devel@lists.xenproject.org; Tue, 02 Feb 2021 15:14:14 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f6c7ac7e-148c-4287-b701-906a1675bf95; Tue, 02 Feb 2021 15:14:13 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0F69AABDA; Tue, 2 Feb 2021 15:14:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6c7ac7e-148c-4287-b701-906a1675bf95 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612278853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bSUSrC4kKy6M1cRdxifAihMQi5w0aWPsjPzG6ahbp9A=; b=geWPBSFwqPxOveS6dUnWc6g8a63zMCzhOtwQlN3hxjI+eGjS5EOTOzCOWt3krAZppoOEkT HhLXIYA+ZkEkDFVcKG2xKzoEPMT/qjmp1OuOuOTMR6LRpxIFfF2iuIBiDttGXOVcKXUSxB OCvBq5W/j2ABhIXZoyts+dOBGK9qJtM= Subject: [PATCH v2 1/2] IOREQ: fix waiting for broadcast completion From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant , George Dunlap References: <0e7265fe-8d89-facb-790d-9232c742c3fa@suse.com> Message-ID: <3365a9a1-92c0-8917-1632-b88f1c055392@suse.com> Date: Tue, 2 Feb 2021 16:14:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <0e7265fe-8d89-facb-790d-9232c742c3fa@suse.com> Content-Language: en-US Checking just a single server is not enough - all of them must have signaled that they're done processing the request. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- v2: New. --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -213,9 +213,9 @@ bool vcpu_ioreq_handle_completion(struct return false; } - sv = get_pending_vcpu(v, &s); - if ( sv && !wait_for_io(sv, get_ioreq(s, v)) ) - return false; + while ( (sv = get_pending_vcpu(v, &s)) != NULL ) + if ( !wait_for_io(sv, get_ioreq(s, v)) ) + return false; vio->req.state = ioreq_needs_completion(&vio->req) ? STATE_IORESP_READY : STATE_IOREQ_NONE;