diff mbox series

[RFC,63/84] x86/domain_page: mapcache is no longer tied to pv.

Message ID 340534a15e206136a9573e0af57fd74565dbaeff.1569489002.git.hongyax@amazon.com (mailing list archive)
State New, archived
Headers show
Series Remove direct map from Xen | expand

Commit Message

Xia, Hongyan Sept. 26, 2019, 9:46 a.m. UTC 
From: Hongyan Xia <hongyax@amazon.com>

Signed-off-by: Hongyan Xia <hongyax@amazon.com>
---
 xen/arch/x86/domain_page.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Liu Sept. 26, 2019, 1:59 p.m. UTC | #1 
On Thu, Sep 26, 2019 at 10:46:26AM +0100, hongyax@amazon.com wrote:
> From: Hongyan Xia <hongyax@amazon.com>
> 
> Signed-off-by: Hongyan Xia <hongyax@amazon.com>

AIUI there is where we want to end up. I do wonder if this is the
correct place for this patch though. The bottom line is we need to make
sure the HVM path works before we can allow HVM to use it.

I don't have an answer yet. I will have to look at later patches.

Wei.
diff mbox series

Patch

diff --git a/xen/arch/x86/domain_page.c b/xen/arch/x86/domain_page.c
index 348ea9ebf3..4a3995ccef 100644
--- a/xen/arch/x86/domain_page.c
+++ b/xen/arch/x86/domain_page.c
@@ -84,7 +84,7 @@  void *map_domain_page(mfn_t mfn)
 #endif
 
     v = mapcache_current_vcpu();
-    if ( !v || !is_pv_vcpu(v) )
+    if ( !v )
     {
         void *ret;
         pmap_lock();
@@ -208,7 +208,7 @@  void unmap_domain_page(const void *ptr)
     ASSERT(va >= MAPCACHE_VIRT_START && va < MAPCACHE_VIRT_END);
 
     v = mapcache_current_vcpu();
-    ASSERT(v && is_pv_vcpu(v));
+    ASSERT(v);
 
     dcache = &v->domain->arch.mapcache;
     ASSERT(dcache->inuse);