Message ID | 3cae039b-e01a-b9fc-3b02-1139e3ca20c9@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <xen-devel-bounces@lists.xenproject.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D882C6FD1F for <xen-devel@archiver.kernel.org>; Wed, 22 Mar 2023 09:37:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.513266.794041 (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1peuuV-0005pT-WE; Wed, 22 Mar 2023 09:37:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 513266.794041; Wed, 22 Mar 2023 09:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <xen-devel-bounces@lists.xenproject.org>) id 1peuuV-0005pM-TZ; Wed, 22 Mar 2023 09:37:35 +0000 Received: by outflank-mailman (input) for mailman id 513266; Wed, 22 Mar 2023 09:37:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <SRS0=SGSf=7O=suse.com=JBeulich@srs-se1.protection.inumbo.net>) id 1peuuV-0004gG-4o for xen-devel@lists.xenproject.org; Wed, 22 Mar 2023 09:37:35 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20610.outbound.protection.outlook.com [2a01:111:f400:fe1a::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c8ebad8-c895-11ed-85db-49a42c6b2330; Wed, 22 Mar 2023 10:37:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7526.eurprd04.prod.outlook.com (2603:10a6:20b:299::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 09:37:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 09:37:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion <xen-devel.lists.xenproject.org> List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xenproject.org> List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help> List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe> Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org> X-Inumbo-ID: 2c8ebad8-c895-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cI7S7CPhKoPrfD9dU5uug1veAm9R4yfrbNNiUyRUFA5MU0pq2NieJzVjiykeETrjtVvnpYubxfof6vum3lJZpUzQMuPLVh67yG48lNs+92P5sfOxBUWG9LS1LzjgOwgnvJPZyzbtu8mSpC9QtWNcF0V1CoSO6ROHFBLDX+qLvQjD4sKTcfCjtcgnHRl0eVc6wjqNWdF9EpbnbzZRw6txJUeqA8WdW0hq9zOFz5xJiljPJyPiuOB2coOuL7RMFk6mtjtFAm1QWNkcOPgo1cXPQC6vX3yDJjYOdH+ouFuA754XTEW1zLwQX41Euu6DpYjrYh8U36va8Yh5tdsIayQobw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1l2fkRqRJiGKZyq0x1zbIscrbjHpZaIQjMcBMuPrbQ=; b=JMKjwBrSJO65IKZH/NCdMBPxQcrN4VQVMy6Y5CmzvWuuMmOPyfIPDOJS+h2kMhC/R0KDr0mJgPxDl51gmwLUfZ3tjOIz4VB8GYSpl1Mg6lckPDuMdLE0Hu8g50zat38MFFQoS1z/lNx+vnHPxB4uW2L+pRILjXwDudUEMhTUoyeRFcX0hVyCByjOYsoqn5fr7mbVslbMFHo1gytIQggUxk0pwf2zmFQDe/24nwbcVPOOKpf1FoibEvJxpwp0JxPpGevmFt0/SaSXZj0qIZp3k0fxkLEs36ieIish/bNAYXS/AAddO5MDdYP1Kplxu1HQxxTaghMKEJzLhds9zAvbWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1l2fkRqRJiGKZyq0x1zbIscrbjHpZaIQjMcBMuPrbQ=; b=CjV/m7mlwUdrwiz5SeY+mfeIdDXLH9VvXrRw5BOaP9AdhqmPtNM1GReRjiexslYhtaIopVinag1rkJ4dYleotIaZEsTgCJFdRVtva21gZdJDPspyL1vMnofz0lOwGokaUWXIceli/a85JQRXhxV5iaw0U8ciKhXl/dH5fgzGD1M96md3kX7o/uWyMOLgXnVLhTeEmT3sKf3VWbrqdebDUu3V7lwHLFfmkysdqO5YnTO3rXeOdijkwR4LWqiFWaWn+BtrJHGcDZmL7fDG1MxmHcklRnzpTNpgng7AyJRvnsAmtLY7u8YxwdYA60PemI0U6TQnoWa5j81BpHbTiaR9SQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3cae039b-e01a-b9fc-3b02-1139e3ca20c9@suse.com> Date: Wed, 22 Mar 2023 10:37:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: [PATCH 15/16] x86/shadow: adjust monitor table prealloc amount Content-Language: en-US From: Jan Beulich <jbeulich@suse.com> To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, =?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org> References: <dd9205b8-63f0-b1bc-f2b8-50d5da2bf2a7@suse.com> In-Reply-To: <dd9205b8-63f0-b1bc-f2b8-50d5da2bf2a7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7526:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a669e42-8b08-40da-1f4f-08db2ab91028 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wG7q3a2hLk1mkVg3uXx0B3WljJiSmCR8aUrYSDBlwH8/wpD8V58//Mv5DcWJQJq8RvUyGfjaOZyIyD+7Y8VQHwSTmxi5qhA3zUuj17UZaS/bB9gUno2m3F8TqBLdhNFqRSAPc02IB/S9Y8/2m+yGjnfxZ/GPS9Clow2Zb4MhMPcPUAKRBNmFLO/pXr1za/c1cWwqEpqXU3yCWOaaodhYnz4B38kUCKoWSmyJxs78/6WFvjrA/WgZ8urm7VSlagVhZhWoDNaJyE8D3gYn+tThKLaIp1RfXEC30xUcbEDgTnWosdp8k4b5oi1BC3FYQuxv/ihQJyHGIz7zbLwjzRlbV4GzYulU3+U2L+OqTFQxunQs2ga37UCcw2/Huo8T26nbP76SLBMoF6pYqBmIXRnYocB4agP8IsaSKa74gB/H9AfBTNdK5I7SRCyOjwkwo1gfVpgHtZb1MtuP19QFQA2+JCejdNYSdjepfW7lFtp903cht7wzuyjYI+dMX/cMPSJa1xrS6YjbGC16mT1vi9+dPDYmqCSr5Gc4B/wfmRYLYRujsO7YINHeu59aWj11DlynShrGSQH6SYeKcAgIFQKicC4nGu+OS+09hfoYhwOQgd0SjmXoxCJuQrL9Ew3O5q6tMv6GPpCg6YRN/0nr/AVHEYkwHO0S5aJmv4kCy9D0uWxjTI7nlWbr1VBVVe3am6nqhN7Kv9JrGxzC/mIJBSizKcu7EfXsxj2suybRgfrokVw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199018)(5660300002)(41300700001)(86362001)(38100700002)(8936002)(31696002)(36756003)(2906002)(4326008)(6486002)(478600001)(2616005)(186003)(6512007)(26005)(6506007)(54906003)(8676002)(31686004)(316002)(66946007)(66556008)(66476007)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6QXMe4C8wyQAtpl1Z5cEo2pYdItY?= =?utf-8?q?yd6BqD+PWhFT48kxuSZFnWVGxhFtdzv5LGpbkTZ5WPKY74/nyaP4PPlmHGjhGE+wO?= =?utf-8?q?+DDCS6dU6arSJyBsVFcufw3TGch3gjsFvnZ0OnimUzTeQjBzbJH32NS37O0C4sJB6?= =?utf-8?q?VOwjNMFJltCpHoDOGY0rO4aDBRmbM04Mj8ZBHb5XL8IIgJOSe+lPTwAqnFiyJK5ID?= =?utf-8?q?A/y3b3L/CD4vg5xlN2P/BYfxgjRs0ufAOopAW0TaAWmHv1vESxXVetQrs+lSVu7fl?= =?utf-8?q?09CSyWkCC/6DOE0wFzJCVMmSWLilgxbklAI5+iUiqcawZbYielx3Dw1/J6kNo9Rhx?= =?utf-8?q?xpOc+xtXEnSrvecsTA1sDw7u2A2UV08awopRm9TzEQ1qerrzojj109Z7t2hXXPgBR?= =?utf-8?q?S2wJf9eL4Tfhl1tDB6ZyvI0DfWhffezab+gVmNPnBCkX9k8ClguNSkT4b7QEYN1cp?= =?utf-8?q?WTm7KQ2kDIr6IVuC1TRTGYxYiMNLJG8ArEoTORz5Mj6Dk0vWC+TknnnC85HKVAMAL?= =?utf-8?q?Z1WKIYFSF2MPcvUfAnCs8nOE43v9uQsDHS6pNrnr5rNnIVOsmsyaxTdsk56URdkh7?= =?utf-8?q?6dOD9EI1iAdTolGc6KxBL3rpj5Hq1wvptk2FPU0Jq3Q9Fh2uMdwHV4UrRoTTwzKpv?= =?utf-8?q?MXwevjQYjVJppYBvS01/RTv/VhtTZSWQGasJHuEYhTd3M6labrbs2wqtZ0S7SdK+i?= =?utf-8?q?aL6wDcQbgdNUcXb7BUC6LpQS4f3YqrHfWH4nR4hkPP0bwBj9Kig96dq916BqNwt8L?= =?utf-8?q?Sj1paMDbmHTi9mv1OIt9zXYU+Rx8KzYZG3nEBFndYCqKFT3j2/9DhiwepwBIrAOTQ?= =?utf-8?q?PApzVqTh0ubPZ2x/DqlS4r0pNmvE06vG5zI/k7vUbSZBHHq68Vt9qtPaxnaGuUH1T?= =?utf-8?q?WPgqAxQShbAG3487gubK9vikdXrxA1emDMkillPZTVgeZ+UBC1xCUF3a3Z9DbchWM?= =?utf-8?q?AOfRdnIOdEQ1h/VQ07rz61Koyaip4Vxq3yOC1+40h+a+H8epZV9halHHJBlscRmdt?= =?utf-8?q?T62LF2l+lYcAY/oZBY2R3T4rB5PdDVFkPoPzfifz9exI6/JvJ5O2UpeoilkUOD8ot?= =?utf-8?q?WiApNPXuJHrqzCTtEJfXGq5DgIZ+Rx/BkrxdAmf8eLaw7nhIUCQaykbMMG09hjZP5?= =?utf-8?q?fOV9I4BpKQQhk4OLBWZ97NUPCKSgd28n68U+aLbzYtl4/C9z+6HlLBqMexTwJ+7tA?= =?utf-8?q?DyLpTUdrdLe/+3uwMrqdXiZjsSoj8/ItH5nvXCG77Iz/wAjOXClHIQhJ3De2yETth?= =?utf-8?q?0tOfDu+jOpmz68vIW7B9yGb3zEFBl+CyczIi9wa7bxdES3GNX3bJKa15oLKxf/yT3?= =?utf-8?q?vZrIg29Owm3/+4wT7Cy1tr1D5EzEFKZFasvyO9sFov1gNO5sX/SoFQtYGJwme7Hyk?= =?utf-8?q?+2/ewqUTKhobzwXbd5Mci9DJ/aWer7Ng9g/XOriH/+7vB8InksBf5wEHRTU0c1wvq?= =?utf-8?q?ktaMAkqPAlOKzi+Zv6PHPX/EP+707T3EkNzUVoxXXmOA2y50oxir9k63W+bqgD9mr?= =?utf-8?q?N9JCVugoNM3s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a669e42-8b08-40da-1f4f-08db2ab91028 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 09:37:33.2688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HsfogPGEKFN5kbK+sz5UqEXX4n3OzEbExMlvGWxuSJMJAIhcXIgEYQVesQEpPGZU2WXauXNNpuhh9pW9JfH4dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7526 |
Series |
x86: assorted (mostly) shadow mode adjustments
|
expand
|
--- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -738,7 +738,7 @@ mfn_t sh_make_monitor_table(const struct ASSERT(!pagetable_get_pfn(v->arch.hvm.monitor_table)); /* Guarantee we can get the memory we need */ - if ( !shadow_prealloc(d, SH_type_monitor_table, CONFIG_PAGING_LEVELS) ) + if ( !shadow_prealloc(d, SH_type_monitor_table, shadow_levels < 4 ? 3 : 1) ) return INVALID_MFN; m4mfn = shadow_alloc(d, SH_type_monitor_table, 0);
While 670d6b908ff2 ('x86 shadow: Move the shadow linear mapping for n-on-3-on-4 shadows so') bumped the amount by one too little for the 32-on-64 case (which luckily was dead code, and hence a bump wasn't necessary in the first place), 0b841314dace ('x86/shadow: sh_{make,destroy}_monitor_table() are "even more" HVM-only'), dropping the dead code, then didn't adjust the amount back. Yet even the original amount was too high in certain cases. Switch to pre-allocating just as much as is going to be needed. Signed-off-by: Jan Beulich <jbeulich@suse.com>