| Message ID | 4219d12fcd075635c8c2548c5d14471642af3038.1723045077.git.matthew.barnes@cloud.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XEN,v2] x86/emul: Fix misaligned IO breakpoint behaviour in PV guests | expand |
On 07.08.2024 17:39, Matthew Barnes wrote: > When hardware breakpoints are configured on misaligned IO ports, the > hardware will mask the addresses based on the breakpoint width during > comparison. > > For PV guests, misaligned IO breakpoints do not behave the same way, and > therefore yield different results. > > This patch tweaks the emulation of IO breakpoints for PV guests such > that they reproduce the same behaviour as hardware. > > Fixes: bec9e3205018 ("x86: emulate I/O port access breakpoints") > Signed-off-by: Matthew Barnes <matthew.barnes@cloud.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index f101510a1bab..aa11ecadaac0 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -346,6 +346,8 @@ static unsigned int check_guest_io_breakpoint(struct vcpu *v, case DR_LEN_8: width = 8; break; } + start &= ~(width - 1UL); + if ( (start < (port + len)) && ((start + width) > port) ) match |= 1u << i; }
When hardware breakpoints are configured on misaligned IO ports, the hardware will mask the addresses based on the breakpoint width during comparison. For PV guests, misaligned IO breakpoints do not behave the same way, and therefore yield different results. This patch tweaks the emulation of IO breakpoints for PV guests such that they reproduce the same behaviour as hardware. Fixes: bec9e3205018 ("x86: emulate I/O port access breakpoints") Signed-off-by: Matthew Barnes <matthew.barnes@cloud.com> --- Changes in v2: - Refactor breakpoint port masking to be more succinct - Add 'Fixes' line to commit message --- xen/arch/x86/pv/emul-priv-op.c | 2 ++ 1 file changed, 2 insertions(+)