| Message ID | 42645b41cf9d2d8b5ef72f0b171989711edb00a1.1717790683.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | address remaining violations of Rule 20.12 | expand |
On 07.06.2024 22:13, Nicola Vetrini wrote: > Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are added > to the list of clean guidelines. Why is 20.9 being mentioned here when ... > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl > @@ -60,6 +60,7 @@ MC3R1.R11.7|| > MC3R1.R11.9|| > MC3R1.R12.5|| > MC3R1.R14.1|| > +MC3R1.R14.4|| > MC3R1.R16.7|| > MC3R1.R17.1|| > MC3R1.R17.3|| > @@ -73,6 +74,7 @@ MC3R1.R20.4|| > MC3R1.R20.6|| > MC3R1.R20.9|| > MC3R1.R20.11|| > +MC3R1.R20.12|| > MC3R1.R20.13|| > MC3R1.R20.14|| > MC3R1.R21.3|| ... nothing changes in its regard? Jan
On 2024-06-10 09:43, Jan Beulich wrote: > On 07.06.2024 22:13, Nicola Vetrini wrote: >> Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are >> added >> to the list of clean guidelines. > > Why is 20.9 being mentioned here when ... > >> --- a/automation/eclair_analysis/ECLAIR/tagging.ecl >> +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl >> @@ -60,6 +60,7 @@ MC3R1.R11.7|| >> MC3R1.R11.9|| >> MC3R1.R12.5|| >> MC3R1.R14.1|| >> +MC3R1.R14.4|| >> MC3R1.R16.7|| >> MC3R1.R17.1|| >> MC3R1.R17.3|| >> @@ -73,6 +74,7 @@ MC3R1.R20.4|| >> MC3R1.R20.6|| >> MC3R1.R20.9|| >> MC3R1.R20.11|| >> +MC3R1.R20.12|| >> MC3R1.R20.13|| >> MC3R1.R20.14|| >> MC3R1.R21.3|| > > ... nothing changes in its regard? > Right, it should be removed from the message. > Jan
On Mon, 10 Jun 2024, Nicola Vetrini wrote: > On 2024-06-10 09:43, Jan Beulich wrote: > > On 07.06.2024 22:13, Nicola Vetrini wrote: > > > Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are added > > > to the list of clean guidelines. > > > > Why is 20.9 being mentioned here when ... > > > > > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl > > > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl > > > @@ -60,6 +60,7 @@ MC3R1.R11.7|| > > > MC3R1.R11.9|| > > > MC3R1.R12.5|| > > > MC3R1.R14.1|| > > > +MC3R1.R14.4|| > > > MC3R1.R16.7|| > > > MC3R1.R17.1|| > > > MC3R1.R17.3|| > > > @@ -73,6 +74,7 @@ MC3R1.R20.4|| > > > MC3R1.R20.6|| > > > MC3R1.R20.9|| > > > MC3R1.R20.11|| > > > +MC3R1.R20.12|| > > > MC3R1.R20.13|| > > > MC3R1.R20.14|| > > > MC3R1.R21.3|| > > > > ... nothing changes in its regard? > > > > Right, it should be removed from the message. I fixed the commit message, acked the patch and committed it
diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl index a354ff322e03..b829655ca0bc 100644 --- a/automation/eclair_analysis/ECLAIR/tagging.ecl +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl @@ -60,6 +60,7 @@ MC3R1.R11.7|| MC3R1.R11.9|| MC3R1.R12.5|| MC3R1.R14.1|| +MC3R1.R14.4|| MC3R1.R16.7|| MC3R1.R17.1|| MC3R1.R17.3|| @@ -73,6 +74,7 @@ MC3R1.R20.4|| MC3R1.R20.6|| MC3R1.R20.9|| MC3R1.R20.11|| +MC3R1.R20.12|| MC3R1.R20.13|| MC3R1.R20.14|| MC3R1.R21.3|| @@ -105,7 +107,7 @@ if(string_equal(target,"x86_64"), ) if(string_equal(target,"arm64"), - service_selector({"additional_clean_guidelines","MC3R1.R14.4||MC3R1.R16.6||MC3R1.R20.12||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.2||MC3R1.R7.3||MC3R1.R8.6||MC3R1.R9.3"}) + service_selector({"additional_clean_guidelines","MC3R1.R16.6||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.3"}) ) -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are added to the list of clean guidelines. Some guidelines listed in the additional clean section for ARM are also clean on x86, so they can be removed from there. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.34.1