[v1,3/4] livepatch-gcc: Ignore buildid.o

Commit Message

Mihails Strasuns Jan. 19, 2023, 10:13 a.m. UTC

From: Raphael Ning <[e-mail]>

Not all .o files generated by the Xen build need to be passed to
create-diff-object for analysis. The latest example is:

 Run create-diff-object on xen/arch/x86/efi/buildid.o
 Open base
 /usr/libexec/livepatch-build-tools/create-diff-object: ERROR: buildid.o: kpatch_create_section_list: 77: elf_getshdrnum

This file is special, as it does not contain any sections. It is
generated by objcopy from a magic string of bytes (see Xen commit
eee5909e9d1e x86/EFI: use less crude a way of generating the build ID),
which probably will never change. Therefore, livepatch-gcc should not
copy it to the output directory.

Signed-off-by: Raphael Ning <[e-mail]>
Reviewed-by: Bjoern Doebel <[e-mail]>
Reviewed-by: Martin Pohlack <[e-mail]>

CR: https://code.amazon.com/reviews/CR-63147772
---
 livepatch-gcc | 1 +
 1 file changed, 1 insertion(+)

Comments

Ross Lagerwall Feb. 14, 2023, 11:31 a.m. UTC | #1

> From: Xen-devel <[e-mail]> on behalf of Mihails Strasuns <[e-mail]>
> Sent: Thursday, January 19, 2023 10:13 AM
> To: [e-mail] <[e-mail]>
> Cc: [e-mail] <[e-mail]>; Raphael Ning <[e-mail]>; Bjoern Doebel <[e-mail]>; Martin Pohlack <[e-mail]>
> Subject: [PATCH v1 3/4] livepatch-gcc: Ignore buildid.o 
>  
> From: Raphael Ning <[e-mail]>
> 
> Not all .o files generated by the Xen build need to be passed to
> create-diff-object for analysis. The latest example is:
> 
>  Run create-diff-object on xen/arch/x86/efi/buildid.o
>  Open base
>  /usr/libexec/livepatch-build-tools/create-diff-object: ERROR: buildid.o: kpatch_create_section_list: 77: elf_getshdrnum
> 
> This file is special, as it does not contain any sections. It is
> generated by objcopy from a magic string of bytes (see Xen commit
> eee5909e9d1e x86/EFI: use less crude a way of generating the build ID),
> which probably will never change. Therefore, livepatch-gcc should not
> copy it to the output directory.
> 
> Signed-off-by: Raphael Ning <[e-mail]>
> Reviewed-by: Bjoern Doebel <[e-mail]>
> Reviewed-by: Martin Pohlack <[e-mail]>
> 

Reviewed-by: Ross Lagerwall <[e-mail]>

Patch

diff --git a/livepatch-gcc b/livepatch-gcc
index 91333d5..e72cc8d 100755
--- a/livepatch-gcc
+++ b/livepatch-gcc
@@ -65,6 +65,7 @@  elif [[ "$TOOLCHAINCMD" =~ $OBJCOPY_RE ]] ; then
         version.o|\
         debug.o|\
         efi/check.o|\
+        buildid.o|\
         .*.o)
             ;;
         *.o)