From patchwork Thu Jan 19 10:13:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihails Strasuns X-Patchwork-Id: 13107674 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DC95C38142 for ; Thu, 19 Jan 2023 10:15:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.480914.745547 (Exim 4.92) (envelope-from ) id 1pIRwX-00089y-2p; Thu, 19 Jan 2023 10:14:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 480914.745547; Thu, 19 Jan 2023 10:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIRwW-00089r-VI; Thu, 19 Jan 2023 10:14:48 +0000 Received: by outflank-mailman (input) for mailman id 480914; Thu, 19 Jan 2023 10:14:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pIRwV-0007Sb-Ka for xen-devel@lists.xenproject.org; Thu, 19 Jan 2023 10:14:47 +0000 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18968994-97e2-11ed-91b6-6bf2151ebd3b; Thu, 19 Jan 2023 11:14:46 +0100 (CET) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1d-m6i4x-d7759ebe.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 10:14:39 +0000 Received: from EX13D51EUB004.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1d-m6i4x-d7759ebe.us-east-1.amazon.com (Postfix) with ESMTPS id 7BB8B43948 for ; Thu, 19 Jan 2023 10:14:37 +0000 (UTC) Received: from EX19D029EUB004.ant.amazon.com (10.252.61.53) by EX13D51EUB004.ant.amazon.com (10.43.166.217) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Thu, 19 Jan 2023 10:14:37 +0000 Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX19D029EUB004.ant.amazon.com (10.252.61.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.7; Thu, 19 Jan 2023 10:14:36 +0000 Received: from dev-dsk-mstrasun-1c-15417e94.eu-west-1.amazon.com (172.19.92.214) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.45 via Frontend Transport; Thu, 19 Jan 2023 10:14:35 +0000 Received: by dev-dsk-mstrasun-1c-15417e94.eu-west-1.amazon.com (Postfix, from userid 17415739) id D06FE21426; Thu, 19 Jan 2023 10:14:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 18968994-97e2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1674123287; x=1705659287; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7xjJSEeZVrQKBcQS6rbLeHu3TkZB46tvdM9kg8Ho5tM=; b=aNgiJynxj0bg3dDNDMgoWCjqWlJ0A/jbpo9W64C5Nk6+ybwbUuUIzkpl G2Wa6lQiLtBGqJqRMuHwUzIwwRIaNdQdA8eD0d4HPhOTFT5saVtPfQWFe N6KRDO2F7+5FS+iUMPVMA7d4/QTUVSrwYt8SDd1BsZYnFrsbZwsdcdnKu 8=; X-IronPort-AV: E=Sophos;i="5.97,228,1669075200"; d="scan'208";a="256252891" From: Mihails Strasuns To: CC: , Raphael Ning , Bjoern Doebel , Martin Pohlack Subject: [PATCH v1 3/4] livepatch-gcc: Ignore buildid.o Date: Thu, 19 Jan 2023 10:13:05 +0000 Message-ID: <477a6e0f0b0088c54f3f048bf2b4593eb4df18af.1673623880.git.mstrasun@amazon.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk From: Raphael Ning Not all .o files generated by the Xen build need to be passed to create-diff-object for analysis. The latest example is: Run create-diff-object on xen/arch/x86/efi/buildid.o Open base /usr/libexec/livepatch-build-tools/create-diff-object: ERROR: buildid.o: kpatch_create_section_list: 77: elf_getshdrnum This file is special, as it does not contain any sections. It is generated by objcopy from a magic string of bytes (see Xen commit eee5909e9d1e x86/EFI: use less crude a way of generating the build ID), which probably will never change. Therefore, livepatch-gcc should not copy it to the output directory. Signed-off-by: Raphael Ning Reviewed-by: Bjoern Doebel Reviewed-by: Martin Pohlack CR: https://code.amazon.com/reviews/CR-63147772 Reviewed-by: Ross Lagerwall --- livepatch-gcc | 1 + 1 file changed, 1 insertion(+) diff --git a/livepatch-gcc b/livepatch-gcc index 91333d5..e72cc8d 100755 --- a/livepatch-gcc +++ b/livepatch-gcc @@ -65,6 +65,7 @@ elif [[ "$TOOLCHAINCMD" =~ $OBJCOPY_RE ]] ; then version.o|\ debug.o|\ efi/check.o|\ + buildid.o|\ .*.o) ;; *.o)