| Message ID | 4d3f6608e5c76152e4ad0bbb57e38ac80cf316f3.1697638486.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | x86: address some violations of MISRA C:2012 Rule 8.2 | expand |
On 18.10.2023 16:26, Federico Serafini wrote: > --- a/xen/arch/x86/include/asm/hpet.h > +++ b/xen/arch/x86/include/asm/hpet.h > @@ -60,7 +60,7 @@ extern int8_t opt_hpet_legacy_replacement; > * Return value is zero if HPET is unavailable. > */ > u64 hpet_setup(void); > -void hpet_resume(u32 *); > +void hpet_resume(u32 *boot_cfg); Ideally also switching to uint32_t while touching this: Acked-by: Jan Beulich <jbeulich@suse.com> Jan
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index 79c07f6a9e..63d4158f0f 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -37,7 +37,7 @@ struct hpet_event_channel s_time_t next_event; cpumask_var_t cpumask; spinlock_t lock; - void (*event_handler)(struct hpet_event_channel *); + void (*event_handler)(struct hpet_event_channel *ch); unsigned int idx; /* physical channel idx */ unsigned int cpu; /* msi target */ diff --git a/xen/arch/x86/include/asm/hpet.h b/xen/arch/x86/include/asm/hpet.h index 9919f74730..b342a154e6 100644 --- a/xen/arch/x86/include/asm/hpet.h +++ b/xen/arch/x86/include/asm/hpet.h @@ -60,7 +60,7 @@ extern int8_t opt_hpet_legacy_replacement; * Return value is zero if HPET is unavailable. */ u64 hpet_setup(void); -void hpet_resume(u32 *); +void hpet_resume(u32 *boot_cfg); /* * Disable HPET hardware: restore it to boot time state.
Add missing parameter names. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/hpet.c | 2 +- xen/arch/x86/include/asm/hpet.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)