x86: fix expansion of %XV

Commit Message

Jan Beulich June 16, 2023, 12:33 p.m. UTC

Only %LV should continue on to S handling; avoid emitting a stray 'l'
(typically) in suffix-always mode.

Comments

Jan Beulich June 16, 2023, 12:35 p.m. UTC | #1

On 16.06.2023 14:33, Jan Beulich wrote:
> Only %LV should continue on to S handling; avoid emitting a stray 'l'
> (typically) in suffix-always mode.

Oops, I'm sorry, confusion of mailing lists.

Jan

Patch

--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -11067,19 +11067,20 @@  putop (instr_info *ins, const char *in_t
 		  *ins->obufp++ = ' ';
 		  break;
 		case 'L':
-		  if (!(ins->rex & REX_W))
-		    break;
-		  *ins->obufp++ = 'a';
-		  *ins->obufp++ = 'b';
-		  *ins->obufp++ = 's';
-		  break;
+		  if (ins->rex & REX_W)
+		    {
+		      *ins->obufp++ = 'a';
+		      *ins->obufp++ = 'b';
+		      *ins->obufp++ = 's';
+		    }
+		  goto case_S;
 		default:
 		  abort ();
 		}
 	    }
 	  else
 	    abort ();
-	  goto case_S;
+	  break;
 	case 'W':
 	  if (l == 0)
 	    {