From patchwork Tue Oct 10 02:51:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhenzhong Duan X-Patchwork-Id: 9994831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D0FCF60230 for ; Tue, 10 Oct 2017 02:54:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C068520952 for ; Tue, 10 Oct 2017 02:54:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2D612239D; Tue, 10 Oct 2017 02:54:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3D34120952 for ; Tue, 10 Oct 2017 02:54:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1ke2-0006Z0-PD; Tue, 10 Oct 2017 02:51:46 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1ke2-0006Yu-2P for xen-devel@lists.xenproject.org; Tue, 10 Oct 2017 02:51:46 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 7E/C7-03953-1C53CD95; Tue, 10 Oct 2017 02:51:45 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRWlGSWpSXmKPExsXSO6nOVfeA6Z1 IgwVb9S2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyJ/1exFnxjr/g3ZyVjA+N+ti5GTg4hgclM Ev9mpkDYfxklPm9IhbA3Mko8fhsFYvMKCEqcnPmEBcK2kjjffoEZxGYR0JKYOm8DK4jNJmAgs Wb6N7CZIgKqEocbbrN3MXJxMAusZJRof9jABJIQFoiXeP/2NVizhICSxL+t3UBDOYCK1CXWzx MCCTMLaEssWwhSAhKWllj+jwOi2lii/e1FtgmM/LOQXDQLoXkWkuZZCM0LGFlWMWoUpxaVpRb pGhvoJRVlpmeU5CZm5ugaGpjq5aYWFyemp+YkJhXrJefnbmIEhmU9AwPjDsYJq/wOMUpyMCmJ 8tYa3IkU4kvKT6nMSCzOiC8qzUktPsQow8GhJME73wQoJ1iUmp5akZaZA4wQmLQEB4+SCK+VM VCat7ggMbc4Mx0idYpRl6Pj5t0/TEIsefl5qVLivKtAZgiAFGWU5sGNgEXrJUZZKWFeRgYGBi GegtSi3MwSVPlXjOIcjErCvFUgU3gy80rgNr0COoIJ6AjG4hsgR5QkIqSkGhjz0orv9R5zzN0 48e2/VbNOuMnV1On17Qnm5cpW4xST8BWQeyPV9N1EZEekp8GWWWW9xklWD+8st69df5yJV78l erPrz2fWRpzOXPcFJy/0SSoR8Qmz2cqbePDD461t53884Yrg1niqaC/FOOV3SMonK6evr/KL/ /68FfXUvi/n3e+YYnebR0osxRmJhlrMRcWJAHxg75XRAgAA X-Env-Sender: zhenzhong.duan@oracle.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1507603902!104596061!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13331 invoked from network); 10 Oct 2017 02:51:44 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-5.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Oct 2017 02:51:44 -0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v9A2pd2A025209 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Oct 2017 02:51:40 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v9A2pdV1031442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Oct 2017 02:51:39 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v9A2pcUP026056; Tue, 10 Oct 2017 02:51:38 GMT MIME-Version: 1.0 Message-ID: <52c7977e-cff2-4ebc-867f-1d90b678b6a1@default> Date: Mon, 9 Oct 2017 19:51:38 -0700 (PDT) From: Zhenzhong Duan To: X-Mailer: Zimbra on Oracle Beehive Content-Disposition: inline X-Source-IP: aserv0022.oracle.com [141.146.126.234] Cc: konrad.wilk@oracle.com, andrew.cooper3@citrix.com, joe.jin@oracle.com, srinivas.eeda@oracle.com, jbeulich@suse.com, roger.pau@citrix.com Subject: [Xen-devel] [PATCH v2] x86/physdev: remove redundant code in branch MAP_PIRQ_TYPE_MSI X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Same code is already in allocate_and_map_msi_pirq() -v2: remove unnecessory comment (Suggested by Jan and Roger) added 'x86/physdev:' tag to commit subject (Suggested by Konrad) Signed-off-by: Zhenzhong Duan Reviewed-by: Joe Jin Reviewed-by: Roger Pau Monné Reviewed-by: Konrad Rzeszutek Wilk --- xen/arch/x86/physdev.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c index 0eb4097..bc20b14 100644 --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -122,9 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, break; case MAP_PIRQ_TYPE_MSI: - if ( !msi->table_base ) - msi->entry_nr = 1; - /* fallthrough */ case MAP_PIRQ_TYPE_MULTI_MSI: ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi); break;