lib/inflate.c: remove dead code

Commit Message

Jan Beulich March 25, 2025, 8:13 a.m. UTC

From: Ariel Otilibili <[e-mail]>

This is a follow up from a discussion in Xen:

The if-statement tests that `res` is non-zero; meaning the case zero is
never reached.

Link: https://lore.kernel.org/all/[e-mail]/
Link: https://lkml.kernel.org/r/[e-mail]
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Ariel Otilibili <[e-mail]>
Suggested-by: Jan Beulich <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 41c761dede6e
Signed-off-by: Jan Beulich <[e-mail]>

Comments

Andrew Cooper March 25, 2025, 11:44 a.m. UTC | #1

On 25/03/2025 8:13 am, Jan Beulich wrote:
> From: Ariel Otilibili <[e-mail]>
>
> This is a follow up from a discussion in Xen:
>
> The if-statement tests that `res` is non-zero; meaning the case zero is
> never reached.
>
> Link: https://lore.kernel.org/all/[e-mail]/
> Link: https://lkml.kernel.org/r/[e-mail]
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Ariel Otilibili <[e-mail]>
> Suggested-by: Jan Beulich <[e-mail]>
> Signed-off-by: Andrew Morton <[e-mail]>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 41c761dede6e
> Signed-off-by: Jan Beulich <[e-mail]>

Acked-by: Andrew Cooper <[e-mail]>

Patch

--- a/xen/common/gzip/inflate.c
+++ b/xen/common/gzip/inflate.c
@@ -1164,8 +1164,6 @@  static int __init gunzip(struct gunzip_s
     if ( (res = inflate(s)) )
     {
         switch (res) {
-        case 0:
-            break;
         case 1:
             error("invalid compressed format (err=1)");
             break;