From patchwork Mon Dec 21 14:35:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 7896221 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7D467BEEE5 for ; Mon, 21 Dec 2015 14:38:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8F3BB2055C for ; Mon, 21 Dec 2015 14:38:13 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9604B20567 for ; Mon, 21 Dec 2015 14:38:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aB1Ym-00069U-Vm; Mon, 21 Dec 2015 14:35:36 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aB1Yl-000694-Ig for xen-devel@lists.xenproject.org; Mon, 21 Dec 2015 14:35:35 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id 0B/52-14900-63E08765; Mon, 21 Dec 2015 14:35:34 +0000 X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-6.tower-31.messagelabs.com!1450708532!12021260!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28787 invoked from network); 21 Dec 2015 14:35:33 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-6.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 21 Dec 2015 14:35:33 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Mon, 21 Dec 2015 07:35:31 -0700 Message-Id: <56781C4102000078000C1ED5@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Mon, 21 Dec 2015 07:35:29 -0700 From: "Jan Beulich" To: "xen-devel" References: <56781AAD02000078000C1EBA@prv-mh.provo.novell.com> In-Reply-To: <56781AAD02000078000C1EBA@prv-mh.provo.novell.com> Mime-Version: 1.0 Subject: [Xen-devel] [PATCH 4/4] IOMMU: unhide messages useful for diagnostics X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Undue use of dprintk() lead to many messages useful in diagnosing issues in the field now being hidden in non-debug (i.e. production) builds. Re-surface them. Signed-off-by: Jan Beulich IOMMU: unhide messages useful for diagnostics Undue use of dprintk() lead to many messages useful in diagnosing issues in the field now being hidden in non-debug (i.e. production) builds. Re-surface them. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/io.c +++ b/xen/drivers/passthrough/io.c @@ -543,10 +543,10 @@ int pt_irq_create_bind( spin_unlock(&d->event_lock); if ( iommu_verbose ) - dprintk(XENLOG_G_INFO, - "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n", - d->domain_id, pirq, guest_gsi, bus, - PCI_SLOT(device), PCI_FUNC(device), intx); + printk(XENLOG_G_INFO + "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n", + d->domain_id, pirq, guest_gsi, bus, + PCI_SLOT(device), PCI_FUNC(device), intx); break; } @@ -576,11 +576,11 @@ int pt_irq_destroy_bind( unsigned int device = pt_irq_bind->u.pci.device; unsigned int intx = pt_irq_bind->u.pci.intx; - dprintk(XENLOG_G_INFO, - "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n", - d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx), - pt_irq_bind->u.pci.bus, - PCI_SLOT(device), PCI_FUNC(device), intx); + printk(XENLOG_G_INFO + "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n", + d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx), + pt_irq_bind->u.pci.bus, + PCI_SLOT(device), PCI_FUNC(device), intx); } break; case PT_IRQ_TYPE_MSI: @@ -676,10 +676,10 @@ int pt_irq_destroy_bind( { unsigned int device = pt_irq_bind->u.pci.device; - dprintk(XENLOG_G_INFO, - "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n", - d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus, - PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx); + printk(XENLOG_G_INFO + "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n", + d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus, + PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx); } return 0; --- a/xen/drivers/passthrough/io.c +++ b/xen/drivers/passthrough/io.c @@ -543,10 +543,10 @@ int pt_irq_create_bind( spin_unlock(&d->event_lock); if ( iommu_verbose ) - dprintk(XENLOG_G_INFO, - "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n", - d->domain_id, pirq, guest_gsi, bus, - PCI_SLOT(device), PCI_FUNC(device), intx); + printk(XENLOG_G_INFO + "d%d: bind: m_gsi=%u g_gsi=%u dev=%02x.%02x.%u intx=%u\n", + d->domain_id, pirq, guest_gsi, bus, + PCI_SLOT(device), PCI_FUNC(device), intx); break; } @@ -576,11 +576,11 @@ int pt_irq_destroy_bind( unsigned int device = pt_irq_bind->u.pci.device; unsigned int intx = pt_irq_bind->u.pci.intx; - dprintk(XENLOG_G_INFO, - "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n", - d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx), - pt_irq_bind->u.pci.bus, - PCI_SLOT(device), PCI_FUNC(device), intx); + printk(XENLOG_G_INFO + "d%d: unbind: m_gsi=%u g_gsi=%u dev=%02x:%02x.%u intx=%u\n", + d->domain_id, machine_gsi, hvm_pci_intx_gsi(device, intx), + pt_irq_bind->u.pci.bus, + PCI_SLOT(device), PCI_FUNC(device), intx); } break; case PT_IRQ_TYPE_MSI: @@ -676,10 +676,10 @@ int pt_irq_destroy_bind( { unsigned int device = pt_irq_bind->u.pci.device; - dprintk(XENLOG_G_INFO, - "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n", - d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus, - PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx); + printk(XENLOG_G_INFO + "d%d %s unmap: m_irq=%u dev=%02x:%02x.%u intx=%u\n", + d->domain_id, what, machine_gsi, pt_irq_bind->u.pci.bus, + PCI_SLOT(device), PCI_FUNC(device), pt_irq_bind->u.pci.intx); } return 0;