From patchwork Thu Mar 3 13:56:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 8492791 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 67798C0553 for ; Thu, 3 Mar 2016 13:59:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 931C920145 for ; Thu, 3 Mar 2016 13:59:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FFE32012B for ; Thu, 3 Mar 2016 13:59:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1abTkJ-0003Xd-RI; Thu, 03 Mar 2016 13:56:51 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1abTkI-0003XV-UF for xen-devel@lists.xenproject.org; Thu, 03 Mar 2016 13:56:51 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id B6/75-03497-2A248D65; Thu, 03 Mar 2016 13:56:50 +0000 X-Env-Sender: zhaoshenglong@huawei.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1457013405!27573554!1 X-Originating-IP: [119.145.14.65] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTE5LjE0NS4xNC42NSA9PiA3NzQ2Mw==\n X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 35396 invoked from network); 3 Mar 2016 13:56:48 -0000 Received: from szxga02-in.huawei.com (HELO szxga02-in.huawei.com) (119.145.14.65) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 3 Mar 2016 13:56:48 -0000 Received: from 172.24.1.48 (EHLO szxeml426-hub.china.huawei.com) ([172.24.1.48]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DCN25579; Thu, 03 Mar 2016 21:56:35 +0800 (CST) Received: from [127.0.0.1] (10.177.16.142) by szxeml426-hub.china.huawei.com (10.82.67.181) with Microsoft SMTP Server id 14.3.235.1; Thu, 3 Mar 2016 21:56:30 +0800 Message-ID: <56D8428D.70908@huawei.com> Date: Thu, 3 Mar 2016 21:56:29 +0800 From: Shannon Zhao User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jan Beulich , Stefano Stabellini References: <56D841D002000078000D8CE3@prv-mh.provo.novell.com> <56D83E63.4010607@huawei.com> In-Reply-To: <56D83E63.4010607@huawei.com> X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.56D8429A.00B8, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ebb380c64a0ffb5efcbdebe690a3ac00 Cc: xen-devel , osstest-admin@xenproject.org Subject: Re: [Xen-devel] [xen-unstable-smoke test] 85178: regressions - FAIL X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2016/3/3 21:38, Shannon Zhao wrote: > > > On 2016/3/3 20:53, Jan Beulich wrote: >>>>> On 03.03.16 at 12:18, wrote: >>>> flight 85178 xen-unstable-smoke real [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/85178/ >>>> >>>> Regressions :-( >>>> >>>> Tests which did not succeed and are blocking, >>>> including tests which could not be run: >>>> test-armhf-armhf-xl 6 xen-boot fail REGR. vs. 85080 >> Unless this is a spurious failure, would one of you please look into >> this? The complete lack of Xen messages in the log after the most >> recent host install may suggest that a boot attempt failed very >> early. > Ah, sorry for this. I'm looking at this and have reproduced this. > > It fails with below log: > > (XEN) Xen call trace: > (XEN) [<0000000000204f08>] dt_irq_translate+0x14/0x58 (PC) > (XEN) [<0000000000205244>] dt_device_get_irq+0x2c/0x38 (LR) > (XEN) [<0000000000205244>] dt_device_get_irq+0x2c/0x38 > (XEN) [<000000000024ab54>] platform_get_irq+0x14/0x44 > (XEN) [<000000000028f088>] preinit_xen_time+0x8c/0x120 > (XEN) [<000000000028ddc0>] start_xen+0x554/0xc8c > (XEN) [<000000000020061c>] arm64/head.o#paging+0x84/0xbc > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Assertion 'dt_irq_xlate != NULL' failed at device_tree.c:1452 > With the attached patch, this problem disappeared. Do I need to update the original patch or send a new one? Thanks, diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 5f8f974..66a4520 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -119,7 +119,6 @@ static void __init preinit_dt_xen_time(void) }; int res; u32 rate; - unsigned int i; timer = dt_find_matching_node(NULL, timer_ids); if ( !timer ) @@ -133,16 +132,6 @@ static void __init preinit_dt_xen_time(void) cpu_khz = rate / 1000; timer_dt_clock_frequency = rate; } - - /* Retrieve all IRQs for the timer */ - for ( i = TIMER_PHYS_SECURE_PPI; i < MAX_TIMER_PPI; i++ ) - { - res = platform_get_irq(timer, i); - - if ( res < 0 ) - panic("Timer: Unable to retrieve IRQ %u from the device tree", i); - timer_irq[i] = res; - } } void __init preinit_xen_time(void) @@ -168,6 +157,22 @@ void __init preinit_xen_time(void) /* Set up the timer on the boot CPU (late init function) */ int __init init_xen_time(void) { + int res; + unsigned int i; + + if ( acpi_disabled ) + { + /* Retrieve all IRQs for the timer */ + for ( i = TIMER_PHYS_SECURE_PPI; i < MAX_TIMER_PPI; i++ ) + { + res = platform_get_irq(timer, i); + + if ( res < 0 ) + panic("Timer: Unable to retrieve IRQ %u from the device tree", i); + timer_irq[i] = res; + } + } + /* Check that this CPU supports the Generic Timer interface */ if ( !cpu_has_gentimer ) panic("CPU does not support the Generic Timer v1 interface");