From patchwork Wed Sep 6 08:57:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13375384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC16EB8FB5 for ; Wed, 6 Sep 2023 08:58:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.596374.930260 (Exim 4.92) (envelope-from ) id 1qdoMC-0000J3-ML; Wed, 06 Sep 2023 08:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 596374.930260; Wed, 06 Sep 2023 08:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qdoMC-0000GG-Dz; Wed, 06 Sep 2023 08:57:52 +0000 Received: by outflank-mailman (input) for mailman id 596374; Wed, 06 Sep 2023 08:57:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qdoMB-0008TQ-Bb for xen-devel@lists.xenproject.org; Wed, 06 Sep 2023 08:57:51 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7468798e-4c93-11ee-8783-cb3800f73035; Wed, 06 Sep 2023 10:57:49 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-87-6-207-235.retail.telecomitalia.it [87.6.207.235]) by support.bugseng.com (Postfix) with ESMTPSA id CA65D4EE073D; Wed, 6 Sep 2023 10:57:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7468798e-4c93-11ee-8783-cb3800f73035 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 3/4] x86/io_apic: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Wed, 6 Sep 2023 10:57:40 +0200 Message-Id: <56bfeae4c6a5c7f65a3f329003583aed6de13b19.1693990010.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names and make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/arch/x86/include/asm/io_apic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/io_apic.h b/xen/arch/x86/include/asm/io_apic.h index 9165da2281..a7e4c9e146 100644 --- a/xen/arch/x86/include/asm/io_apic.h +++ b/xen/arch/x86/include/asm/io_apic.h @@ -199,7 +199,7 @@ extern struct IO_APIC_route_entry __ioapic_read_entry( unsigned int apic, unsigned int pin, bool raw); void __ioapic_write_entry( unsigned int apic, unsigned int pin, bool raw, - struct IO_APIC_route_entry); + struct IO_APIC_route_entry e); extern struct IO_APIC_route_entry **alloc_ioapic_entries(void); extern void free_ioapic_entries(struct IO_APIC_route_entry **ioapic_entries); @@ -211,6 +211,6 @@ extern int restore_IO_APIC_setup(struct IO_APIC_route_entry **ioapic_entries, unsigned highest_gsi(void); int ioapic_guest_read( unsigned long physbase, unsigned int reg, u32 *pval); -int ioapic_guest_write(unsigned long physbase, unsigned int reg, u32 pval); +int ioapic_guest_write(unsigned long physbase, unsigned int reg, u32 val); #endif