diff mbox

x86/HVM: remove dead code

Message ID 570225BE02000078000E28E3@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich April 4, 2016, 6:28 a.m. UTC 
With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached
requests") rc doesn't change anymore in the respective preceding
switch() statements.

Coverity ID: 1358080
Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/HVM: remove dead code

With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached
requests") rc doesn't change anymore in the respective preceding
switch() statements.

Coverity ID: 1358080
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/intercept.c
+++ b/xen/arch/x86/hvm/intercept.c
@@ -151,8 +151,6 @@ int hvm_process_io_intercept(const struc
                     domain_crash(current->domain);
                     return X86EMUL_UNHANDLEABLE;
                 }
-                if ( rc != X86EMUL_OKAY )
-                    break;
             }
             else
                 p->data = data;
@@ -181,8 +181,6 @@ int hvm_process_io_intercept(const struc
                     domain_crash(current->domain);
                     return X86EMUL_UNHANDLEABLE;
                 }
-                if ( rc != X86EMUL_OKAY )
-                    break;
             }
             else
                 data = p->data;

Comments

Andrew Cooper April 5, 2016, 9:34 a.m. UTC | #1 
On 04/04/16 07:28, Jan Beulich wrote:
> With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached
> requests") rc doesn't change anymore in the respective preceding
> switch() statements.
>
> Coverity ID: 1358080
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/arch/x86/hvm/intercept.c
+++ b/xen/arch/x86/hvm/intercept.c
@@ -151,8 +151,6 @@  int hvm_process_io_intercept(const struc
                     domain_crash(current->domain);
                     return X86EMUL_UNHANDLEABLE;
                 }
-                if ( rc != X86EMUL_OKAY )
-                    break;
             }
             else
                 p->data = data;
@@ -181,8 +181,6 @@  int hvm_process_io_intercept(const struc
                     domain_crash(current->domain);
                     return X86EMUL_UNHANDLEABLE;
                 }
-                if ( rc != X86EMUL_OKAY )
-                    break;
             }
             else
                 data = p->data;