From patchwork Mon Apr 4 06:28:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 8740271 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DC7329F39A for ; Mon, 4 Apr 2016 11:18:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0506E20107 for ; Mon, 4 Apr 2016 11:18:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30027200E1 for ; Mon, 4 Apr 2016 11:18:07 +0000 (UTC) Received: from [127.0.0.1] (helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amy0N-0001aq-BF; Mon, 04 Apr 2016 06:28:55 +0000 Received: from [195.245.231.135] (helo=mail6.bemta5.messagelabs.com) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amy0M-0001ak-8S for xen-devel@lists.xenproject.org; Mon, 04 Apr 2016 06:28:54 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 3E/35-16378-5A902075; Mon, 04 Apr 2016 06:28:53 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRWlGSWpSXmKPExsXS6fjDS3cJJ1O 4wfwHphbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bPlSfZCppFKnZeu8PawNjN18XIySEkkCfx a+VdNhCbV8BO4tCzG+wgtoSAocS++avA4iwCqhKrN7wCi7MJqEu0PdvO2sXIwSEiYCBx7mgSS JhZQEfi/b/5zCC2sICWxK8nt9hASngFBCX+7hCGKLGTWLi3l2UCI9cshMwsJBkIW0vi4a9bUL a2xLKFr5lBypkFpCWW/+OACDtJfL+9ng1VCYjtK3Hi2GrGBYwcqxg1ilOLylKLdA1N9ZKKMtM zSnITM3N0DQ1M9XJTi4sT01NzEpOK9ZLzczcxAoOPAQh2MDZs9zzEKMnBpCTKu+geY7gQX1J+ SmVGYnFGfFFpTmrxIUYZDg4lCd4+DqZwIcGi1PTUirTMHGAcwKQlOHiURHhPg6R5iwsSc4sz0 yFSpxgVpcR5J4EkBEASGaV5cG2w2LvEKCslzMsIdIgQT0FqUW5mCar8K0ZxDkYlYd6pIFN4Mv NK4Ka/AlrMBLS4Q/pfGNDikkSElFQDo12A2UHd6Q7ZM372frvbksx0sPBG6uIb0zU/MHZFFb3 bYMvfGcZ9sHrRBPXC66L8DTbn8k/nhXwJj3e+Y6Ao9FphpfKZizxt7E8iDpcs9/Vj/d0e4zHP XXWf9qyr3lpXWc80bjjJUv25RU2z1mHnq5rjF7YLcMfau93W0wvdE9LTfcSh7pCBEktxRqKhF nNRcSIAyaUjlbgCAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1459751331!18298447!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10865 invoked from network); 4 Apr 2016 06:28:52 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-16.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 4 Apr 2016 06:28:52 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Mon, 04 Apr 2016 00:28:50 -0600 Message-Id: <570225BE02000078000E28E3@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Mon, 04 Apr 2016 00:28:46 -0600 From: "Jan Beulich" To: "xen-devel" Mime-Version: 1.0 Cc: Paul Durrant Subject: [Xen-devel] [PATCH] x86/HVM: remove dead code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached requests") rc doesn't change anymore in the respective preceding switch() statements. Coverity ID: 1358080 Signed-off-by: Jan Beulich x86/HVM: remove dead code With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached requests") rc doesn't change anymore in the respective preceding switch() statements. Coverity ID: 1358080 Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -151,8 +151,6 @@ int hvm_process_io_intercept(const struc domain_crash(current->domain); return X86EMUL_UNHANDLEABLE; } - if ( rc != X86EMUL_OKAY ) - break; } else p->data = data; @@ -181,8 +181,6 @@ int hvm_process_io_intercept(const struc domain_crash(current->domain); return X86EMUL_UNHANDLEABLE; } - if ( rc != X86EMUL_OKAY ) - break; } else data = p->data; Reviewed-by: Andrew Cooper --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -151,8 +151,6 @@ int hvm_process_io_intercept(const struc domain_crash(current->domain); return X86EMUL_UNHANDLEABLE; } - if ( rc != X86EMUL_OKAY ) - break; } else p->data = data; @@ -181,8 +181,6 @@ int hvm_process_io_intercept(const struc domain_crash(current->domain); return X86EMUL_UNHANDLEABLE; } - if ( rc != X86EMUL_OKAY ) - break; } else data = p->data;