From patchwork Wed Jun 15 10:12:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9178007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 640D060573 for ; Wed, 15 Jun 2016 10:14:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F3A927F54 for ; Wed, 15 Jun 2016 10:14:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40BCD28113; Wed, 15 Jun 2016 10:14:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C5B3827F54 for ; Wed, 15 Jun 2016 10:14:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bD7oS-0005x9-Ub; Wed, 15 Jun 2016 10:12:44 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bD7oR-0005x3-HN for xen-devel@lists.xen.org; Wed, 15 Jun 2016 10:12:43 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id 54/45-26731-A1A21675; Wed, 15 Jun 2016 10:12:42 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRWlGSWpSXmKPExsXS6fjDS1dKKzH cYNZzdoslHxezODB6HN39mymAMYo1My8pvyKBNePk1wcsBRt5KnZ9m8DawNjH1cXIySEkkCdx Zfd15i5GDg5eATuJH5t1QMISAoYS++avYgOxWQRUJX78bmMHsdkE1CXanm1nBbFFBPQlVnddY wGxmQVkJRbcuQFmCwuUSqzZtQuohgto/ElGias/X4M1cwqYS/w5eo8dYpegxN8dwhC9WhIPf9 2CmqMtsWzha7BzmAWkJZb/45jAyDcLoWEWkoZZSBpmITQsYGRZxahenFpUllqka6yXVJSZnlG Sm5iZo2toaKKXm1pcnJiempOYVKyXnJ+7iREYegxAsIPxbp/zIUZJDiYlUV4PucRwIb6k/JTK jMTijPii0pzU4kOMMhwcShK83zSAcoJFqempFWmZOcAogElLcPAoifBaaQKleYsLEnOLM9MhU qcYFaXEeU1AEgIgiYzSPLg2WORdYpSVEuZlBDpEiKcgtSg3swRV/hWjOAejkjAvH8gUnsy8Er jpr4AWMwEttpkeD7K4JBEhJdXAmPhGYvl0vTcOlSzbC0vFcxa+cPwpMT2GXf77xvVG25hFs2d sludjuSp/8tRDhq+H3wR3rtls8+xNk67/pzcsmYznOZXv/pf9NdtRfpPpTEfNKi/dY37aZy+t 3Ho1aOb7xjIms9MNtzKZ1y9SP15o8c54ylS2+Qe/RlQsXyC1Ln6r3+lUuRxVSSWW4oxEQy3mo uJEAKt6Ac+3AgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1465985560!46967172!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 50844 invoked from network); 15 Jun 2016 10:12:41 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-4.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 15 Jun 2016 10:12:41 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Wed, 15 Jun 2016 04:12:39 -0600 Message-Id: <5761463502000078000F5355@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Wed, 15 Jun 2016 04:12:37 -0600 From: "Jan Beulich" To: "Sander Eikelenboom" References: <512f1937a329b74ab2f0a84067e05797@eikelenboom.it> <57612E1102000078000F5229@prv-mh.provo.novell.com> <1104389404.20160615105703@eikelenboom.it> <1608092437.20160615113846@eikelenboom.it> In-Reply-To: <1608092437.20160615113846@eikelenboom.it> Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel@lists.xen.org Subject: Re: [Xen-devel] Xen-unstable 4.8: HVM domain_crash called from emulate.c:144 RIP: c000:[<000000000000336a>] X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP >>> On 15.06.16 at 11:38, wrote: > Wednesday, June 15, 2016, 10:57:03 AM, you wrote: > >> Wednesday, June 15, 2016, 10:29:37 AM, you wrote: > >>>>>> On 15.06.16 at 01:49, wrote: >>>> Just tested latest xen-unstable 4.8 (xen_changeset git:d337764), >>>> but one of the latest commits seems to have broken boot of HVM guests >>>> (using qemu-xen) previous build with xen_changeset git:6e908ee worked >>>> fine. > >>> Primary suspects would seem to be 67fc274bbe and bfa84968b2, >>> but (obviously) I didn't see any issues with them in my own >>> testing, so could you >>> - instead of doing a full bisect, revert just those two > >> Will give reverting that a shot. > > Reverting bfa84968b2 is sufficient. Could you give this wild guess a try on top of the tree without the revert? >>> And then of course this domain_crash() could of course be >>> accompanied by some helpful printk() ... > > Do you have a debug patch of what you are interested in ? Not yet - basically we should log all of the variables involved in the condition leading to the domain_crash(). Jan --- unstable.orig/xen/arch/x86/hvm/emulate.c +++ unstable/xen/arch/x86/hvm/emulate.c @@ -1180,7 +1180,7 @@ static int hvmemul_rep_movs( pfec |= PFEC_user_mode; bytes = PAGE_SIZE - (saddr & ~PAGE_MASK); - if ( vio->mmio_access.read_access && + if ( vio->mmio_access.read_access && !vio->mmio_access.write_access && (vio->mmio_gla == (saddr & PAGE_MASK)) && bytes >= bytes_per_rep ) {