From patchwork Mon Jun 20 11:04:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9187243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 293006075E for ; Mon, 20 Jun 2016 11:06:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 13985265B9 for ; Mon, 20 Jun 2016 11:06:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07C032684F; Mon, 20 Jun 2016 11:06:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 80267265B9 for ; Mon, 20 Jun 2016 11:06:57 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEx0Q-0004gW-MG; Mon, 20 Jun 2016 11:04:38 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEx0P-0004gQ-Ca for xen-devel@lists.xenproject.org; Mon, 20 Jun 2016 11:04:37 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id 6B/61-23871-4CDC7675; Mon, 20 Jun 2016 11:04:36 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRWlGSWpSXmKPExsXS6fjDS/fw2fR wg8dLDSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyO9p+sBTsEKt5cb2dtYNzF28XIySEkkCfx ++IXVhCbV8BO4tGjVnYQW0LAUGLf/FVsIDaLgKrE7JW9LCA2m4C6RNuz7UD1HBwiAgYS544mg ZjMAvoS29aBVQgLOEjc33mEDSTMKyAo8XeHMEiYGWj4+gmr2Ccwcs1CyMxCkoGwtSQe/rrFAm FrSyxb+Jp5Fth8aYnl/zggwu4Scy81M6IqAbGDJD5u+su8gJFjFaN6cWpRWWqRrpleUlFmekZ JbmJmjq6hgbFebmpxcWJ6ak5iUrFecn7uJkZg4NUzMDDuYLzS5nyIUZKDSUmU16Y4PVyILyk/ pTIjsTgjvqg0J7X4EKMMB4eSBK/QKaCcYFFqempFWmYOMAZg0hIcPEoivOkgad7igsTc4sx0i NQpRkUpcd4/J4ESAiCJjNI8uDZY3F1ilJUS5mVkYGAQ4ilILcrNLEGVf8UozsGoJMxrATKeJz OvBG76K6DFTECLl/WDLS5JREhJNTA2XfaL3F7VHbTPbtJHxbI4rz/p/GdnBk3zqjFhlL4xSfR 2u2dWl2tuTuVRHU/NTyUiEWpnHz+eob3HufDgJ6aSPy+K7x4KZuvYqv93if3We7e2ifyt+Kzi uTNI+ky6irbyitdip8SsAqY+mTWtspn98r5brKuvO+/SdHJfWf8sXYjFWT0lcbUSS3FGoqEWc 1FxIgD3ZdYOtgIAAA== X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-13.tower-31.messagelabs.com!1466420673!45677887!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41352 invoked from network); 20 Jun 2016 11:04:35 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-13.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Jun 2016 11:04:35 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Mon, 20 Jun 2016 05:04:32 -0600 Message-Id: <5767E9DE02000078000F69D3@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Mon, 20 Jun 2016 05:04:30 -0600 From: "Jan Beulich" To: "xen-devel" Mime-Version: 1.0 Cc: Andrew Cooper Subject: [Xen-devel] [PATCH] x86: compact supposedly unused entry point code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP No point in aligning entry points which aren't supposed to be used anyway. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- TBD: Might consider simply using "andq $-15,%rsp", delivering an uninitialized error code (which shouldn't matter). x86: compact supposedly unused entry point code No point in aligning entry points which aren't supposed to be used anyway. Signed-off-by: Jan Beulich --- TBD: Might consider simply using "andq $-15,%rsp", delivering an uninitialized error code (which shouldn't matter). --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -866,11 +866,11 @@ autogen_stubs: /* Automatically generate vec = 0 .rept NR_VECTORS - ALIGN /* Common interrupts, heading towards do_IRQ(). */ .if vec >= FIRST_DYNAMIC_VECTOR && vec != HYPERCALL_VECTOR && vec != LEGACY_SYSCALL_VECTOR + ALIGN 1: pushq $0 movb $vec,4(%rsp) jmp common_interrupt --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -866,11 +866,11 @@ autogen_stubs: /* Automatically generate vec = 0 .rept NR_VECTORS - ALIGN /* Common interrupts, heading towards do_IRQ(). */ .if vec >= FIRST_DYNAMIC_VECTOR && vec != HYPERCALL_VECTOR && vec != LEGACY_SYSCALL_VECTOR + ALIGN 1: pushq $0 movb $vec,4(%rsp) jmp common_interrupt