From patchwork Mon Jun 20 12:54:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9187369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 593F26075F for ; Mon, 20 Jun 2016 13:02:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 434302237D for ; Mon, 20 Jun 2016 13:02:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3728B2780C; Mon, 20 Jun 2016 13:02:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4F2C72237D for ; Mon, 20 Jun 2016 13:02:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEykt-0006u4-3f; Mon, 20 Jun 2016 12:56:43 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEykr-0006tm-Rl for xen-devel@lists.xenproject.org; Mon, 20 Jun 2016 12:56:42 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 33/EC-24961-808E7675; Mon, 20 Jun 2016 12:56:40 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRWlGSWpSXmKPExsXS6fjDS/fn8/R wgxdnrC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyz++YwFtxvZaw4f+oyYwPjr/QuRk4OIYE8 idN7V7OB2LwCdhLdF7rYQWwJAUOJffNXgcVZBFQlbp14zQxiswmoS7Q9287axcjBISJgIHHua FIXIxcHs8BeJom2aZ9YQGqEBWwlfty9zAIx307iza0PYL2cAvYSKydvAOvlFRCU+LtDGCTMDF Ty+mIj6wRGnlkImVlIMhC2lsTDX7dYIGxtiWULXzODlDMLSEss/8cBETaQaJyyjR1VCYhtLXG scxLrAkaOVYzqxalFZalFuiZ6SUWZ6RkluYmZObqGBsZ6uanFxYnpqTmJScV6yfm5mxiB4coA BDsYG784HWKU5GBSEuW1KU4PF+JLyk+pzEgszogvKs1JLT7EKMPBoSTBe+8wUE6wKDU9tSItM wcYOTBpCQ4eJRHeGSBp3uKCxNzizHSI1ClGRSlx3rsgCQGQREZpHlwbLFovMcpKCfMyAh0ixF OQWpSbWYIq/4pRnINRSZh3KcgUnsy8Erjpr4AWMwEtXtYPtrgkESEl1cBowvEjd4trkaPGimI FJh+d7atT/J5ryBU+6v6w79vpNxYTE9eHXpW4dOvLMlmJqpq272La+upO7ewynzbJCmz3OpLj ILgpJMBHPnPF6R83+hyXSvyQ3T+hwyx52TkBy/L7bT89dpyoOuIfeJGrwKeWp+70tJw9gpFnd /Io3vhwqWAh27Ojm28psRRnJBpqMRcVJwIA1o1d5NECAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1466427301!45608193!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39769 invoked from network); 20 Jun 2016 12:55:43 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-10.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Jun 2016 12:55:43 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Mon, 20 Jun 2016 06:55:00 -0600 Message-Id: <576803C102000078000F6BEE@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Mon, 20 Jun 2016 06:54:57 -0600 From: "Jan Beulich" To: "xen-devel" References: <5768002C02000078000F6B8D@prv-mh.provo.novell.com> In-Reply-To: <5768002C02000078000F6B8D@prv-mh.provo.novell.com> Mime-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Paul Durrant , dgdegra@tycho.nsa.gov Subject: [Xen-devel] [PATCH 05/11] hvmctl: convert HVMOP_track_dirty_vram X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Also limiting "nr" at the libxc level to 32 bits (the high 32 bits of the previous 64-bit parameter got ignore so far). Signed-off-by: Jan Beulich hvmctl: convert HVMOP_track_dirty_vram Also limiting "nr" at the libxc level to 32 bits (the high 32 bits of the previous 64-bit parameter got ignore so far). Signed-off-by: Jan Beulich --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1613,7 +1613,7 @@ int xc_hvm_inject_msi( */ int xc_hvm_track_dirty_vram( xc_interface *xch, domid_t dom, - uint64_t first_pfn, uint64_t nr, + uint64_t first_gfn, uint32_t nr, unsigned long *bitmap); /* --- a/tools/libxc/xc_misc.c +++ b/tools/libxc/xc_misc.c @@ -533,33 +533,27 @@ int xc_hvm_inject_msi( int xc_hvm_track_dirty_vram( xc_interface *xch, domid_t dom, - uint64_t first_pfn, uint64_t nr, + uint64_t first_gfn, uint32_t nr, unsigned long *dirty_bitmap) { + DECLARE_HVMCTL(track_dirty_vram, dom, + .first_gfn = first_gfn, + .nr = nr); DECLARE_HYPERCALL_BOUNCE(dirty_bitmap, (nr+7) / 8, XC_HYPERCALL_BUFFER_BOUNCE_OUT); - DECLARE_HYPERCALL_BUFFER(struct xen_hvm_track_dirty_vram, arg); int rc; - arg = xc_hypercall_buffer_alloc(xch, arg, sizeof(*arg)); - if ( arg == NULL || xc_hypercall_bounce_pre(xch, dirty_bitmap) ) + if ( xc_hypercall_bounce_pre(xch, dirty_bitmap) ) { PERROR("Could not bounce memory for xc_hvm_track_dirty_vram hypercall"); - rc = -1; - goto out; + return -1; } - arg->domid = dom; - arg->first_pfn = first_pfn; - arg->nr = nr; - set_xen_guest_handle(arg->dirty_bitmap, dirty_bitmap); - - rc = xencall2(xch->xcall, __HYPERVISOR_hvm_op, - HVMOP_track_dirty_vram, - HYPERCALL_BUFFER_AS_ARG(arg)); + set_xen_guest_handle(hvmctl.u.track_dirty_vram.dirty_bitmap, dirty_bitmap); + + rc = do_hvmctl(xch, &hvmctl); -out: - xc_hypercall_buffer_free(xch, arg); xc_hypercall_bounce_post(xch, dirty_bitmap); + return rc; } --- a/xen/arch/x86/hvm/control.c +++ b/xen/arch/x86/hvm/control.c @@ -17,6 +17,8 @@ #include #include #include +#include +#include #include static int set_pci_intx_level(struct domain *d, @@ -67,6 +69,27 @@ static int set_isa_irq_level(struct doma return 0; } +static int track_dirty_vram(struct domain *d, + const struct xen_hvm_track_dirty_vram *op) +{ + if ( !is_hvm_domain(d) ) + return -EINVAL; + + if ( op->rsvd || op->nr > (GB(1) >> PAGE_SHIFT) ) + return -EINVAL; + + if ( d->is_dying ) + return -ESRCH; + + if ( !d->max_vcpus || !d->vcpu[0] ) + return -EINVAL; + + return shadow_mode_enabled(d) + ? shadow_track_dirty_vram(d, op->first_gfn, op->nr, + op->dirty_bitmap) + : hap_track_dirty_vram(d, op->first_gfn, op->nr, op->dirty_bitmap); +} + /* * Note that this value is effectively part of the ABI, even if we don't need * to make it a formal part of it. Hence this value may only be changed if @@ -125,6 +148,10 @@ long do_hvmctl(XEN_GUEST_HANDLE_PARAM(xe op.u.set_pci_link_route.isa_irq); break; + case XEN_HVMCTL_track_dirty_vram: + rc = track_dirty_vram(d, &op.u.track_dirty_vram); + break; + default: rc = -EOPNOTSUPP; break; --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -5296,47 +5296,6 @@ long do_hvm_op(unsigned long op, XEN_GUE rc = guest_handle_is_null(arg) ? hvmop_flush_tlb_all() : -ENOSYS; break; - case HVMOP_track_dirty_vram: - { - struct xen_hvm_track_dirty_vram a; - struct domain *d; - - if ( copy_from_guest(&a, arg, 1) ) - return -EFAULT; - - rc = rcu_lock_remote_domain_by_id(a.domid, &d); - if ( rc != 0 ) - return rc; - - rc = -EINVAL; - if ( !is_hvm_domain(d) ) - goto tdv_fail; - - if ( a.nr > GB(1) >> PAGE_SHIFT ) - goto tdv_fail; - - rc = xsm_hvm_control(XSM_DM_PRIV, d, op); - if ( rc ) - goto tdv_fail; - - rc = -ESRCH; - if ( d->is_dying ) - goto tdv_fail; - - rc = -EINVAL; - if ( d->vcpu == NULL || d->vcpu[0] == NULL ) - goto tdv_fail; - - if ( shadow_mode_enabled(d) ) - rc = shadow_track_dirty_vram(d, a.first_pfn, a.nr, a.dirty_bitmap); - else - rc = hap_track_dirty_vram(d, a.first_pfn, a.nr, a.dirty_bitmap); - - tdv_fail: - rcu_unlock_domain(d); - break; - } - case HVMOP_modified_memory: { struct xen_hvm_modified_memory a; --- a/xen/include/public/hvm/control.h +++ b/xen/include/public/hvm/control.h @@ -55,6 +55,18 @@ struct xen_hvm_set_pci_link_route { uint8_t isa_irq; }; +/* XEN_HVMCTL_track_dirty_vram */ +struct xen_hvm_track_dirty_vram { + /* Number of pages to track. */ + uint32_t nr; + uint32_t rsvd; + /* First GFN to track. */ + uint64_aligned_t first_gfn; + /* OUT variable. */ + /* Dirty bitmap buffer. */ + XEN_GUEST_HANDLE_64(uint8) dirty_bitmap; +}; + struct xen_hvmctl { uint16_t interface_version; /* XEN_HVMCTL_INTERFACE_VERSION */ domid_t domain; @@ -62,11 +74,13 @@ struct xen_hvmctl { #define XEN_HVMCTL_set_pci_intx_level 1 #define XEN_HVMCTL_set_isa_irq_level 2 #define XEN_HVMCTL_set_pci_link_route 3 +#define XEN_HVMCTL_track_dirty_vram 4 uint16_t opaque; /* Must be zero on initial invocation. */ union { struct xen_hvm_set_pci_intx_level set_pci_intx_level; struct xen_hvm_set_isa_irq_level set_isa_irq_level; struct xen_hvm_set_pci_link_route set_pci_link_route; + struct xen_hvm_track_dirty_vram track_dirty_vram; uint8_t pad[120]; } u; }; --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -98,22 +98,6 @@ typedef enum { /* Following tools-only interfaces may change in future. */ #if defined(__XEN__) || defined(__XEN_TOOLS__) -/* Track dirty VRAM. */ -#define HVMOP_track_dirty_vram 6 -struct xen_hvm_track_dirty_vram { - /* Domain to be tracked. */ - domid_t domid; - /* Number of pages to track. */ - uint32_t nr; - /* First pfn to track. */ - uint64_aligned_t first_pfn; - /* OUT variable. */ - /* Dirty bitmap buffer. */ - XEN_GUEST_HANDLE_64(uint8) dirty_bitmap; -}; -typedef struct xen_hvm_track_dirty_vram xen_hvm_track_dirty_vram_t; -DEFINE_XEN_GUEST_HANDLE(xen_hvm_track_dirty_vram_t); - /* Notify that some pages got modified by the Device Model. */ #define HVMOP_modified_memory 7 struct xen_hvm_modified_memory { --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1174,9 +1174,6 @@ static int flask_hvm_param(struct domain case HVMOP_get_param: perm = HVM__GETPARAM; break; - case HVMOP_track_dirty_vram: - perm = HVM__TRACKDIRTYVRAM; - break; default: perm = HVM__HVMCTL; } @@ -1199,6 +1196,9 @@ static int flask_hvm_control(struct doma case XEN_HVMCTL_set_pci_link_route: perm = HVM__PCIROUTE; break; + case XEN_HVMCTL_track_dirty_vram: + perm = HVM__TRACKDIRTYVRAM; + break; default: perm = HVM__HVMCTL; break; --- a/xen/xsm/flask/policy/access_vectors +++ b/xen/xsm/flask/policy/access_vectors @@ -270,7 +270,7 @@ class hvm bind_irq # XEN_DOMCTL_pin_mem_cacheattr cacheattr -# HVMOP_track_dirty_vram +# XEN_HVMCTL_track_dirty_vram trackdirtyvram # HVMOP_modified_memory, HVMOP_get_mem_type, HVMOP_set_mem_type, # HVMOP_set_mem_access, HVMOP_get_mem_access, HVMOP_pagetable_dying, Reviewed-by: Wei Liu --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1613,7 +1613,7 @@ int xc_hvm_inject_msi( */ int xc_hvm_track_dirty_vram( xc_interface *xch, domid_t dom, - uint64_t first_pfn, uint64_t nr, + uint64_t first_gfn, uint32_t nr, unsigned long *bitmap); /* --- a/tools/libxc/xc_misc.c +++ b/tools/libxc/xc_misc.c @@ -533,33 +533,27 @@ int xc_hvm_inject_msi( int xc_hvm_track_dirty_vram( xc_interface *xch, domid_t dom, - uint64_t first_pfn, uint64_t nr, + uint64_t first_gfn, uint32_t nr, unsigned long *dirty_bitmap) { + DECLARE_HVMCTL(track_dirty_vram, dom, + .first_gfn = first_gfn, + .nr = nr); DECLARE_HYPERCALL_BOUNCE(dirty_bitmap, (nr+7) / 8, XC_HYPERCALL_BUFFER_BOUNCE_OUT); - DECLARE_HYPERCALL_BUFFER(struct xen_hvm_track_dirty_vram, arg); int rc; - arg = xc_hypercall_buffer_alloc(xch, arg, sizeof(*arg)); - if ( arg == NULL || xc_hypercall_bounce_pre(xch, dirty_bitmap) ) + if ( xc_hypercall_bounce_pre(xch, dirty_bitmap) ) { PERROR("Could not bounce memory for xc_hvm_track_dirty_vram hypercall"); - rc = -1; - goto out; + return -1; } - arg->domid = dom; - arg->first_pfn = first_pfn; - arg->nr = nr; - set_xen_guest_handle(arg->dirty_bitmap, dirty_bitmap); - - rc = xencall2(xch->xcall, __HYPERVISOR_hvm_op, - HVMOP_track_dirty_vram, - HYPERCALL_BUFFER_AS_ARG(arg)); + set_xen_guest_handle(hvmctl.u.track_dirty_vram.dirty_bitmap, dirty_bitmap); + + rc = do_hvmctl(xch, &hvmctl); -out: - xc_hypercall_buffer_free(xch, arg); xc_hypercall_bounce_post(xch, dirty_bitmap); + return rc; } --- a/xen/arch/x86/hvm/control.c +++ b/xen/arch/x86/hvm/control.c @@ -17,6 +17,8 @@ #include #include #include +#include +#include #include static int set_pci_intx_level(struct domain *d, @@ -67,6 +69,27 @@ static int set_isa_irq_level(struct doma return 0; } +static int track_dirty_vram(struct domain *d, + const struct xen_hvm_track_dirty_vram *op) +{ + if ( !is_hvm_domain(d) ) + return -EINVAL; + + if ( op->rsvd || op->nr > (GB(1) >> PAGE_SHIFT) ) + return -EINVAL; + + if ( d->is_dying ) + return -ESRCH; + + if ( !d->max_vcpus || !d->vcpu[0] ) + return -EINVAL; + + return shadow_mode_enabled(d) + ? shadow_track_dirty_vram(d, op->first_gfn, op->nr, + op->dirty_bitmap) + : hap_track_dirty_vram(d, op->first_gfn, op->nr, op->dirty_bitmap); +} + /* * Note that this value is effectively part of the ABI, even if we don't need * to make it a formal part of it. Hence this value may only be changed if @@ -125,6 +148,10 @@ long do_hvmctl(XEN_GUEST_HANDLE_PARAM(xe op.u.set_pci_link_route.isa_irq); break; + case XEN_HVMCTL_track_dirty_vram: + rc = track_dirty_vram(d, &op.u.track_dirty_vram); + break; + default: rc = -EOPNOTSUPP; break; --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -5296,47 +5296,6 @@ long do_hvm_op(unsigned long op, XEN_GUE rc = guest_handle_is_null(arg) ? hvmop_flush_tlb_all() : -ENOSYS; break; - case HVMOP_track_dirty_vram: - { - struct xen_hvm_track_dirty_vram a; - struct domain *d; - - if ( copy_from_guest(&a, arg, 1) ) - return -EFAULT; - - rc = rcu_lock_remote_domain_by_id(a.domid, &d); - if ( rc != 0 ) - return rc; - - rc = -EINVAL; - if ( !is_hvm_domain(d) ) - goto tdv_fail; - - if ( a.nr > GB(1) >> PAGE_SHIFT ) - goto tdv_fail; - - rc = xsm_hvm_control(XSM_DM_PRIV, d, op); - if ( rc ) - goto tdv_fail; - - rc = -ESRCH; - if ( d->is_dying ) - goto tdv_fail; - - rc = -EINVAL; - if ( d->vcpu == NULL || d->vcpu[0] == NULL ) - goto tdv_fail; - - if ( shadow_mode_enabled(d) ) - rc = shadow_track_dirty_vram(d, a.first_pfn, a.nr, a.dirty_bitmap); - else - rc = hap_track_dirty_vram(d, a.first_pfn, a.nr, a.dirty_bitmap); - - tdv_fail: - rcu_unlock_domain(d); - break; - } - case HVMOP_modified_memory: { struct xen_hvm_modified_memory a; --- a/xen/include/public/hvm/control.h +++ b/xen/include/public/hvm/control.h @@ -55,6 +55,18 @@ struct xen_hvm_set_pci_link_route { uint8_t isa_irq; }; +/* XEN_HVMCTL_track_dirty_vram */ +struct xen_hvm_track_dirty_vram { + /* Number of pages to track. */ + uint32_t nr; + uint32_t rsvd; + /* First GFN to track. */ + uint64_aligned_t first_gfn; + /* OUT variable. */ + /* Dirty bitmap buffer. */ + XEN_GUEST_HANDLE_64(uint8) dirty_bitmap; +}; + struct xen_hvmctl { uint16_t interface_version; /* XEN_HVMCTL_INTERFACE_VERSION */ domid_t domain; @@ -62,11 +74,13 @@ struct xen_hvmctl { #define XEN_HVMCTL_set_pci_intx_level 1 #define XEN_HVMCTL_set_isa_irq_level 2 #define XEN_HVMCTL_set_pci_link_route 3 +#define XEN_HVMCTL_track_dirty_vram 4 uint16_t opaque; /* Must be zero on initial invocation. */ union { struct xen_hvm_set_pci_intx_level set_pci_intx_level; struct xen_hvm_set_isa_irq_level set_isa_irq_level; struct xen_hvm_set_pci_link_route set_pci_link_route; + struct xen_hvm_track_dirty_vram track_dirty_vram; uint8_t pad[120]; } u; }; --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -98,22 +98,6 @@ typedef enum { /* Following tools-only interfaces may change in future. */ #if defined(__XEN__) || defined(__XEN_TOOLS__) -/* Track dirty VRAM. */ -#define HVMOP_track_dirty_vram 6 -struct xen_hvm_track_dirty_vram { - /* Domain to be tracked. */ - domid_t domid; - /* Number of pages to track. */ - uint32_t nr; - /* First pfn to track. */ - uint64_aligned_t first_pfn; - /* OUT variable. */ - /* Dirty bitmap buffer. */ - XEN_GUEST_HANDLE_64(uint8) dirty_bitmap; -}; -typedef struct xen_hvm_track_dirty_vram xen_hvm_track_dirty_vram_t; -DEFINE_XEN_GUEST_HANDLE(xen_hvm_track_dirty_vram_t); - /* Notify that some pages got modified by the Device Model. */ #define HVMOP_modified_memory 7 struct xen_hvm_modified_memory { --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1174,9 +1174,6 @@ static int flask_hvm_param(struct domain case HVMOP_get_param: perm = HVM__GETPARAM; break; - case HVMOP_track_dirty_vram: - perm = HVM__TRACKDIRTYVRAM; - break; default: perm = HVM__HVMCTL; } @@ -1199,6 +1196,9 @@ static int flask_hvm_control(struct doma case XEN_HVMCTL_set_pci_link_route: perm = HVM__PCIROUTE; break; + case XEN_HVMCTL_track_dirty_vram: + perm = HVM__TRACKDIRTYVRAM; + break; default: perm = HVM__HVMCTL; break; --- a/xen/xsm/flask/policy/access_vectors +++ b/xen/xsm/flask/policy/access_vectors @@ -270,7 +270,7 @@ class hvm bind_irq # XEN_DOMCTL_pin_mem_cacheattr cacheattr -# HVMOP_track_dirty_vram +# XEN_HVMCTL_track_dirty_vram trackdirtyvram # HVMOP_modified_memory, HVMOP_get_mem_type, HVMOP_set_mem_type, # HVMOP_set_mem_access, HVMOP_get_mem_access, HVMOP_pagetable_dying,