From patchwork Thu Jun 23 08:39:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9194685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 401396075A for ; Thu, 23 Jun 2016 08:41:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E5002842F for ; Thu, 23 Jun 2016 08:41:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F9392843D; Thu, 23 Jun 2016 08:41:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A716B2842F for ; Thu, 23 Jun 2016 08:41:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG0AM-0004S2-AO; Thu, 23 Jun 2016 08:39:14 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG0AK-0004Rw-FL for xen-devel@lists.xen.org; Thu, 23 Jun 2016 08:39:12 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id CA/93-32749-F20AB675; Thu, 23 Jun 2016 08:39:11 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRWlGSWpSXmKPExsXS6fjDS1d/QXa 4wevvnBZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bLzbuYCi6yV5xY9IS1gXEfWxcjJ4eQQJ7E wSXdLCA2r4CdxNepK5lAbAkBQ4l981eB1bAIqEosvDYJrIZNQF2i7dl2VhBbREBXov3IPLB6Z gFfiZ9L+pm7GLk4hAWmMEp0tX9jBXGEBOYzSexZvpWxi5GDg1PAXmJVUzKIySsgKPF3hzBEr5 bEw1+3WCBsbYllC18zg5QwC0hLLP/HMYGRbxZCwywkDbOQNMxCaFjAyLKKUb04tagstUjXWC+ pKDM9oyQ3MTNH19DQRC83tbg4MT01JzGpWC85P3cTIzD4GIBgB+PdPudDjJIcTEqivFYO2eFC fEn5KZUZicUZ8UWlOanFhxhlODiUJHhF5wPlBItS01Mr0jJzgHEAk5bg4FES4W0HSfMWFyTmF memQ6ROMepyLPhxey2TEEtefl6qlDgvH0iRAEhRRmke3AhYTF5ilJUS5mUEOkqIpyC1KDezBF X+FaM4B6OSMG86yBSezLwSuE2vgI5gAjribj/YESWJCCmpBsYjeanCxjM0ypoe3UiK+B56QfV V2uKsZcEcP9IrbN2ThHmW3dT3vfGtj1W92SPjNB+bZqrsYYng+PnpTH2p+8///vk0f9Xb5w3X WF36K218kg9x+WbpOx0tvFLDGOJxJWO7z8vi9nny8quFD/zcMF+gk/f71Hkdzae+O3qzP3i0P jlgqZuqsBJLcUaioRZzUXEiAFitOk/EAgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1466671149!47469910!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7329 invoked from network); 23 Jun 2016 08:39:10 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-2.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 23 Jun 2016 08:39:10 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 23 Jun 2016 02:39:08 -0600 Message-Id: <576BBC4C02000078000F7F1F@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 23 Jun 2016 02:39:08 -0600 From: "Jan Beulich" To: "Daniel De Graaf" References: <20160622130335.GA410@mail-itl> <576AB3B102000078000F7B53@prv-mh.provo.novell.com> <20160622141314.GD1593@mail-itl> <576AC98102000078000F7BDE@prv-mh.provo.novell.com> <576BBABD02000078000F7F14@prv-mh.provo.novell.com> In-Reply-To: <576BBABD02000078000F7F14@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Disposition: inline Cc: marmarek@invisiblethingslab.com, xen-devel Subject: Re: [Xen-devel] PCI passthrough for HVM with stubdomain broken by "tools/libxl: handle the iomem parameter with the memory_mapping hcall" X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP >>> On 23.06.16 at 10:32, wrote: >>>> On 22.06.16 at 20:24, wrote: >> Either method works, and I agree allowing DM to invoke this domctl is both >> useful and not going to introduce problems. The getdomaininfo permission >> will also need to be added to the device_model macro in xen.if. > > What exactly this last sentence means I need to add I'm not sure > about. Perhaps this? Jan --- unstable.orig/tools/flask/policy/policy/modules/xen/xen.if +++ unstable/tools/flask/policy/policy/modules/xen/xen.if @@ -148,7 +148,7 @@ define(`device_model', ` create_channel($2, $1, $2_channel) allow $1 $2_channel:event create; - allow $1 $2_target:domain shutdown; + allow $1 $2_target:domain { getdomaininfo shutdown }; allow $1 $2_target:mmu { map_read map_write adjust physmap target_hack }; allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl irqlevel pciroute pcilevel cacheattr send_irq }; ')