From patchwork Thu Jul 7 07:32:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9217923 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C792160467 for ; Thu, 7 Jul 2016 07:34:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE55C2876F for ; Thu, 7 Jul 2016 07:34:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2EEA28775; Thu, 7 Jul 2016 07:34:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4E24E2876F for ; Thu, 7 Jul 2016 07:34:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3n7-0006E4-LY; Thu, 07 Jul 2016 07:32:09 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3n6-0006Dw-D9 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 07:32:08 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id 1C/A3-20705-7750E775; Thu, 07 Jul 2016 07:32:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRWlGSWpSXmKPExsXS6fjDS7ectS7 c4MtaTovvWyYzOTB6HP5whSWAMYo1My8pvyKBNePZ9onMBTPYK/5/2cLSwDiNrYuRk0NIIE/i 177TTCA2r4CdxJv7W1hAbAkBQ4l981eB1bAIqEpMv3iDEcRmE1CXaHu2nRXEFhGIkzh05S07i M0sUCHx4fFO5i5GDg5hgSCJ6evTIcbbSfQsmgo2nlPAXqLl3CcmkBJeAUGJvzuEITq1JB7+us UCYWtLLFv4GmwKs4C0xPJ/HBMY+WYhNMxC0jALScMshIYFjCyrGNWLU4vKUot0DfWSijLTM0p yEzNzdA0NjPVyU4uLE9NTcxKTivWS83M3MQIDjwEIdjAu/+h0iFGSg0lJlHfP3dpwIb6k/JTK jMTijPii0pzU4kOMGhwcAtt2rb7AKMWSl5+XqiTB+4u5LlxIsCg1PbUiLTMHGBswpRIcPEoiv G9B0rzFBYm5xZnpEKlTjLocC37cXsskBDZDSpz3BEiRAEhRRmke3AhYnF5ilJUS5mUEOlCIpy C1KDezBFX+FaM4B6OSMO8bkCk8mXklcJteAR3BBHTET5dqkCNKEhFSUg2MGqqfc3dG6wZyrNm 49kjyMe9sblUXwfD0o+VG93b/ynzWfm7+0sdXDnLP/BIsumHXfBX2WS3nH6eJ5vzQWb+u67yT 96WbFfeXGF63nRuiH6zAYN2zM8Zt/V3b5//UOGY1XavbWmDs4O2isKyU48+O5S2GXzQZj3cs2 bVZ8KugsvnEpS6XPiwwUWIpzkg01GIuKk4EAGg+SsrOAgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1467876725!49243855!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 59626 invoked from network); 7 Jul 2016 07:32:06 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-2.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 07:32:06 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 01:32:04 -0600 Message-Id: <577E219402000078000FBDB6@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:32:04 -0600 From: "Jan Beulich" To: ,, "Juergen Gross" References: <577E1FFE02000078000FBD8C@prv-mh.provo.novell.com> In-Reply-To: <577E1FFE02000078000FBD8C@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP We must not skip the transaction_end() call for a failed XS_TRANSACTION_START. The removed code fragment got introduced by commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart") without its description really indicating why it was added (and hence I can't identify whether a more complex change might be needed here). Signed-off-by: Jan Beulich Cc: Konrad Rzeszutek Wilk --- drivers/xen/xenbus/xenbus_xs.c | 3 --- 1 file changed, 3 deletions(-) --- 4.7-rc6-xen.orig/drivers/xen/xenbus/xenbus_xs.c +++ 4.7-rc6-xen/drivers/xen/xenbus/xenbus_xs.c @@ -249,9 +249,6 @@ void *xenbus_dev_request_and_reply(struc mutex_unlock(&xs_state.request_mutex); - if (IS_ERR(ret)) - return ret; - if ((msg->type == XS_TRANSACTION_END) || ((req_msg.type == XS_TRANSACTION_START) && (msg->type == XS_ERROR)))