From patchwork Thu Jul 7 07:32:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9217925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9FDF260467 for ; Thu, 7 Jul 2016 07:34:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9690C2876F for ; Thu, 7 Jul 2016 07:34:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B91228778; Thu, 7 Jul 2016 07:34:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 214F02876F for ; Thu, 7 Jul 2016 07:34:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3nc-0006JD-8K; Thu, 07 Jul 2016 07:32:40 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3nb-0006IM-3A for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 07:32:39 +0000 Received: from [85.158.139.211] by server-14.bemta-5.messagelabs.com id 0B/C9-29442-6950E775; Thu, 07 Jul 2016 07:32:38 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRWlGSWpSXmKPExsXS6fjDS3caa12 4wYSPbBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bllcEFRzgqvt6YytLAuIy9i5GTQ0ggT2LG wQ42EJtXwE7iQcNpRhBbQsBQYt/8VWBxFgFViYm3u8FsNgF1ibZn21lBbBGBOIlDV96CzWEWc JbYuKydBcQWFnCR6J91lhFivp1Ez6KpTCA2p4C9RMu5T0A2B9AuQYm/O4QhWrUkHv66xQJha0 ssW/iaGaSEWUBaYvk/jgmMfLMQGmYhaZiFpGEWQsMCRpZVjOrFqUVlqUW6pnpJRZnpGSW5iZk 5uoYGpnq5qcXFiempOYlJxXrJ+bmbGIGBxwAEOxi/9DsfYpTkYFIS5d1ztzZciC8pP6UyI7E4 I76oNCe1+BCjDAeHkgRvBktduJBgUWp6akVaZg4wBmDSEhw8SiK8GiBp3uKCxNzizHSI1ClGR SlxXk+QhABIIqM0D64NFneXGGWlhHkZgQ4R4ilILcrNLEGVf8UozsGoJMybBTKFJzOvBG76K6 DFTECLf7pUgywuSURISTUw8rjfuvo54JGToO6em1ExK3z3dTmnn1KtvVboLOixy1iVhWtlTu3 J32yWWrLBImqdH60S0u92PRevU3Lmeb3njzGLrNuD0vnPXR5eKcu6slLNJNhO5suEzO7YE38P W3Iy2G/2feD19H2g9R7ObU3mQho9SzksT/qfPfvq7O9k99dnJMJT7IyUWIozEg21mIuKEwHpT 0PqtgIAAA== X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1467876756!12510194!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 35835 invoked from network); 7 Jul 2016 07:32:37 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-12.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 07:32:37 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 01:32:35 -0600 Message-Id: <577E21B302000078000FBDB9@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:32:35 -0600 From: "Jan Beulich" To: ,, "Juergen Gross" References: <577E1FFE02000078000FBD8C@prv-mh.provo.novell.com> In-Reply-To: <577E1FFE02000078000FBD8C@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH 2/2] xenbus: simplify xenbus_dev_request_and_reply() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP No need to retain a local copy of the full request message, only the type is really needed. Signed-off-by: Jan Beulich --- drivers/xen/xenbus/xenbus_xs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- 4.7-rc6-xen.orig/drivers/xen/xenbus/xenbus_xs.c +++ 4.7-rc6-xen/drivers/xen/xenbus/xenbus_xs.c @@ -232,10 +232,10 @@ static void transaction_resume(void) void *xenbus_dev_request_and_reply(struct xsd_sockmsg *msg) { void *ret; - struct xsd_sockmsg req_msg = *msg; + enum xsd_sockmsg_type type = msg->type; int err; - if (req_msg.type == XS_TRANSACTION_START) + if (type == XS_TRANSACTION_START) transaction_start(); mutex_lock(&xs_state.request_mutex); @@ -250,8 +250,7 @@ void *xenbus_dev_request_and_reply(struc mutex_unlock(&xs_state.request_mutex); if ((msg->type == XS_TRANSACTION_END) || - ((req_msg.type == XS_TRANSACTION_START) && - (msg->type == XS_ERROR))) + ((type == XS_TRANSACTION_START) && (msg->type == XS_ERROR))) transaction_end(); return ret;