| Message ID | 577E233202000078000FBE11@prv-mh.provo.novell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > The functions such get passed to have been taking pointers to const > since at least 2.6.16. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Although the wording in the commit message looks weird to me, but I'm not a native speaker anyway. Roger.
On 07/07/16 10:45, Roger Pau Monne wrote: > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> The functions such get passed to have been taking pointers to const >> since at least 2.6.16. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > Acked-by: Roger Pau Monné <roger.pau@citrix.com> > > Although the wording in the commit message looks weird to me, but I'm not a > native speaker anyway. As a native speaker, I can't parse it either. I think s/such/these/ is needed. ~Andrew
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: > On 07/07/16 10:45, Roger Pau Monne wrote: > > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > >> The functions such get passed to have been taking pointers to const > >> since at least 2.6.16. > >> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Acked-by: Roger Pau Monné <roger.pau@citrix.com> > > > > Although the wording in the commit message looks weird to me, but I'm not a > > native speaker anyway. > > As a native speaker, I can't parse it either. > > I think s/such/these/ is needed. The functions such as these have been taking pointers to const since at least 2.6.16. ? > > ~Andrew > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
>>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote: > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: >> On 07/07/16 10:45, Roger Pau Monne wrote: >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> >> The functions such get passed to have been taking pointers to const >> >> since at least 2.6.16. >> >> >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com> >> > >> > Although the wording in the commit message looks weird to me, but I'm not a > >> > native speaker anyway. >> >> As a native speaker, I can't parse it either. >> >> I think s/such/these/ is needed. > > The functions such as these have been taking pointers to const > since at least 2.6.16. I had taken Andrew's suggestion literally and changed it to "The functions these get passed to have been taking pointers to const since at least 2.6.16" for a possible (if needed) resubmission. Jan
On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote: > >>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote: > > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: > >> On 07/07/16 10:45, Roger Pau Monne wrote: > >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > >> >> The functions such get passed to have been taking pointers to const > >> >> since at least 2.6.16. > >> >> > >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com> > >> > > >> > Although the wording in the commit message looks weird to me, but I'm not a > > > >> > native speaker anyway. > >> > >> As a native speaker, I can't parse it either. > >> > >> I think s/such/these/ is needed. > > > > The functions such as these have been taking pointers to const > > since at least 2.6.16. > > I had taken Andrew's suggestion literally and changed it to "The > functions these get passed to have been taking pointers to const > since at least 2.6.16" for a possible (if needed) resubmission. No need to resubmit. I will use Andrew's suggestion. > > Jan
--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c +++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c @@ -379,7 +379,7 @@ static struct attribute *xen_vbdstat_att NULL }; -static struct attribute_group xen_vbdstat_group = { +static const struct attribute_group xen_vbdstat_group = { .name = "statistics", .attrs = xen_vbdstat_attrs, };
The functions such get passed to have been taking pointers to const since at least 2.6.16. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- drivers/block/xen-blkback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)