From patchwork Thu Jul 7 07:41:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9217983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30C97607D9 for ; Thu, 7 Jul 2016 07:43:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 273AD2877E for ; Thu, 7 Jul 2016 07:43:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1ACA028785; Thu, 7 Jul 2016 07:43:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B5EB62877E for ; Thu, 7 Jul 2016 07:43:57 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3wY-000820-PT; Thu, 07 Jul 2016 07:41:54 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL3wW-00081o-VR for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 07:41:53 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 4E/D8-18304-0C70E775; Thu, 07 Jul 2016 07:41:52 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRWlGSWpSXmKPExsXS6fjDS3c/e12 4wfGlphbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aWdyuYC7pYK2ZeeMXSwLiKpYuRk0NIIE/i y5Zr7CA2r4CdxIMHr8FsCQFDiX3zV7GB2CwCqhK3n/exgthsAuoSbc+2g9kiAnESh668BatnF nCW2LisHWymsICXxMqOG4xdjBxAMwUl/u4QhijRknj46xYLhK0tsWzha2aQEmYBaYnl/zgmMP LMQmiYhaRhFpKGWQgNCxhZVjGqF6cWlaUW6VrqJRVlpmeU5CZm5ugaGhjr5aYWFyemp+YkJhX rJefnbmIEhlI9AwPjDsbXP50OMUpyMCmJ8u65WxsuxJeUn1KZkVicEV9UmpNafIhRhoNDSYI3 m60uXEiwKDU9tSItMwcY1DBpCQ4eJRFeN5A0b3FBYm5xZjpE6hSjLseCH7fXMgmx5OXnpUqJ8 2qBFAmAFGWU5sGNgEXYJUZZKWFeRgYGBiGegtSi3MwSVPlXjOIcjErCvK4gU3gy80rgNr0COo IJ6IifLtUgR5QkIqSkGhgLTZlsvD8K7XzXk7C0g2OpdgJ7tofUxbnd902M/kuy/H82I3x1zUt fn+CZKxMmJj9nW3LPyX2qzJUFotI8cQtcj6XPMONTPF12SO/9zrNNh1qcsvles0zNnus/70B+ t35x+8Pv7nGftn2QbTXNMlCXCqqO51QL8H7BttSdJZen/EtgWtnE5UosxRmJhlrMRcWJAMl+i sCrAgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1467877310!48586157!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25513 invoked from network); 7 Jul 2016 07:41:51 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-10.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 07:41:51 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 01:41:49 -0600 Message-Id: <577E23DC02000078000FBE3D@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:41:48 -0600 From: "Jan Beulich" To: ,, "Juergen Gross" Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH] xen/manage: correct return value check on xenbus_scanf() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/xen/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/manage.c +++ 4.7-rc6-xenbus_scanf/drivers/xen/manage.c @@ -275,7 +275,7 @@ static void sysrq_handler(struct xenbus_ err = xenbus_transaction_start(&xbt); if (err) return; - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) { + if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) <= 0) { pr_err("Unable to read sysrq code in control/sysrq\n"); xenbus_transaction_end(xbt, 1); return;