From patchwork Thu Jul 7 07:48:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9218007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C570607D9 for ; Thu, 7 Jul 2016 07:51:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FC3928789 for ; Thu, 7 Jul 2016 07:51:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 539902878B; Thu, 7 Jul 2016 07:51:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DDE3628789 for ; Thu, 7 Jul 2016 07:51:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL43N-0008Ua-N6; Thu, 07 Jul 2016 07:48:57 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL43M-0008UU-LS for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 07:48:56 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id FD/92-13025-7690E775; Thu, 07 Jul 2016 07:48:55 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRWlGSWpSXmKPExsXS6fjDSzedsy7 cYMpieYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNeNy70SWgsVsFT+fbGFqYJzA2sXIySEkkCfx 7OJxMJtXwE7icMMyRhBbQsBQYt/8VWwgNouAqsS0S4tZQGw2AXWJtmfbwepFBIwlHv9vY+9i5 OJgFrjEKHFm9mxmkISwgI/E0547QIM4gIYKSvzdIQwSZhbQknj46xYLhK0tsWzha2aQEmYBaY nl/zgmMPLMQmiYhaRhFpKGWQgNCxhZVjGqF6cWlaUW6VroJRVlpmeU5CZm5ugaGpjq5aYWFye mp+YkJhXrJefnbmIEBhMDEOxgPNjsfIhRkoNJSZR3z93acCG+pPyUyozE4oz4otKc1OJDjDIc HEoSvMYcdeFCgkWp6akVaZk5wLCGSUtw8CiJ8CaDpHmLCxJzizPTIVKnGHU5Fvy4vZZJiCUvP y9VSpy3CaRIAKQoozQPbgQsxi4xykoJ8zICHSXEU5BalJtZgir/ilGcg1FJmDcdZApPZl4J3K ZXQEcwAR3x06Ua5IiSRISUVANj3qUZE8z6jhhsSX2bMkuJdbMHl7T+zC03NoT9tl8roTmnpk3 33OrysqMn5zk7/1l80eDXpY4GwZmF//j+mXovd05OWxzRXsjNMqs8/8jcq2sXpzGfFBXg6X+w 8aytdINc1vkvz17br5Zmm38gj+PW1xVq6x37kx2m+s0/sHS5cVLGrWfMG0TtlViKMxINtZiLi hMBrk3mnqwCAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1467877733!36839881!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41157 invoked from network); 7 Jul 2016 07:48:55 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-15.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 07:48:55 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 01:48:53 -0600 Message-Id: <577E258502000078000FBE6F@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:48:53 -0600 From: "Jan Beulich" To: , Mime-Version: 1.0 Content-Disposition: inline Cc: Juergen Gross , xen-devel@lists.xenproject.org, Boris Ostrovsky , David Vrabel , linux-fbdev Subject: [Xen-devel] [PATCH] xen-fbfront: correct return value checks on xenbus_scanf() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/video/fbdev/xen-fbfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/video/fbdev/xen-fbfront.c +++ 4.7-rc6-xenbus_scanf/drivers/video/fbdev/xen-fbfront.c @@ -658,13 +658,13 @@ InitWait: goto InitWait; /* no InitWait seen yet, fudge it */ if (xenbus_scanf(XBT_NIL, info->xbdev->otherend, - "request-update", "%d", &val) < 0) + "request-update", "%d", &val) <= 0) val = 0; if (val) info->update_wanted = 1; if (xenbus_scanf(XBT_NIL, dev->otherend, - "feature-resize", "%d", &val) < 0) + "feature-resize", "%d", &val) <= 0) val = 0; info->feature_resize = val; break;