From patchwork Thu Jul 7 07:53:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9218041 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0CADE607D9 for ; Thu, 7 Jul 2016 07:56:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 019F92878D for ; Thu, 7 Jul 2016 07:56:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA4A92878F; Thu, 7 Jul 2016 07:56:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 96A3D2878D for ; Thu, 7 Jul 2016 07:56:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL481-0000kc-MR; Thu, 07 Jul 2016 07:53:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL480-0000kQ-NA for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 07:53:44 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id E9/2C-28354-78A0E775; Thu, 07 Jul 2016 07:53:43 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRWlGSWpSXmKPExsXS6fjDS7edqy7 coPGFrMX3LZOZHBg9Dn+4whLAGMWamZeUX5HAmjHh7TzmgovsFXNv8zYwbmHrYuTkEBLIk+jf dYAVxOYVsJNY8bKNHcSWEDCU2Dd/FVgNi4CqxO9Xy8FsNgF1ibZn28HqRQTkJU6vmMHSxcjFw SywgFHiwZt/TCAJYQFfiY23PzJ3MXIADRWU+LtDGCTMLKAl8fDXLRYIW1ti2cLXYCXMAtISy/ 9xTGDkmYXQMAtJwywkDbMQGhYwsqxi1ChOLSpLLdI1MtdLKspMzyjJTczM0TU0MNbLTS0uTkx PzUlMKtZLzs/dxAgMpnoGBsYdjC17/Q4xSnIwKYny7rlbGy7El5SfUpmRWJwRX1Sak1p8iFGG g0NJgjeBsy5cSLAoNT21Ii0zBxjWMGkJDh4lEd4QkDRvcUFibnFmOkTqFKMux4Ift9cyCbHk5 eelSonzPucAKhIAKcoozYMbAYuxS4yyUsK8jAwMDEI8BalFuZklqPKvGMU5GJWEIVbxZOaVwG 16BXQEE9ARP12qQY4oSURISTUwKm/hS0nJy5zfHWCTzRJl1BB8YeG7tqCTfNlNW3cI3fvQxXz GzfxpX+LJqZwty/6+5DcNF2T2NhKwyrS8eXGyvfnZ9OAA+SsKpcfmTz71M8I+yH/6ycR33cI6 0VGTxJ+sizW7tVd8tbVoW3lB4j8+9Vqx68m3jpc13Lxh2nE9/YCJvpZKPJsSS3FGoqEWc1FxI gBkkKCbrAIAAA== X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1467878021!32583933!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6265 invoked from network); 7 Jul 2016 07:53:43 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-12.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 07:53:43 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 01:53:41 -0600 Message-Id: <577E26A402000078000FBE93@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:53:40 -0600 From: "Jan Beulich" To: Mime-Version: 1.0 Content-Disposition: inline Cc: Juergen Gross , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, linux-input@vger.kernel.org Subject: [Xen-devel] [PATCH] xen-kbdfront: correct return value checks on xenbus_scanf() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/input/misc/xen-kbdfront.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/input/misc/xen-kbdfront.c +++ 4.7-rc6-xenbus_scanf/drivers/input/misc/xen-kbdfront.c @@ -127,7 +127,8 @@ static int xenkbd_probe(struct xenbus_de if (!info->page) goto error_nomem; - if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-abs-pointer", "%d", &abs) < 0) + if (xenbus_scanf(XBT_NIL, dev->otherend, + "feature-abs-pointer", "%d", &abs) <= 0) abs = 0; if (abs) { ret = xenbus_printf(XBT_NIL, dev->nodename, @@ -324,7 +325,7 @@ static void xenkbd_backend_changed(struc InitWait: ret = xenbus_scanf(XBT_NIL, info->xbdev->otherend, "feature-abs-pointer", "%d", &val); - if (ret < 0) + if (ret <= 0) val = 0; if (val) { ret = xenbus_printf(XBT_NIL, info->xbdev->nodename,