From patchwork Thu Jul 7 08:00:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9218107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E3D0C6048B for ; Thu, 7 Jul 2016 08:02:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8B3C2879D for ; Thu, 7 Jul 2016 08:02:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD7E42879F; Thu, 7 Jul 2016 08:02:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 607392879D for ; Thu, 7 Jul 2016 08:02:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL4ED-0002ZC-Ri; Thu, 07 Jul 2016 08:00:09 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL4EB-0002YR-RS for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 08:00:07 +0000 Received: from [193.109.254.147] by server-9.bemta-14.messagelabs.com id 8F/F1-32749-70C0E775; Thu, 07 Jul 2016 08:00:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeJIrShJLcpLzFFi42LpdPzhpcvEUxd uMPOEmcX3LZOZHBg9Dn+4whLAGMWamZeUX5HAmrH38132grVcFSsvHGdpYLzP0cXIySEkkCcx a8Vf1i5GDg5eATuJ3tsJIGEJAUOJffNXsYHYLAKqEsePHWcEsdkE1CXanm1nBbFFBOIkDl15y w5iMwt4S0x6vBEsLiwQKfGj9yE7xEhBib87hCFKtCQe/rrFAmFrSyxb+JoZpIRZQFpi+T+OCY w8sxAaZiFpmIWkYRZCwwJGllWMGsWpRWWpRbpG5npJRZnpGSW5iZk5uoaGJnq5qcXFiempOYl JxXrJ+bmbGIGhVM/AwLiDcfplv0OMkhxMSqK8e+7WhgvxJeWnVGYkFmfEF5XmpBYfYpTh4FCS 4O3kqgsXEixKTU+tSMvMAQY1TFqCg0dJhLceJM1bXJCYW5yZDpE6xagoJc7bDpIQAElklObBt cEi6RKjrJQwLyMDA4MQT0FqUW5mCar8K0ZxDkYlYd42kCk8mXklcNNfAS1mAlr806UaZHFJIk JKqoFxHzvPAgML/532uidEWBfldnEGh8i1Sx827XBOMU5aLvn31sXqQ7vPf7iyf2Vl57YuATn 3nzNenIuLiWGWCU7SKdx1Y62EW3PIDP/zayy+uRUd5FvOuq8o3CLwwxF3nVILmQeB+053pDMa P96lIhK1T+jifL8A/uM9D96debm68Og7u2u2/zOVWIozEg21mIuKEwE98B3OnwIAAA== X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1467878400!52059420!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25811 invoked from network); 7 Jul 2016 08:00:02 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Jul 2016 08:00:02 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 07 Jul 2016 02:00:00 -0600 Message-Id: <577E282002000078000FBECB@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 02:00:00 -0600 From: "Jan Beulich" To: ,, "Juergen Gross" Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel , netdev@vger.kernel.org Subject: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write() over xenbus_printf() where possible X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP ... as being the simpler variant. Signed-off-by: Jan Beulich --- drivers/net/xen-netfront.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/net/xen-netfront.c +++ 4.7-rc6-prefer-xenbus_write/drivers/net/xen-netfront.c @@ -1886,26 +1886,25 @@ again: } /* The remaining keys are not queue-specific */ - err = xenbus_printf(xbt, dev->nodename, "request-rx-copy", "%u", - 1); + err = xenbus_write(xbt, dev->nodename, "request-rx-copy", "1"); if (err) { message = "writing request-rx-copy"; goto abort_transaction; } - err = xenbus_printf(xbt, dev->nodename, "feature-rx-notify", "%d", 1); + err = xenbus_write(xbt, dev->nodename, "feature-rx-notify", "1"); if (err) { message = "writing feature-rx-notify"; goto abort_transaction; } - err = xenbus_printf(xbt, dev->nodename, "feature-sg", "%d", 1); + err = xenbus_write(xbt, dev->nodename, "feature-sg", "1"); if (err) { message = "writing feature-sg"; goto abort_transaction; } - err = xenbus_printf(xbt, dev->nodename, "feature-gso-tcpv4", "%d", 1); + err = xenbus_write(xbt, dev->nodename, "feature-gso-tcpv4", "1"); if (err) { message = "writing feature-gso-tcpv4"; goto abort_transaction;