From patchwork Thu Aug 25 06:44:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9298741 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 60CB1607F0 for ; Thu, 25 Aug 2016 06:47:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51C30291C4 for ; Thu, 25 Aug 2016 06:47:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 452CE291E8; Thu, 25 Aug 2016 06:47:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C1AA2291C4 for ; Thu, 25 Aug 2016 06:47:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcoPB-00052F-Ve; Thu, 25 Aug 2016 06:44:49 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcoPA-000529-PI for xen-devel@lists.xenproject.org; Thu, 25 Aug 2016 06:44:48 +0000 Received: from [193.109.254.147] by server-3.bemta-6.messagelabs.com id C1/17-05661-0E39EB75; Thu, 25 Aug 2016 06:44:48 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRWlGSWpSXmKPExsXS6fjDS/f+5H3 hBpeWa1p83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBkbD1xiLWjiqzi74hRLA+Mpri5GTg4hgTyJ s083MoPYvAJ2Et0zjzKB2BIChhJP319nA7FZBFQl3mxuYQGx2QTUJdqebWcFsUUEFCU+3jrFC GIzC4RJNL6aC1YvLGAlse7LOqCZXEDz2xkl5n24BZbgFAiR2NDbDtTAAbRMUOLvDmGIXi2Jh7 9usUDY2hLLFr5mBilhFpCWWP6PYwIj3yyEhllIGmYhaZiF0LCAkWUVo3pxalFZapGuiV5SUWZ 6RkluYmaOrqGBmV5uanFxYnpqTmJSsV5yfu4mRmDwMQDBDsbuy/6HGCU5mJREeVm694UL8SXl p1RmJBZnxBeV5qQWH2KU4eBQkuD9MwkoJ1iUmp5akZaZA4wDmLQEB4+SCO9skDRvcUFibnFmO kTqFKOilDhvO0hCACSRUZoH1waLvUuMslLCvIxAhwjxFKQW5WaWoMq/YhTnYFQS5n0LMoUnM6 8EbvoroMVMQItb7u8GWVySiJCSamDUnlG6x+to6tb+A08+FMn+0UqKaXhzQlw0qpRPYeuEKm2 vu6H3F3m4m6zaVKbmkpY9q/7hjN+fz6semTSpztPRfWZXlfWlb71KHtmXNl/Z8v3BGoXrqacf nJZ03nGhSGJLkWP4s96zr6f6TKideVlvai6v8A8Bu6ibXUYyNjcWVz26wB/VWHxZiaU4I9FQi 7moOBEAESV/krgCAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1472107485!3180104!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41920 invoked from network); 25 Aug 2016 06:44:47 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-2.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 25 Aug 2016 06:44:47 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 25 Aug 2016 00:44:45 -0600 Message-Id: <57BEAFFC0200007800108D8C@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Thu, 25 Aug 2016 00:44:44 -0600 From: "Jan Beulich" To: "Feng Wu" References: <57BD6EC00200007800108794@prv-mh.provo.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Disposition: inline Cc: xen-devel , Kevin Tian Subject: Re: [Xen-devel] [PATCH] VT-d: drop pointless uses of __func__ X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP >>> On 25.08.16 at 03:08, wrote: >> From: Jan Beulich [mailto:JBeulich@suse.com] >> Subject: [PATCH] VT-d: drop pointless uses of __func__ >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -129,11 +129,11 @@ static int context_get_domain_id(struct >> >> dom_index = context_domain_id(*context); >> >> - if ( dom_index < nr_dom && iommu->domid_map) >> + if ( dom_index < nr_dom && iommu->domid_map ) >> domid = iommu->domid_map[dom_index]; >> else >> - dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds >> nr_dom %lu or iommu has no domid_map\n", >> - __func__, dom_index, nr_dom); >> + dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds >> nr_dom %lu or iommu has no domid_map\n", > > This line exceeds the 80 characters limitation, do we have better way to > handle this? Indeed; I had noticed this too (after sending) and intend to break it like this: Jan --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -129,11 +129,12 @@ static int context_get_domain_id(struct dom_index = context_domain_id(*context); - if ( dom_index < nr_dom && iommu->domid_map) + if ( dom_index < nr_dom && iommu->domid_map ) domid = iommu->domid_map[dom_index]; else - dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n", - __func__, dom_index, nr_dom); + dprintk(XENLOG_DEBUG VTDPREFIX, + "dom_index %lu exceeds nr_dom %lu or iommu has no domid_map\n", + dom_index, nr_dom); } return domid; }