diff mbox

x86: drop leftover uses of regparm attribute

Message ID 57C80C29020000780010AC34@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Sept. 1, 2016, 9:08 a.m. UTC 
These were relevant only for 32-bit builds on Xen.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86: drop leftover uses of regparm attribute

These were relevant only for 32-bit builds on Xen.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2200,10 +2200,8 @@ void guest_io_write(unsigned int port, u
 }
 
 /* I/O emulation support. Helper routines for, and type of, the stack stub.*/
-void host_to_guest_gpr_switch(struct cpu_user_regs *)
-    __attribute__((__regparm__(1)));
-unsigned long guest_to_host_gpr_switch(unsigned long)
-    __attribute__((__regparm__(1)));
+void host_to_guest_gpr_switch(struct cpu_user_regs *);
+unsigned long guest_to_host_gpr_switch(unsigned long);
 
 void (*pv_post_outb_hook)(unsigned int port, u8 value);
 
@@ -2262,7 +2260,7 @@ static int emulate_privileged_op(struct
                            : (*(u16 *)&regs->reg = (val)))
     unsigned long code_base, code_limit;
     char *io_emul_stub = NULL;
-    void (*io_emul)(struct cpu_user_regs *) __attribute__((__regparm__(1)));
+    void (*io_emul)(struct cpu_user_regs *);
     uint64_t val;
     bool_t vpmu_msr;

Comments

Andrew Cooper Sept. 1, 2016, 9:50 a.m. UTC | #1 
On 01/09/16 10:08, Jan Beulich wrote:
> These were relevant only for 32-bit builds on Xen.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2200,10 +2200,8 @@  void guest_io_write(unsigned int port, u
 }
 
 /* I/O emulation support. Helper routines for, and type of, the stack stub.*/
-void host_to_guest_gpr_switch(struct cpu_user_regs *)
-    __attribute__((__regparm__(1)));
-unsigned long guest_to_host_gpr_switch(unsigned long)
-    __attribute__((__regparm__(1)));
+void host_to_guest_gpr_switch(struct cpu_user_regs *);
+unsigned long guest_to_host_gpr_switch(unsigned long);
 
 void (*pv_post_outb_hook)(unsigned int port, u8 value);
 
@@ -2262,7 +2260,7 @@  static int emulate_privileged_op(struct
                            : (*(u16 *)&regs->reg = (val)))
     unsigned long code_base, code_limit;
     char *io_emul_stub = NULL;
-    void (*io_emul)(struct cpu_user_regs *) __attribute__((__regparm__(1)));
+    void (*io_emul)(struct cpu_user_regs *);
     uint64_t val;
     bool_t vpmu_msr;