From patchwork Tue Sep 20 13:04:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9341653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC422601C2 for ; Tue, 20 Sep 2016 13:07:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD535295DE for ; Tue, 20 Sep 2016 13:07:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D17ED299B6; Tue, 20 Sep 2016 13:07:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 83E4A295DE for ; Tue, 20 Sep 2016 13:07:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmKit-0000sq-5t; Tue, 20 Sep 2016 13:04:31 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmKis-0000sk-31 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2016 13:04:30 +0000 Received: from [193.109.254.147] by server-4.bemta-6.messagelabs.com id 6B/B2-29421-DD331E75; Tue, 20 Sep 2016 13:04:29 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRWlGSWpSXmKPExsXS6fjDS/eO8cN wg7VHZS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oy1E48wFWzkr9hyZj17A+MK3i5GTg4hgTyJ hoaljCA2r4CdxKEXv8BsCQFDiafvr7OB2CwCqhLTPq0Gs9kE1CXanm1n7WLk4BARMJA4dzQJx GQWCJTYOg8sKizgJjFvUxyIySsgKPF3hzBIHzPQ7Mu79jBNYOSahZCZhSQDYWtJPPx1iwXC1p ZYtvA18yyw8dISy/9xQJjWEo+buVBVgNhuEi0NvUwLGDlWMaoXpxaVpRbpGuslFWWmZ5TkJmb m6BoamOnlphYXJ6an5iQmFesl5+duYgQGHQMQ7GDs+Od0iFGSg0lJlFeO70G4EF9SfkplRmJx RnxRaU5q8SFGGQ4OJQleQaOH4UKCRanpqRVpmTnA8IdJS3DwKInw8oOkeYsLEnOLM9MhUqcYF aXEefNAEgIgiYzSPLg2WMxdYpSVEuZlBDpEiKcgtSg3swRV/hWjOAejkjCvK8gUnsy8Erjpr4 AWMwEt3vLzAcjikkSElBQwireFzP++xGmlKeP2d2xXljSfOh4mbT5r47SkOKv+pRLOzEUcbxb kb++WWNTTuWbNV6vLlW/MvXg9C6qUND+vkZatKN3HFy2Wt2TFFeslKV8i9MMKztxYfyT1Y8WX jzocomyb72lqu7v8exN82cB0J+fTGcwVq8+0bFIqaOd8uKHtoe/n6Q/fK7EUZyQaajEXFScCA D3P9Le0AgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1474376666!60287847!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21242 invoked from network); 20 Sep 2016 13:04:28 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-5.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Sep 2016 13:04:28 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Tue, 20 Sep 2016 07:04:26 -0600 Message-Id: <57E14FF702000078001109F7@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Tue, 20 Sep 2016 07:04:23 -0600 From: "Jan Beulich" To: "xen-devel" Mime-Version: 1.0 Cc: Kevin Tian , Jun Nakajima Subject: [Xen-devel] [PATCH] VMX: don't bypass vmx_update_secondary_exec_control() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP While putting together another patch modifying the secondary exec controls I noticed that vmx_vcpu_update_vmfunc_ve() does a raw VMWRITE instead of going through the designated function. I assume that is not how it should be. Signed-off-by: Jan Beulich VMX: don't bypass vmx_update_secondary_exec_control() While putting together another patch modifying the secondary exec controls I noticed that vmx_vcpu_update_vmfunc_ve() does a raw VMWRITE instead of going through the designated function. I assume that is not how it should be. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2062,9 +2062,7 @@ static void vmx_vcpu_update_vmfunc_ve(st else v->arch.hvm_vmx.secondary_exec_control &= ~mask; - __vmwrite(SECONDARY_VM_EXEC_CONTROL, - v->arch.hvm_vmx.secondary_exec_control); - + vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); } Acked-by: Kevin Tian --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2062,9 +2062,7 @@ static void vmx_vcpu_update_vmfunc_ve(st else v->arch.hvm_vmx.secondary_exec_control &= ~mask; - __vmwrite(SECONDARY_VM_EXEC_CONTROL, - v->arch.hvm_vmx.secondary_exec_control); - + vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); }