diff mbox

x86/shutdown: add fall-through comment

Message ID 582056C3020000780011C96B@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Nov. 7, 2016, 9:26 a.m. UTC 
Coverity ID: 1362037

Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/shutdown: add fall-through comment

Coverity ID: 1362037

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
         {
         case BOOT_INVALID:
             ASSERT_UNREACHABLE();
+            /* fall through */
         case BOOT_KBD:
             /* Pulse the keyboard reset line. */
             for ( i = 0; i < 100; i++ )

Comments

Andrew Cooper Nov. 7, 2016, 10:23 a.m. UTC | #1 
On 07/11/16 09:26, Jan Beulich wrote:
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
>          {
>          case BOOT_INVALID:
>              ASSERT_UNREACHABLE();
> +            /* fall through */
>          case BOOT_KBD:
>              /* Pulse the keyboard reset line. */
>              for ( i = 0; i < 100; i++ )
>
>
>
Wei Liu Nov. 7, 2016, 10:42 a.m. UTC | #2 
On Mon, Nov 07, 2016 at 02:26:11AM -0700, Jan Beulich wrote:
> Coverity ID: 1362037
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
>          {
>          case BOOT_INVALID:
>              ASSERT_UNREACHABLE();
> +            /* fall through */
>          case BOOT_KBD:
>              /* Pulse the keyboard reset line. */
>              for ( i = 0; i < 100; i++ )
> 
> 
> 

> x86/shutdown: add fall-through comment
> 
> Coverity ID: 1362037
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Release-acked-by: Wei Liu <wei.liu2@citrix.com>
diff mbox

Patch

--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -541,6 +541,7 @@  void machine_restart(unsigned int delay_
         {
         case BOOT_INVALID:
             ASSERT_UNREACHABLE();
+            /* fall through */
         case BOOT_KBD:
             /* Pulse the keyboard reset line. */
             for ( i = 0; i < 100; i++ )